From: "Jochen Voß" <jochen.voss@googlemail.com>
To: "Jeff Kirsher" <jeffrey.t.kirsher@intel.com>
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net,
akpm@linux-foundation.org,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] e1000: fix stack size
Date: Thu, 28 Aug 2008 11:17:19 +0100 [thread overview]
Message-ID: <ef1cd66f0808280317r72f98402x5f4c23bf4aaf100d@mail.gmail.com> (raw)
In-Reply-To: <20080827081446.9269.19136.stgit@jtkirshe-mobile.jf.intel.com>
Hi,
2008/8/27 Jeff Kirsher <jeffrey.t.kirsher@intel.com>:
> From: Linus Torvalds <torvalds@linux-foundation.org>
>
> Here's the patch. It shrinks the stack from 1152 bytes to 192 bytes (the
> first version, that only did the e1000_option part, got it down to 600
> bytes). About half comes from not using multiple "e1000_option"
> structures, the other half comes from turning the "e1000_opt_list[]"
> arrays into "static const" instead, so that gcc doesn't copy them onto the
> stack.
>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Reveiewed-by: Auke Kok <auke-jan.h.kok@intel.com>
^^^^^^^^^^^^^^
typo here
> Tested-by: Emil Tantilov <emil.s.tantilov@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
I hope this helps,
Jochen
--
http://seehuhn.de/
prev parent reply other threads:[~2008-08-28 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 8:14 Jeff Kirsher
2008-08-28 10:17 ` Jochen Voß [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef1cd66f0808280317r72f98402x5f4c23bf4aaf100d@mail.gmail.com \
--to=jochen.voss@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®