From: "Arnd Bergmann" <arnd@arndb.de>
To: "Firas Ashkar" <firas.ashkar@savoirfairelinux.com>,
alex@digriz.org.uk, "Ulf Hansson" <ulf.hansson@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
"linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: add TS7800 FPGA based MMC controller driver
Date: Thu, 20 Oct 2022 16:44:31 +0200 [thread overview]
Message-ID: <ef23d179-15fa-4ad9-8ddc-ccad7790f8d0@app.fastmail.com> (raw)
In-Reply-To: <0f29aa0297d6fc5daa86f81925754c1f6d3f679c.camel@savoirfairelinux.com>
On Thu, Oct 20, 2022, at 16:42, firas ashkar wrote:
>>
>> > +
>> > +#define DRIVER_NAME "ts7800v1_sdmmc"
>>
>> Maybe drop this macro and just use the string directly.
> This define macro used in multiple locations
Yes, exactly that is the problem. Other drivers use the
same macro name, so it's very hard to grep for the actual
string.
Arnd
prev parent reply other threads:[~2022-10-20 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221018133800.10636-1-firas.ashkar@savoirfairelinux.com>
[not found] ` <a577dfcf-5a0a-4568-8f6d-872a8324dfcc@app.fastmail.com>
2022-10-20 14:42 ` firas ashkar
2022-10-20 14:44 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef23d179-15fa-4ad9-8ddc-ccad7790f8d0@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alex@digriz.org.uk \
--cc=firas.ashkar@savoirfairelinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®