From: Ping-Ke Shih <pkshih@realtek.com>
To: Minjie Du <duminjie@vivo.com>, "kvalo@kernel.org" <kvalo@kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] drivers: fix the parameter bin reference preceded by free
Date: Thu, 1 Jun 2023 07:41:05 +0000 [thread overview]
Message-ID: <ef245c4f59f8419da9011d1b3d522e6e@realtek.com> (raw)
In-Reply-To: <20230601072322.486-1-duminjie@vivo.com>
> -----Original Message-----
> From: Minjie Du <duminjie@vivo.com>
> Sent: Thursday, June 1, 2023 3:23 PM
> To: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; Minjie Du <duminjie@vivo.com>
> Subject: [PATCH v1] drivers: fix the parameter bin reference preceded by free
subject prefix should be "wifi: rtw89: fix ... "
>
> We assign the variable bin to NULL,
> fix variable bin reference preceded by free.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/net/wireless/realtek/rtw89/debug.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/debug.c b/drivers/net/wireless/realtek/rtw89/debug.c
> index 6f418f14ec3f..4541b4d48e69 100644
> --- a/drivers/net/wireless/realtek/rtw89/debug.c
> +++ b/drivers/net/wireless/realtek/rtw89/debug.c
> @@ -2982,6 +2982,7 @@ static u8 *rtw89_hex2bin_user(struct rtw89_dev *rtwdev,
> if (hex2bin(bin, buf, num)) {
> rtw89_info(rtwdev, "valid format: H1H2H3...\n");
> kfree(bin);
> + bin = NULL;
> err = -EINVAL;
> }
Do you meet real problem? or code checker finds this?
When 'err' is set, we don't touch 'bin' anymore.
Ping-Ke
prev parent reply other threads:[~2023-06-01 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 7:23 Minjie Du
2023-06-01 7:41 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef245c4f59f8419da9011d1b3d522e6e@realtek.com \
--to=pkshih@realtek.com \
--cc=duminjie@vivo.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome