From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbdFPP7y (ORCPT ); Fri, 16 Jun 2017 11:59:54 -0400 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:49521 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbdFPP7x (ORCPT ); Fri, 16 Jun 2017 11:59:53 -0400 Subject: Re: [PATCH v2 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver To: Jose Abreu , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Carlos Palminha , Mauro Carvalho Chehab , Hans Verkuil References: <25d20060-f6b7-3a37-0509-39a734e6660a@xs4all.nl> <3a1abd40-4503-44f1-7cc5-ad757a7c5572@synopsys.com> <0ebac69e-8de3-e65e-d6f5-dfb4fed3585c@xs4all.nl> <900bfa50-2cc3-2b33-8531-2c65ebd3a981@synopsys.com> From: Hans Verkuil Message-ID: Date: Fri, 16 Jun 2017 17:59:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <900bfa50-2cc3-2b33-8531-2c65ebd3a981@synopsys.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2017 05:52 PM, Jose Abreu wrote: > Hi Hans, > > > On 16-06-2017 14:44, Hans Verkuil wrote: >> >>>> >>>> >>>>> + /* CEC */ >>>>> + dw_dev->cec_adap = cec_allocate_adapter(&dw_hdmi_cec_adap_ops, >>>>> + dw_dev, dev_name(dev), CEC_CAP_TRANSMIT | >>>>> + CEC_CAP_PHYS_ADDR | CEC_CAP_LOG_ADDRS, >>>> Add CEC_CAP_RC and CEC_CAP_PASSTHROUGH. >>>> >>>> I'm not sure about CEC_CAP_PHYS_ADDR. The problem here is that this driver >>>> doesn't handle the EDID, but without that it doesn't know what physical >>>> address to use. >>>> >>>> I wonder if the cec-notifier can be used for this, possibly with adaptations. >>>> Relying on users to set the physical address is a last resort since it is very >>>> painful to do so. cec-notifier was specifically designed to solve this. >>> Yes, EDID ROM is not integrated into the controller so I can't >>> add the code. How exactly can I use cec-notifier here? >> drivers/media/platform/sti/cec/stih-cec.c is a good example. The notifier is >> called by drivers/gpu/drm/sti/sti_hdmi.c. > > Done! Implemented and working :) I'm wondering if you want me to > wait some more time for other comments or just send the v3 now? I > also added support for SCDC read request (its a matter of > activating a bit). Well, if it is ready, then just send a v3! > BTW, I used the DT node name "hdmi-phandle" but I don't know if > it is the best because it can cause confusion about the > hdmi-phandle that you documented in media/cec.txt I had the same thought. It doesn't really fit for CEC adapters on HDMI receivers. Perhaps edid-phandle? Or something else? Regards, Hans