From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC27A168B7 for ; Thu, 4 Jul 2024 01:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720058282; cv=none; b=bAwHv9JrPOl/zVeE4R6v3xO4RSuvr6lcrYN8S9qh+qHyqAO+iJUEUJkibY9t7NoZig1rF6g5kPR/SQh/qMkICqvJjVBBh1HCWASqouRr+WI3rhZVuvc2RTKS+dIzZvz/BM4AGKgzpyivvBnOKOLa1jzBT9Zq+UChhbq4KJ9stm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720058282; c=relaxed/simple; bh=4VRj+kijjSJj2Fdr88o6cAz3I0adkI9ew6ictpb5PGo=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=KVYyjkbpe1fCoYfLeW9yd7SmgRrcgQ8DStcJmlD+jB8UilpzDaaEb5IOzIAv/WtStu3Vbuec7/8t+Asba62db2ibAXdak4fi1ugCtInOJM40ST9Ok7fUvp840blBtFdHGcvfZ+sOJPrlSIvRVU5Aq29HTVmLvMlYkh77D7MdUWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4WF06x1n8lz2CkwM; Thu, 4 Jul 2024 09:53:45 +0800 (CST) Received: from kwepemd200012.china.huawei.com (unknown [7.221.188.145]) by mail.maildlp.com (Postfix) with ESMTPS id 0BF8514010C; Thu, 4 Jul 2024 09:57:52 +0800 (CST) Received: from kwepemd100011.china.huawei.com (7.221.188.204) by kwepemd200012.china.huawei.com (7.221.188.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Thu, 4 Jul 2024 09:57:51 +0800 Received: from kwepemd100011.china.huawei.com ([7.221.188.204]) by kwepemd100011.china.huawei.com ([7.221.188.204]) with mapi id 15.02.1258.034; Thu, 4 Jul 2024 09:57:51 +0800 From: duchangbin To: duchangbin CC: Paul Walmsley , Palmer Dabbelt , Albert Ou , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] riscv: vdso: do not strip debugging info for vdso.so.dbg Thread-Topic: [PATCH] riscv: vdso: do not strip debugging info for vdso.so.dbg Thread-Index: AQHau7U7yIu3oUXsbUGaQgARcdrle7Hl86SA Date: Thu, 4 Jul 2024 01:57:51 +0000 Message-ID: References: <20240611040947.3024710-1-changbin.du@huawei.com> In-Reply-To: <20240611040947.3024710-1-changbin.du@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-imapappendstamp: kwepemd100011.china.huawei.com (15.02.1258.034) x-ms-exchange-messagesentrepresentingtype: 1 Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, Is there any problem with this change? Ping~ On Tue, Jun 11, 2024 at 12:09:47PM +0800, Changbin Du wrote: > The vdso.so.dbg is a debug version of vdso and could be used for debuggin= g > purpose. For example, perf-annotate requires debugging info to show sourc= e > lines. So let's keep its debugging info. >=20 > Signed-off-by: Changbin Du > --- > arch/riscv/kernel/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Mak= efile > index f7ef8ad9b550..960feb1526ca 100644 > --- a/arch/riscv/kernel/vdso/Makefile > +++ b/arch/riscv/kernel/vdso/Makefile > @@ -45,7 +45,7 @@ $(obj)/vdso.o: $(obj)/vdso.so > # link rule for the .so file, .lds has to be first > $(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE > $(call if_changed,vdsold) > -LDFLAGS_vdso.so.dbg =3D -shared -S -soname=3Dlinux-vdso.so.1 \ > +LDFLAGS_vdso.so.dbg =3D -shared -soname=3Dlinux-vdso.so.1 \ > --build-id=3Dsha1 --hash-style=3Dboth --eh-frame-hdr > =20 > # strip rule for the .so file > --=20 > 2.34.1 >=20 --=20 Cheers, Changbin Du