From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318F93370FE for ; Fri, 9 Jan 2026 10:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767953611; cv=none; b=ZiAffACQ4BaxzNSHQiTLFyEaGptDrEtcjfS/yGNQSOSKzJW/KcStw4ORtO29iMjDwAJ4EhDlci8UuAYAvo3vTN6s9pvYJaAF8tMjGn2sYh0ibgatifrIcBufCtZUXpMRG1Qn/GYaBlXLa3+HngVVngHZIdbwrPJUs0ImqI9p8pc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767953611; c=relaxed/simple; bh=yXMsr8zM5W0NidfzhDEAVyLX6qDA6qMap15O3IWhwt0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=TN2LK8Xc8pE1WrQigjPrChYYy+tRuXhAteuzGP07JVOInCKMO7NGDLmLecOtTlLX5aNcWUeG7l4BQGG4+bvBAKeqbYLcJPT1bEw154yIu16CMArFtugDYnfB/bvDQeO70+3ElDwvHrfhPuJUYNKFsqU+X77yHeEEFToZluVqoaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PtBlWZhK; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PtBlWZhK" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-432d2c96215so1184700f8f.3 for ; Fri, 09 Jan 2026 02:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767953607; x=1768558407; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=azmATrh1ehd50qg4sLH5mbIDJwpy+FR7iJS1nCS0pn0=; b=PtBlWZhKRvqBlP48R+aGjUhHrx+27cdPDRR02K9AM++q+0jZwzL7BdQHeSsJxy4Ec/ LNx66h8ccKeGvM5ExF1rlikPCyPRgpbbsCYJCtNJw1YJNygGoZ7PSEyIis789RfH6pXf FOfXHhw1Nu5+hPNWBLYsBCMJLTA1flsuc65oMxgIpyjerqarXDNebGyGfGqOgJwnJV/f avt8RV1oVTsCSkizFogUf8XLjiPvcOKQJBBqUX8n6QFEgw/2L4o66T/3jaxFCgxZF96P EZyksb91FqQPbix6dTTnHkTShXQ+m/460NV6g75btfGGUhcogicpChc4uQuGpKHNSHLD TjjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767953607; x=1768558407; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azmATrh1ehd50qg4sLH5mbIDJwpy+FR7iJS1nCS0pn0=; b=sHDUqqk7sy9QLvMnB+TYCBK8N+CRtbJkmWF3aY08ueEEsmeMf6uMgPNMPBpM0kAEtD v5zICaG5oD8+bwEAI+Ne6lEZO5DitoZ/K6wkVnBKeuICEebPOQiX9ZHCeGcq+8onXMgG 2sEYy36quh3pUFWery7ZTZ80tsePrEQBfxZhDmYOcR6TaNeTPg+5GH5HcFngPfWBfLk2 WEipJQ14jqbFSTq3PsvNf2HuaSlD8kqg4zgVqwv9MOBKAle8LV0JDESvOd6pyO+C4SCk cN1VlwhIueglUhsIQiBS64Jpqj084kHEMu87wigaeK9rgeu4ZrNFgrJxQ3xo0L77wE6Z ZStg== X-Forwarded-Encrypted: i=1; AJvYcCXT6ALnwTFQt3b3a3jVKZvpByhwseIGz8oOlatuCnfHYrhlCMKta+KkyOQbESelW0fjb0AyAO0ntdvCTN8=@vger.kernel.org X-Gm-Message-State: AOJu0YxnReAjZ4QnK/Lhh22cukAQmnzEyUIgz1P3aYuzdPk4125ayhLS H32FwHNk6PaU+K0h3yt7TLFAHZD9K3qssp1QyfngmItbCZ5hGPa6ReEZct40TzdcuY8= X-Gm-Gg: AY/fxX79TDTsDZZoNCN6G31xnrMdsXGeguhYk0j01e+PfQZSSgucztyFbww8ymlOQIU xO4xrOayaQLilmtI5aJdlGvwrDwX4otESpd8pqdOulDxs5vnPZV28LEBGZ12gJbIxzzSiGHC9dq ksF1EpSkbSWW1X641jueIzGstUDCC0YS/2T0zmi3jARcx+1ViHEy9ADK1+rJ/4abgrO0cqPz+Mo d9/wFwv47kuNfvmgyxaru9+N65wXyK/mjAxu9dkx0aieNe0GQbSfFWkh5VtLHDd7D401k3wS6Qj pBJkiyrmT/JP5SDJOYPHekdH6a+8jVIgSlOCQ3FRMr1HiTvSjda868GRJzdfnjBaPavhvra25v+ R+nrdkJZHW6RRJnxPPW5l19jAXEmeebH8nme7gpJyJl1dhxZWTB0KPzi6TxZ7UbrEYfIFuljNAh W+nbzKUWayvqlMEw6srrYljQe8UgiePCbfOyAjQJwW/Uk96cqwK3kdx+4mOgm7HPA= X-Google-Smtp-Source: AGHT+IFCikJ03J/WgyrsSQPwxIM5AkWewsU7YWY0NL1QPgGkyLNv66hXXYzshWOTAsB92VRUvv8j1A== X-Received: by 2002:a5d:5f94:0:b0:432:5bac:3915 with SMTP id ffacd0b85a97d-432c37c87e4mr11007824f8f.39.1767953607247; Fri, 09 Jan 2026 02:13:27 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d283:7a7e:4c57:678d? ([2a01:e0a:3d9:2080:d283:7a7e:4c57:678d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e175csm21370007f8f.14.2026.01.09.02.13.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 02:13:26 -0800 (PST) Message-ID: Date: Fri, 9 Jan 2026 11:13:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/6] drm/meson/dw-hdmi: convert to of_drm_find_and_get_bridge() To: Luca Ceresoli , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm Cc: Marek Szyprowski , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20260109-drm-bridge-alloc-getput-drm_of_find_bridge-3-v2-0-8d7a3dbacdf4@bootlin.com> <20260109-drm-bridge-alloc-getput-drm_of_find_bridge-3-v2-2-8d7a3dbacdf4@bootlin.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260109-drm-bridge-alloc-getput-drm_of_find_bridge-3-v2-2-8d7a3dbacdf4@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/9/26 11:02, Luca Ceresoli wrote: > of_drm_find_bridge() is deprecated. Move to its replacement > of_drm_find_and_get_bridge() which gets a bridge reference, and ensure it > is put when done. > > dw_hdmi->bridge is used only in dw_hdmi_top_thread_irq(), so in order to > avoid potential use-after-free ensure the irq is freed before putting the > dw_hdmi->bridge reference. > > Acked-by: Maxime Ripard > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index 0d7c68b29dff..fef1702acb14 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -778,7 +778,7 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > if (IS_ERR(meson_dw_hdmi->hdmi)) > return PTR_ERR(meson_dw_hdmi->hdmi); > > - meson_dw_hdmi->bridge = of_drm_find_bridge(pdev->dev.of_node); > + meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(pdev->dev.of_node); > > DRM_DEBUG_DRIVER("HDMI controller initialized\n"); > > @@ -789,8 +789,12 @@ static void meson_dw_hdmi_unbind(struct device *dev, struct device *master, > void *data) > { > struct meson_dw_hdmi *meson_dw_hdmi = dev_get_drvdata(dev); > + struct platform_device *pdev = to_platform_device(dev); > + int irq = platform_get_irq(pdev, 0); > > + devm_free_irq(dev, irq, meson_dw_hdmi); > dw_hdmi_unbind(meson_dw_hdmi->hdmi); > + drm_bridge_put(meson_dw_hdmi->bridge); > } > > static const struct component_ops meson_dw_hdmi_ops = { > Acked-by: Neil Armstrong Thanks, Neil