From: Hans de Goede <hdegoede@redhat.com>
To: Maximilian Luz <luzmaximilian@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andy@infradead.org>
Cc: linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5.4 regression fix] Input: soc_button_array - partial revert of support for newer surface devices
Date: Sat, 5 Oct 2019 22:14:51 +0200 [thread overview]
Message-ID: <ef31abf6-b3f2-f3aa-1536-3ecd5fc819e1@redhat.com> (raw)
In-Reply-To: <65b265d2-f7a8-bcd7-e63f-f8efb7349324@gmail.com>
Hi,
On 05-10-2019 17:01, Maximilian Luz wrote:
> Hi, again
>
> On 10/5/19 3:20 PM, Hans de Goede wrote:
>> Ok, on x86 the GPIO drivers really should all be builtin because
>> various ACPI methods including device D0 / D3 (power-on/off) methods
>> may depend on them. So normally this should never happen.
>>
>> If this (-EPROBE_DEFER on surface devices) somehow still is happening
>> please let me know and we will figure something out.
>
> I have never personally experienced this, only received reports which
> indicated this and that the change (as well as manually reloading
> soc_button_array) fixed it. I will come back to you if I hear anything
> in regards to this again.
>
> I have now also tested your patch on the Surface Book 2. Does not cause
> any issues as far as I can tell.
>
> Tested-by: Maximilian Luz <luzmaximilian@gmail.com>
>
> And if that is needed/wanted
>
> Acked-by: Maximilian Luz <luzmaximilian@gmail.com>
Great, thank you.
Regards,
Hans
next prev parent reply other threads:[~2019-10-05 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 10:55 Hans de Goede
2019-10-05 12:17 ` Maximilian Luz
2019-10-05 13:20 ` Hans de Goede
2019-10-05 13:33 ` Maximilian Luz
2019-10-05 15:01 ` Maximilian Luz
2019-10-05 20:14 ` Hans de Goede [this message]
2019-10-05 12:27 ` Yauhen Kharuzhy
2019-10-08 23:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef31abf6-b3f2-f3aa-1536-3ecd5fc819e1@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®