From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9853C19F2A for ; Thu, 11 Aug 2022 22:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236384AbiHKWIi (ORCPT ); Thu, 11 Aug 2022 18:08:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbiHKWIg (ORCPT ); Thu, 11 Aug 2022 18:08:36 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 674CEA0262; Thu, 11 Aug 2022 15:08:35 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C8C215C006A; Thu, 11 Aug 2022 18:08:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 11 Aug 2022 18:08:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1660255714; x= 1660342114; bh=8ZCDjbDiatX8L4toFofmUz+eVA1AbAXz/oRWIKvDcSo=; b=G isUhB/wN1ioUV+Ag+wZaIMzQUEoJh5uuW07ezA4iHDfaVs3xkzdGlK/ZwjjtEdHP k2286GAOwybQaVszqFrXG5vvSY2awa/zhIYMCfxRt75f5ZhSUv+lQLkzOxPXtkmA Ld/q5f3ZEmtujnGCfGCbbmim9zTHWwoz3d4KlDzqWYpZ7zHNDyfYwhFgippLhtto KvDXSqz/Wh1z/zLktc2Ypm9LjX4IWv9GsgtKXueFssf2NPo1yNxqX++WAurm2ffT Q9SOHe5x/VfHg5m6pVXmkUW3qkWCRQ4eTqT65X/OFbEJDNZn0GU8a4rnKnJDjTOP bc/xTV0gXM0/4G2G/AM8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1660255714; x= 1660342114; bh=8ZCDjbDiatX8L4toFofmUz+eVA1AbAXz/oRWIKvDcSo=; b=r 1yp9+b11KeIx+50+UEMu2jx/k+Q8BluB2l55aVCVoeSvxhsPN7NZqpIkhAAHdzVP 5Vsyw5VJVnlS1KbXsZA/KEbDLXCWpf9zlRT0ciWCcCK/HgRWbnTzmg2AgGx646q3 UEreodsPxldzb8inVCel6kuTkovlrT/eiC0Akvo6aV+b0yTdvJkLxeWYJHQTJgBD MKfslJNMtYxSf6FnjpXsTo0GWBdzTzy+wxQs/mroeF9p0nOHrQjbRynAytsf21RE 7d6dPylElT56nBL4Y1rfn3d5ei6YbdvWfWb20/n3NhALT3aKP1ZSXuoiQAYLdalh 9BxXZH5G5Oqmd5Tcu2aiQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeghedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkffuhffvveffjghftgfgfgggsehtqhertddtreejnecuhfhrohhmpefnuhhk vgculfhonhgvshcuoehluhhkvgeslhhjohhnvghsrdguvghvqeenucggtffrrghtthgvrh hnpeekfeffueejveeujeeugeelleehtdegvdeludektddtfffhieefledvudehfeejieen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehluhhkvg eslhhjohhnvghsrdguvghv X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Aug 2022 18:08:32 -0400 (EDT) Message-ID: Subject: Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes From: Luke Jones To: Hans de Goede , Andy Shevchenko Cc: =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Pavel Machek , Platform Driver , Linux Kernel Mailing List Date: Fri, 12 Aug 2022 10:08:25 +1200 In-Reply-To: References: <20220809025054.1626339-1-luke@ljones.dev> <20220809025054.1626339-5-luke@ljones.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (by Flathub.org) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, 2022-08-11 at 17:08 +0200, Hans de Goede wrote: > Hi, >=20 > On 8/9/22 11:25, Andy Shevchenko wrote: > > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones > > wrote: > > >=20 > > > Documents some previously added attributes: > > > - dgpu_disable > > > - egpu_enable > > > - panel_od > >=20 > > Try to find a commit that introduced thouse and add the respective > > Fixes tag. > >=20 > > ... > >=20 > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * keyboa= rd - 0 or 1, unknown what effect > > > this really has > > > \ No newline at end of file > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * keyboa= rd - 0 or 1, unknown what effect > > > this really has > >=20 > > Should be part of another patch. >=20 > Ack to both remarks. >=20 > Luke please make this patch one of the first patches in your next > version / patch-series and then add the doucmentation of the new > kbd RGB backlight attributes in the patches where you are also > adding those actual attributes. Yep, done. Everything is looking much cleaner too.