From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D250C3A589 for ; Tue, 20 Aug 2019 17:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D95A82064A for ; Tue, 20 Aug 2019 17:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730501AbfHTR1z (ORCPT ); Tue, 20 Aug 2019 13:27:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:46154 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725983AbfHTR1y (ORCPT ); Tue, 20 Aug 2019 13:27:54 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1272AABBE; Tue, 20 Aug 2019 17:27:53 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 03/11] of/fdt: add of_fdt_machine_is_compatible function From: Nicolas Saenz Julienne To: Rob Herring Cc: "open list:GENERIC INCLUDE/ASM HEADER FILES" , devicetree@vger.kernel.org, "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , Florian Fainelli , Andrew Morton , Frank Rowand , Eric Anholt , Marc Zyngier , Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , linux-mm@kvack.org, Linux IOMMU , Matthias Brugger , Stefan Wahren , linux-riscv@lists.infradead.org, Marek Szyprowski , Robin Murphy , Christoph Hellwig , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , phill@raspberryi.org Date: Tue, 20 Aug 2019 19:27:50 +0200 In-Reply-To: References: <20190820145821.27214-1-nsaenzjulienne@suse.de> <20190820145821.27214-4-nsaenzjulienne@suse.de> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-Cm+dM0aB2YImXVa0ovlW" User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-Cm+dM0aB2YImXVa0ovlW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Rob, thanks for the rewiew. On Tue, 2019-08-20 at 12:16 -0500, Rob Herring wrote: > On Tue, Aug 20, 2019 at 9:58 AM Nicolas Saenz Julienne > wrote: > > Provides the same functionality as of_machine_is_compatible. > >=20 > > Signed-off-by: Nicolas Saenz Julienne > > --- > >=20 > > Changes in v2: None > >=20 > > drivers/of/fdt.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > >=20 > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > > index 9cdf14b9aaab..06ffbd39d9af 100644 > > --- a/drivers/of/fdt.c > > +++ b/drivers/of/fdt.c > > @@ -802,6 +802,13 @@ const char * __init of_flat_dt_get_machine_name(vo= id) > > return name; > > } > >=20 > > +static const int __init of_fdt_machine_is_compatible(char *name) >=20 > No point in const return (though name could possibly be const), and > the return could be bool instead. Sorry, I completely missed that const, shouldn't have been there to begin w= ith. I'll add a const to the name argument and return a bool on the next version= . Regards, Nicolas --=-Cm+dM0aB2YImXVa0ovlW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl1cLZYACgkQlfZmHno8 x/4DowgAjoLUq0qUOWOtkTx0OcxyQrKy++gIvChR7IajK1yXJKyT8kA/QNZrERqj nvLlebXPhJG0y4uUTzEVmzsgUFS4vopZAzL+H7TGfXsL8pQbGjnO+l62gc1oqTVd U+IrQWs0BPZ/MeCxUXUtKlYdMMuf9Ld8z16siDZPj5pYY6IHq8HtS1WseTvTti6S pHpXyK+XiPpxzupgUjNm6Lzsm8FO0P2tw5IKD3vRLS+4vLaYUPieCLdMvkf1lMU6 DkQ71pEENpt35eBer1lLK/meYuisvK4V+tnwrWSDGZCuywbhi1fpvAyh3CRicE3t rvLGmR2JEXsldgQeodOoEyKoeWSAgQ== =hgaN -----END PGP SIGNATURE----- --=-Cm+dM0aB2YImXVa0ovlW--