From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753756AbdHKUnE (ORCPT ); Fri, 11 Aug 2017 16:43:04 -0400 Received: from mout.web.de ([212.227.15.14]:52496 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753295AbdHKUnD (ORCPT ); Fri, 11 Aug 2017 16:43:03 -0400 Subject: [PATCH 2/3] ASoC: blackfin: Use common error handling code in sport_create() From: SF Markus Elfring To: adi-buildroot-devel@lists.sourceforge.net, alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , Mark Brown , Scott Jiang , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Fri, 11 Aug 2017 22:42:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:NBPr3iYEyiZFtkVoutjvu/NrqYNKrTk04jHun/q+cIY7IWO/zjk fQ6Yk92vFR0OasY0yP2rbLQbPZYI9Qw79mA3/kXQ4QS675N/pz3YT103NYf3tKyssSbJhyx KFUWSqx7CG+THc5g8Yt5/ag8t4Ptw2Eya2sb7TIW5hH1MaU9TegVN68a4bSmHWB5Bgry+4/ k/oiwsizwLIgoAr8cKeqg== X-UI-Out-Filterresults: notjunk:1;V01:K0:mzu02/q6cMY=:64L04k84lRbPcyexkBdfmY cA4e2lrDKbJbdxdzwURn7CBSHsY+TqL1O1kRhg/aEjvU85FPwpErRbpIfSfggUT9YzyD0jFHG CS/cOLrVRRJzfWR5q2BwIiUsokurdTi14xggpojknhLvxbS+0/XWi/oYbBr2D9LjUG5OM19bf 8vudFNRrjEacDu1nuIUAyccYu479WQnpIE/bH6JPdD/k8r/KiTV/hisYcLlI4g4WFLyvneOR4 o4DN2ek9CalxAwO0eqmulsJQ5wtm/v44EgRn/SkByorLkCG9XuhVVOlol5K+GVaXkJH5NzF3v 1dPb9KkfWmhzVKwYSduB9BQrP/O4kNV44AbP63T6Yy9/+4P9vhmbOZjjsMUGOVAYf66mZ3h7c 5BbcJ1+T9Jzi7uBOuyXvUKcZ4DDObmJ0DEEzBPWLilSaBp1ptTIb8MUyWSlPGR7IX+CJXOAHU Ggm4bYvt6pbMx47apmmJFdjVuTbf0V/nAybP1sUGZALTyUTnmhcdNsbStTjFQydU2Yl5Shk12 C8jA/RkZxeZ+ttp2PeEZirgWjzDUEfN7+RM5QT3RGLlD/M0uG23ijy7Djux6ORFdtt7mq2E7l uyS9tYsJS6xXxyxGfGaZLM0lSQzV2kasWgvlmb/hnjbBvqWykH9iHPuIC68eDoSZ/Exdo2Bub /3bWBYj/451kLerKWH/teZY7YV/2vbBfOQeoxcCvwhxRhFL6nxjUy2MXmxFD4NkArEkQuLdck sYmAeY2DUOqav6nm3XeX0C1qh3OwgaV7s+cVXNcDfz5ZFesQ8t2CaU0+mgL8RcoLlYJ33ER0c HmM2slcHHX8Nck7CkrB+oFsALF8IIg1DMtMDTmW3akDBrWAg2E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 11 Aug 2017 22:02:47 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- sound/soc/blackfin/bf6xx-sport.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/blackfin/bf6xx-sport.c b/sound/soc/blackfin/bf6xx-sport.c index 1bc3e0a47a57..fcddebf2558c 100644 --- a/sound/soc/blackfin/bf6xx-sport.c +++ b/sound/soc/blackfin/bf6xx-sport.c @@ -394,19 +394,18 @@ struct sport_device *sport_create(struct platform_device *pdev) sport->pdev = pdev; ret = sport_get_resource(sport); - if (ret) { - kfree(sport); - return NULL; - } + if (ret) + goto free_data; ret = sport_request_resource(sport); - if (ret) { - kfree(sport); - return NULL; - } + if (ret) + goto free_data; dev_dbg(dev, "SPORT create success\n"); return sport; +free_data: + kfree(sport); + return NULL; } EXPORT_SYMBOL(sport_create); -- 2.14.0