From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1494331215 for ; Tue, 7 Apr 2026 11:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775561437; cv=none; b=mptqvosYnFwWdHQYhVB1GA+kbVwbVPwOxH4tTekUAjVRyRr6W1bCJz2EibM4/WdqYy2Pwe7qMCrL34hx0ApTYqwmsmVmqBcEhyULpUGSpjeAk6UJom/O7/ezLEMLgpJBb/IyLQQI0yyX2iZd/N0n0IPbo9SCbfRv1QBNWAnAJ1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775561437; c=relaxed/simple; bh=J97/LFHCSQwl41vcjradM9y1LhUgRNkjOziSeuheST8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DzMafUP/Aa1qeyvwYE0s1L2pbzLN7rh7hiFNh/o0fy1o4RlDC95ezzmnl622o8O1W08bGa2lWUA7AejuWknz5vd9M/9ffP8kzdqQBWSFNJjcw3GHj8yJ6o3j2dCnf/zwJjWXqIG2MdfGTYOdPwPrsh2Tl4X0/nk0sPjaccgxhhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kvSDZqzw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aijfO+gk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kvSDZqzw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aijfO+gk" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637645cM2009327 for ; Tue, 7 Apr 2026 11:30:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UVTjeMJAl4HC/zZnM//c72iDIv2/Ko4Z2oQzHGrzYXE=; b=kvSDZqzw7yoxGeGa gwLkIstspUFxxrVI7/RW4xXRibH7b0vdhRddhVU55JP6BRfG1KTH4SP7MPmT4Cv4 NVIYowNqnJFH94GLXwAOfQ0bdW64JOCqia4OZEqkHM9I82X2sngHw7Do7ouYiVpw Kd7m0w6IDlqm4smY5omoxDJOhVpFNYMn9htqH9F4i5j93nY7ADGg1N3Pv5mvuEck 7Luhp7atPB/VR2blA+gngL1T93Sx3EZUAUByBqMACIZFzgD5XIuxYYkNC2Rnd2nG UH6OffedkQ1BU7YP8JM2N4I7j8rVgUIJQ8MVNol5kthIU4SUB8KotXOomyzBAAK7 TMbB2g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmrrtgag-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 11:30:35 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50d5d1c2289so113536511cf.2 for ; Tue, 07 Apr 2026 04:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775561435; x=1776166235; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=UVTjeMJAl4HC/zZnM//c72iDIv2/Ko4Z2oQzHGrzYXE=; b=aijfO+gk65PC1HJbK9Nj0ekdC0EldweH/iOQPDzhVP4e4H1u6VWZRe0x17enEA6qYg N9lxNKGzBTTxRmR8C68AC9cobsJ70xQw0rgLBt5ATUF5yQMRQh8gSE8XufQlVszZJFrK 15sFfC/PcW7lEbHAHQnt070616YrsFVmYS7t+6E56SzFEGfksu4oXpXW/XMLRZ9tQh6i arCzFA5ENkBgml2NSdzBK0I4+P8gGTiYYZ/Kx6mb5gg8FpjO9DS+a9AMnzzcwF4WLDwo IJReI6wrj/hdCOcmi7t7OewgYlhjcr1INBtMh+qS2kTMkrCsZJ0/cNuvoH2LNUtHFxj5 bJOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775561435; x=1776166235; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UVTjeMJAl4HC/zZnM//c72iDIv2/Ko4Z2oQzHGrzYXE=; b=HOqL87tRWLMqF3/BuyEAu2qGYAc3P0JqyZJoPq/KbCvKmft4YLhAC0BB0B/paPKvLY I2ABDzz0B50CxUTBNVF773xan4Psr6np4l2FsrmCZqgwhZTiQ9y4DO8CMcBZO+W92yl5 LAWcgBJG0OKTT8zlXA1POjKZsSBFb/gISUPNLwUeuZSLATuReJAM49ULKg/KnIP1zGpo FW8VVHRScDQk5NWcnQgyAwRXa5bxXyVt++SneF9K3Ei0+OvB53HhIUqE/wssqakg/7OB A/DLuQlL2CWai7sBGfgiT6zNZfm7HvIrbzI4uL4WLar/xYdR2sLRh9CcWdyDRF0ZJw0o gxUw== X-Forwarded-Encrypted: i=1; AJvYcCW8/z4GIC2aUILA4kT/n3Rwtevu9Zp6MCYjQrnAonWV1J5bXWEFFix/EoOjT94PbAHUo9J6fxBP8FOdE/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9qirUtM+ZEldKVlM5SbpVeAg9f5Wa9npxfmdJyWpgHpM937rz 6C5wK8ajrAcD1j7HeENO6iFCbUyJk3VbzBveFlmJflbXZzykIYEC9EUHWscbfIggSL7ZfUTT4Ml NsefddfWgW0BImlTSOZwZFMit2v976pgFZWLHESYCr5jkoTFNHq/e1iycp/gYVa/WX9w= X-Gm-Gg: AeBDietp+5IuRGD8rCa9GSntMhazOm/zu5EWWdSIUSWzuPbX6R2k3JeRXOKiTuRhh+j bTQL/4DjBEchFF7DpnIIbXZlREKnS3XtiD1Nf+nnTbmsjsNf1xZaxwCNOXm2TInAXlcrgiC4NSn J6GrE3O3EFvdxwRXSwf457VwekFVPsxE5dUnR/rn+HKxvIKXgTkkZ60m1Iu+cTFdO/qNC74pqLT WdbgHpaIDY42+9qg5HXVsxijhfWX1ho5tmUrQMqrBYjbcamLp43pDmK4W9ozKACDeYAwgD0PmiW B7hL536MXgJ93MLp3oef/CC7T2q9ExW9E5HxOu2P8pc5y2nCRqNhEl4cH0xMq7J23fNQA1w3TkU 1ITU0ddcllA7HPbw/tCzQoo/Ljpd008R1VX1PF8zA0DJn66rX X-Received: by 2002:ac8:5dcc:0:b0:50d:714a:327a with SMTP id d75a77b69052e-50d714a37eemr207910741cf.10.1775561433208; Tue, 07 Apr 2026 04:30:33 -0700 (PDT) X-Received: by 2002:ac8:5dcc:0:b0:50d:714a:327a with SMTP id d75a77b69052e-50d714a37eemr207908351cf.10.1775561431537; Tue, 07 Apr 2026 04:30:31 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488a8ddfde7sm408468995e9.5.2026.04.07.04.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 04:30:30 -0700 (PDT) Message-ID: Date: Tue, 7 Apr 2026 13:30:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mmc: cqe: Add CQE support for cadence mmc driver To: rohan1sj@cadence.com, Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Masahiro Yamada , Adrian Hunter Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Milind Parab , Swapnil Jakhade , Manikandan Pillai References: <20260407-cdns_sdhci_cqe-support-v1-0-13efc0810631@cadence.com> <20260407-cdns_sdhci_cqe-support-v1-2-13efc0810631@cadence.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: <20260407-cdns_sdhci_cqe-support-v1-2-13efc0810631@cadence.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEwOCBTYWx0ZWRfX5O2dz+HoJB+1 V1w+cmjBWPCETph1Rn0KZQ6JJw3e53Uy9wCv+Vcq35lWbI6OCDWHRLBUJhfNPIzsrITdnqxf8sI M75lle0vAB/EQ+gSC22SWqtSliT69aShLBGWsDMXyk2r+WQaBMZNUIX1zYQgbx+LMdQYf+h9C2C sbiE/jm5/Yb1A3OhO6Vnpf1qk85zcqCdu1pb2Fyoxjfjy9lyqHWffAquVQMnrrWDzYOqtuY/myf aPFqZ2XAGHEpCo7FiaiqTun13S3CoFvU/cakcuA0riFoMwqZdm0ToUA8RR0Eh2qkKUUwNSr4sbo eXCj/g/U9Cq2rwbARwCorvlnBnf4GEYDV9lnIZkHxi5h7y+glY4qF1N7NId3klOxgnk8W3Yxvdv jpUMq5Gfa7RiLUGQBksHSYPJTNtMGP+h+A8dDBhV3ct72P71JGFlaoJ2APsjvoHTS9mrH5qFydX 4veAOWuSbUNyPtLtxmQ== X-Proofpoint-GUID: Uj_J7Hx62x6hjxePVUIoiR1lCAS6QdQh X-Proofpoint-ORIG-GUID: Uj_J7Hx62x6hjxePVUIoiR1lCAS6QdQh X-Authority-Analysis: v=2.4 cv=LquiDHdc c=1 sm=1 tr=0 ts=69d4eadb cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=P-IC7800AAAA:8 a=cRWuF9MFhkk3AmCFUGEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070108 On 07/04/2026 13:18, rohan1sj via B4 Relay wrote: > +static int sdhci_cdns_cqe_add_host(struct sdhci_host *host, struct platform_device *pdev) > +{ > + struct cqhci_host *cq_host; > + bool dma64; > + int ret; > + > + /* setup SDHCI host first */ > + ret = sdhci_setup_host(host); > + > + if (ret) > + return ret; > + > + /* Init CQE */ > + cq_host = cqhci_pltfm_init(pdev); > + if (IS_ERR(cq_host)) { > + ret = PTR_ERR(cq_host); > + goto cleanup; > + } > + > + dma64 = host->flags & SDHCI_USE_64_BIT_DMA; > + if (dma64) > + cq_host->caps |= CQHCI_TASK_DESC_SZ_128; > + > + cq_host->ops = &sdhci_cdns_cqhci_ops; > + > + host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD; > + > + /* Finally initialize CQHCI */ > + ret = cqhci_init(cq_host, host->mmc, dma64); > + if (ret) { > + dev_err(mmc_dev(host->mmc), "Failed to initialize CQHCI: %d\n", ret); So here error msg > + goto cleanup; > + } > + > + /* add host to MMC subsystem */ > + ret = __sdhci_add_host(host); > + if (ret) > + goto cleanup; > + > + dev_info(mmc_dev(host->mmc), "CQE init: success\n"); dev_dbg This does not look like useful printk message. Drivers should be silent on success: https://elixir.bootlin.com/linux/v6.15-rc7/source/Documentation/process/coding-style.rst#L913 https://elixir.bootlin.com/linux/v6.15-rc7/source/Documentation/process/debugging/driver_development_debugging_guide.rst#L79 > + return 0; > + > +cleanup: > + dev_err(mmc_dev(host->mmc), "CQE init: failed for %s\n", mmc_hostname(host->mmc)); And here also error message. Why twice? And if it is probe path, why aren't you using dev_err_probe()? Best regards, Krzysztof