From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756136AbdJPRzN (ORCPT ); Mon, 16 Oct 2017 13:55:13 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:47584 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754478AbdJPRzK (ORCPT ); Mon, 16 Oct 2017 13:55:10 -0400 X-Google-Smtp-Source: ABhQp+Q/0v/em3uCiY5CuI7lscaheZnOWY7tHaktmemrqu8XK82cFlMZWKpKCqzA27E2E4e+y86ruw== Subject: Re: [PATCH] [net-next] net: systemport: add NET_DSA dependency To: Arnd Bergmann Cc: "David S. Miller" , Michael Chan , Sathya Perla , Nicolas Pitre , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171016113258.3735473-1-arnd@arndb.de> From: Florian Fainelli Message-ID: Date: Mon, 16 Oct 2017 10:55:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171016113258.3735473-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2017 04:32 AM, Arnd Bergmann wrote: > The notifier cause a link error when NET_DSA is a loadable > module: > > drivers/net/ethernet/broadcom/bcmsysport.o: In function `bcm_sysport_remove': > bcmsysport.c:(.text+0x1582): undefined reference to `unregister_dsa_notifier' > drivers/net/ethernet/broadcom/bcmsysport.o: In function `bcm_sysport_probe': > bcmsysport.c:(.text+0x278d): undefined reference to `register_dsa_notifier' > > This adds a dependency that forces the systemport driver to be > a loadable module as well when that happens, but otherwise > allows it to be built normally when DSA is either built-in or > completely disabled. > > Fixes: d156576362c0 ("net: systemport: Establish lower/upper queue mapping") > Signed-off-by: Arnd Bergmann Reviewed-by: Florian Fainelli Thanks Arnd. -- Florian