From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbeBSNh4 (ORCPT ); Mon, 19 Feb 2018 08:37:56 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38868 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666AbeBSNhz (ORCPT ); Mon, 19 Feb 2018 08:37:55 -0500 Subject: Re: [PATCH] s390/console: enable dummy console for vt To: Farhan Ali , Thomas Huth , Geert Uytterhoeven Cc: Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , Linux Fbdev development list , linux-s390 , Stefan Kristiansson , Tomi Valkeinen , Martin Schwidefsky , DRI Development , Chen Liqin , Lennox Wu , Jeff Dike , Richard Weinberger , uml-devel References: <2324e2cc-ff55-4d57-2807-c7f72f9ea0ca@de.ibm.com> <20180215111423.96598-1-borntraeger@de.ibm.com> <4116f119-b96e-a8c1-359a-dde488d61212@de.ibm.com> From: Christian Borntraeger Date: Mon, 19 Feb 2018 14:37:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18021913-0008-0000-0000-000004D13A46 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18021913-0009-0000-0000-00001E6445D8 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-19_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802190169 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2018 02:35 PM, Farhan Ali wrote: > > > On 02/15/2018 07:02 AM, Christian Borntraeger wrote: >> >> >> On 02/15/2018 12:57 PM, Thomas Huth wrote: >>> On 15.02.2018 12:26, Geert Uytterhoeven wrote: >>>> Hi Christian, >>>> >>>> On Thu, Feb 15, 2018 at 12:14 PM, Christian Borntraeger >>>> wrote: >>>>> To enable the virtual terminal layer with virtio-gpu, we need to >>>>> provide the dummy console. This console is hidden behind CONFIG_IOMEM >>>>> via the graphics support. Instead of fully enabling the graphic >>>>> drivers lets just provide a Kconfig option for the dummy console. >>>>> >>>>> Signed-off-by: Christian Borntraeger >>>>> --- >>>>> New version: instead of moving around the graphic and console stuff, >>>>> let's just keep an s390 specific variant of CONFIG_DUMMY_CONSOLE >>>>>   arch/s390/Kconfig | 5 +++++ >>>>>   1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig >>>>> index cbe1d978693a..a69690f616f3 100644 >>>>> --- a/arch/s390/Kconfig >>>>> +++ b/arch/s390/Kconfig >>>>> @@ -952,6 +952,11 @@ config S390_HYPFS_FS >>>>> >>>>>   source "arch/s390/kvm/Kconfig" >>>>> >>>>> +config DUMMY_CONSOLE >>>>> +       bool >>>>> +       depends on VT >>>>> +       default y >>>>> + >>>>>   config S390_GUEST >>>>>          def_bool y >>>>>          prompt "s390 support for virtio devices" >>>> >>>> Really? >>>> >>>> You already have your own copy of HAS_IOMEM, which makes it hard for >>>> people to track which one applies where. >>> >>> I think I agree with Geert - let's better fix this in a proper way >>> instead of doing hacks like this. I guess there will be other >>> architectures in the future that might want to use the dummy console >>> without CONFIG_IOMEM, so fixing this in drivers/video/ instead sounds >>> better to me. >> >> The question is, what is the proper fix? >> > > How about we only fence off sub menu items such as DRM or GPU or Fbdev, which actually uses io memory, in drivers/video/Kconfig? Similar to what Thomas suggested for moving the CONFIG_IOMEM dependency for fbdevs? Can you spin a patch?