From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751667AbdJWRjp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 13:39:45 -0400
Received: from mout.web.de ([212.227.15.14]:54830 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751388AbdJWRjl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 13:39:41 -0400
Subject: Re: dmaengine: ioat: Use common error handling code in
 ioat_xor_val_self_test()
To: Vinod Koul <vinod.koul@intel.com>, Dave Jiang <dave.jiang@intel.com>,
        dmaengine@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        Arvind Yadav <arvind.yadav.cs@gmail.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Geliang Tang <geliangtang@gmail.com>,
        Krister Johansen <kjlx@templeofstupid.com>,
        Pan Bian <bianpan2016@163.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <b28f440e-6d11-d37e-e5de-e6dfd6bce2e9@users.sourceforge.net>
 <20171023072745.nh2mrwez2to6nst4@mwanda>
 <3e96d66a-de9c-5b2b-5646-84037a3935f7@intel.com>
 <20171023165617.GK936@localhost>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <ef4d8039-6d5c-5d31-515b-eda9f05faff6@users.sourceforge.net>
Date: Mon, 23 Oct 2017 19:39:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171023165617.GK936@localhost>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:zJcxgqGJ9Fl/rYpHjdHtoHQ7xoU4XrnEOuBQ3xTAjgEtJAeIDyQ
 W8R5seGiTfwP35RXzPwnGoFKMqrPX8A+rYXKfl7jiGoE2IBS0uT3M5gYheIWW/LqfoIiYgv
 R/qV5qGeVaAfmM8PPvTRFmSdWe/nOF4BCjRbkMtic3Broo9DBxZ8JJnhztWB0I7/fRVAjtf
 FP7XI9TknTEm6/pqmrT7A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Au+VKaqCWCo=:jbGxCQqCMHrQxOr2BY5QWR
 yEiLy1YZLv/KjteVJFCQnRnUYb459lE2mbU8kRpX4kqGddSxWCQGTBYB8eKyCXfJLx5pw3tXp
 QVsr4f98svwN656wUvliclQzw3EE01u7NVPa6lP+Dk+ZjfDrbuREsxkaXyURw7/1dojCgQtmH
 R0mKhRnj94TPNcJFfvsnyha5PMccYeLWXRQnj6oo7TSv/IDNed9ZmDLv3+rEsONWWxngIYpS1
 nUTICzhKYtogP946xWhYTj4rY5hZ2tRRHsUWxwZk2kC2RiaOwcSg2Zqd6mN+eYDHY79yWpczp
 VgzYPiAu/w7SftGiCDLpxezRTFjqCwgVQdk7FL11U26u1+rs1DJXOZKJ38r/YoPE6iuu1Plbs
 w4SGsnkypuJ2GmMvlOxxvXIhZDLqLOxgYiofGsMiuPD8asOXY3RP1GG6DRNa1X5YVzrjSzb92
 D5+gZ7Q0O0rlsXy+l768lpiJms3qmoAbVH/yXt+VmproQJm2rHf0rU57HM0dAFPHfhAfpynWD
 waI8COvC3bns7cc75HjM64nM2P38Lit1Cf8cCfq4z9E+458LNTw2+WMmS436m1eQHUxJ29asR
 ryxFOMei+UVCb3QY+mXf3XF3KuO+iwuDKOFMjOngPckRnxu9oO5sqkPIeRzkwVkb0qUMcFAKx
 IuFT+93Lrm7jYJE0een1P+5HsuUxIs6LLh+x65r5Borm1rIUi0airtXUVTZgZdWKdiZ4fHdxV
 prz/1ekXdRfXRlZr9d3T3heCMHYPmPf8qG+iFJMUQ0B9DzKhqdcBRlw3rFidx4wel/5BljrEI
 QWJJ0uNH9tA5Ahl8P+V+/9c9CL/kym4gfXYd50x4Z7DbSMyHGk=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> I agree with Dan. I'm ok with not accepting this patch.
> 
> And I have no intention to :)

This is a pity.


> At least they should explain why or how it help,

Do you see useful consequences (like a bit less memory requirements)
if the assignment statement “err = -ENODEV” will be stored only once
behind the jump label “failure_indication” in the suggested update
for the implementation of the function “ioat_xor_val_self_test”
(instead of being duplicated several times)?


> give the Coccinelle scripts..

How can they matter for a better understanding of the concrete
source code adjustment?


> But sadly that is not done ...

I did not include a link for special background information explicitly.
But how do you think about corresponding details from discussions
on a topic like “Comparing statement lists with SmPL”?

https://systeme.lip6.fr/pipermail/cocci/2017-August/004388.html

Regards,
Markus