From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1614EC678D5 for ; Tue, 7 Mar 2023 07:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbjCGH7D (ORCPT ); Tue, 7 Mar 2023 02:59:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjCGH7A (ORCPT ); Tue, 7 Mar 2023 02:59:00 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4E55D328 for ; Mon, 6 Mar 2023 23:58:55 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id v16so11266872wrn.0 for ; Mon, 06 Mar 2023 23:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678175934; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=JdQshwHadK10TmyUGi+IO4oTSOyXtNeO1NzLyvLX7/o=; b=HkwxPNf+tiVkKPFF0uH1B7W5Ln/8j+HEsd8iKXyC4RD/377WMWxe56M0Pcm80EltvD BEOfv3OsizBjRzVfzGbs21+j+q6d2E9X/del/0572CNBjMSe7arpF9++/PJpm3KxN/21 T0+tgr/U2lKTfQpODmlmyuwCm6lE5eZ+TLmWgn6mSR9RekC02tur80JD1q9CPrs7wywB aINIK/ZJyOUtM+igtlVZ3JOBqmxSICbG+xtwYulVIQxXOdZLeldiczydfL1kBt4mibUM 35y8/kjmyjSQaI+v8rGD/P7b3IW0vRSGSsTBqglcIw796nBQJbEsaihq7YcwF+rDKmBK 1SYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678175934; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JdQshwHadK10TmyUGi+IO4oTSOyXtNeO1NzLyvLX7/o=; b=kNGxSFENsfXNtkcsnPCIO3P6DughP4LNe2H4iF9M5BqVOtBsTfxTp8I0D1QmOeVewa Eo2ujrJHf6Yp5087FHajUnl1qcdLTV9TyYkXJtnpCF8APnBHe0bdFSQ2hzEp08cr1VdD 1JLT8jDpOs/TuO5RTNFIT6gFJB0M2aMDj2pHBZPCT/JVfsX8ObcFIiTdSgncTefzofSl r1ElkxrcgV1iGpWXv7l401iPVoZvaDeRyvg2mN/I5t30DEbqXhcDC0XrK8F2AZrYcL1g I5R/eQV7S6+jT5HhrCBV/DbqMwK1em3vvEeHXhHUJIgDsP5qg3SIPPoGH/JUVOkC7fCY wTlg== X-Gm-Message-State: AO0yUKVyvXCGAJnyJ5q+wWfT55hfkApy9AqyhFZprXE/Q1SwzPxBZhbB lwh9B3XwGAZIPJv2pGWyGsvGnw== X-Google-Smtp-Source: AK7set+vkYi1NjFrFf/LVhqK8+JRWiJ85O5XnmwZEXRqNBqZ8jCna39sM0MO1QyYct729rWgCSzp8Q== X-Received: by 2002:adf:ec09:0:b0:2c7:e48:8c87 with SMTP id x9-20020adfec09000000b002c70e488c87mr10613238wrn.25.1678175934284; Mon, 06 Mar 2023 23:58:54 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:6faa:6d13:586e:871d? ([2a01:e0a:982:cbb0:6faa:6d13:586e:871d]) by smtp.gmail.com with ESMTPSA id z9-20020adfec89000000b002425be3c9e2sm11913168wrn.60.2023.03.06.23.58.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 23:58:53 -0800 (PST) Message-ID: Date: Tue, 7 Mar 2023 08:58:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/2] arm64: dts: amlogic: Add initial support for BPI-CM4 module with BPI-CM4IO baseboard Content-Language: en-US To: Martin Blumenstingl Cc: Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Christian Hewitt References: <20230303-topic-amlogic-upstream-bpi-cm4-v2-0-2ecfde76fc4d@linaro.org> <20230303-topic-amlogic-upstream-bpi-cm4-v2-2-2ecfde76fc4d@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2023 23:11, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, Mar 6, 2023 at 9:31 AM Neil Armstrong wrote: >> >> Add support for both the BananaPi BPI-CM4 module and the BananaPi >> baseboard which is comnpatible with the RaspberryPi CM4IO baseboard. > s/comnpatible/compatible/ > >> >> The BananaPi BPI-CM4 module follows the CM4 specifications at [1], >> but with a single HDMI port and a since DSI output. > s/since/single/ > >> >> The current CM4IO baseboard DT should work fine on the Raspberry CM4 >> baseboard and other derivatives baseboards, but proper DT should >> be written for other baseboards. >> >> The split is done so it's easy to describe a new CM4 baseboard, enabling >> only the necessary HW used on the baseboard. >> >> [1] https://datasheets.raspberrypi.com/cm4io/cm4io-datasheet.pdf >> >> Tested-by: Christian Hewitt >> Signed-off-by: Neil Armstrong > With the typos above fixed: I'll fix those while applying > Reviewed-by: Martin Blumenstingl > > [...] >> +&ext_mdio { >> + external_phy: ethernet-phy@0 { >> + /* Realtek RTL8211F (0x001cc916) */ >> + reg = <0>; >> + max-speed = <1000>; >> + >> + interrupt-parent = <&gpio_intc>; >> + /* MAC_INTR on GPIOZ_14 */ >> + interrupts = <26 IRQ_TYPE_LEVEL_LOW>; > It would be great to have the reset GPIO (GPIOZ_15) described as well. > But this can be done in a follow-up patch. I'll send a follow-up > > > Best regards, > Martin Thanks ! Neil