From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5DBEB1B29C for ; Tue, 19 Dec 2023 14:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 179AC1FB; Tue, 19 Dec 2023 06:28:38 -0800 (PST) Received: from [10.57.85.119] (unknown [10.57.85.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D88D63F5A1; Tue, 19 Dec 2023 06:27:52 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2023 14:27:52 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dma-debug: make dma_debug_add_bus take a const pointer Content-Language: en-GB To: Greg Kroah-Hartman , hch@lst.de, m.szyprowski@samsung.com Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev References: <2023121941-dejected-nugget-681e@gregkh> From: Robin Murphy In-Reply-To: <2023121941-dejected-nugget-681e@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-12-19 1:41 pm, Greg Kroah-Hartman wrote: > The driver core now can handle a const struct bus_type pointer, and the > dma_debug_add_bus() call just passes on the pointer give to it to the > driver core, so make this pointer const as well to allow everyone to use > read-only struct bus_type pointers going forward. Reviewed-by: Robin Murphy > Cc: Christoph Hellwig > Cc: Marek Szyprowski > Cc: Robin Murphy > Cc: iommu@lists.linux.dev > Signed-off-by: Greg Kroah-Hartman > --- > include/linux/dma-map-ops.h | 4 ++-- > kernel/dma/debug.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/dma-map-ops.h b/include/linux/dma-map-ops.h > index f2fc203fb8a1..e401f824a007 100644 > --- a/include/linux/dma-map-ops.h > +++ b/include/linux/dma-map-ops.h > @@ -443,10 +443,10 @@ static inline void arch_teardown_dma_ops(struct device *dev) > #endif /* CONFIG_ARCH_HAS_TEARDOWN_DMA_OPS */ > > #ifdef CONFIG_DMA_API_DEBUG > -void dma_debug_add_bus(struct bus_type *bus); > +void dma_debug_add_bus(const struct bus_type *bus); > void debug_dma_dump_mappings(struct device *dev); > #else > -static inline void dma_debug_add_bus(struct bus_type *bus) > +static inline void dma_debug_add_bus(const struct bus_type *bus) > { > } > static inline void debug_dma_dump_mappings(struct device *dev) > diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c > index 3de494375b7b..1a5c86dd87d5 100644 > --- a/kernel/dma/debug.c > +++ b/kernel/dma/debug.c > @@ -876,7 +876,7 @@ static int dma_debug_device_change(struct notifier_block *nb, unsigned long acti > return 0; > } > > -void dma_debug_add_bus(struct bus_type *bus) > +void dma_debug_add_bus(const struct bus_type *bus) > { > struct notifier_block *nb; >