From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2D0C7EE29 for ; Fri, 9 Jun 2023 13:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238846AbjFINI7 (ORCPT ); Fri, 9 Jun 2023 09:08:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231377AbjFINI4 (ORCPT ); Fri, 9 Jun 2023 09:08:56 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB49430C1 for ; Fri, 9 Jun 2023 06:08:55 -0700 (PDT) Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id AF6D76606F22; Fri, 9 Jun 2023 14:08:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686316134; bh=0QHEEmERs5KT10qCKQxRCKpKm54QjTiueVsH9AJrKB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LfCcK/8Sl5ct0QVN8gjBplH83VDF0OcfXd83X4W9O853eIVGvELrztFdPIij1EIxb u1OogdQuoSqiIrqvxo+yDlkVHa4WpcbHfceUizk4MYIw6XNlzNGzCW5UYXN11EbNMu JK6kqdXVZ2Te8EGvMNW8KWgaUSoCBAvd9qRONuDOzadG3TqOpCrGY8HljFTNLr/A4Q UdPajj1BEwlBdl04dobfIhgUP/Xb+PD1mMp0IB+PAGWyH9Ngh3TUqsfr2F/CZkhYKH hCdpB7xNzU/K8C/WKgTnuMmLFQMqaeN2q/1TWJx3bPKSASC3OWwYUvFnqoMVnQUzJw ILWm7DxfEFyFw== Date: Fri, 9 Jun 2023 09:08:47 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Mark Brown Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , Jaroslav Kysela , Liam Girdwood , Matthias Brugger , Takashi Iwai , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] Revert "ASoC: mediatek: mt8192-mt6359: Remove " Jack" from Headphone pin name" Message-ID: References: <20230608221050.217968-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09, 2023 at 10:39:25AM +0100, Mark Brown wrote: > On Thu, Jun 08, 2023 at 06:10:48PM -0400, Nícolas F. R. A. Prado wrote: > > This reverts commit cbbc0ec6dea09c815f1d1ef0abaf3f2ec89ff11f. That > > commit removed the " Jack" suffix with the reasoning that it is > > automatically added to the name of the kcontrol created, which is true, > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. > > Please include human readable descriptions of things like commits and > issues being discussed in e-mail in your mails, this makes them much > easier for humans to read especially when they have no internet access. > I do frequently catch up on my mail on flights or while otherwise > travelling so this is even more pressing for me than just being about > making things a bit easier to read. Hi Mark, just for my own reference in the future, what exactly should have been done differently in this commit? Are the subject line and commit reference in the message generated by 'git revert' no good? Or is this message from a bot that can't handle revert commits? Thanks, Nícolas