From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9555AC433EF for ; Thu, 14 Apr 2022 09:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241808AbiDNJdp (ORCPT ); Thu, 14 Apr 2022 05:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241817AbiDNJdk (ORCPT ); Thu, 14 Apr 2022 05:33:40 -0400 Received: from mail.meizu.com (edge05.meizu.com [157.122.146.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C3A670062; Thu, 14 Apr 2022 02:31:13 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 14 Apr 2022 17:31:12 +0800 Received: from [172.16.137.70] (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 14 Apr 2022 17:31:11 +0800 Message-ID: Date: Thu, 14 Apr 2022 17:31:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg' To: Sergey Shtylyov , Geert Uytterhoeven , Michael Turquette , Stephen Boyd CC: , , References: <1649837953-10984-1-git-send-email-baihaowen@meizu.com> <2ed01eb3-ff46-425c-75dc-81729a5c30a8@omp.ru> From: baihaowen In-Reply-To: <2ed01eb3-ff46-425c-75dc-81729a5c30a8@omp.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 4/14/22 5:29 PM, Sergey Shtylyov 写道: > Hello! > > On 4/13/22 11:19 AM, Haowen Bai wrote: > >> Fix this issue by freeing the cpg when exiting the function in the >> error/normal path. >> >> Signed-off-by: Haowen Bai >> --- >> V1->V2: free both cpg&clks. >> >> drivers/clk/renesas/clk-r8a73a4.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > 2 patches with the same name won't do -- you always need to include the chip name > part of the file name in the subject (in this case r8a73a4). > > MBR, Sergey Got it, thank you for your kindly reminder. -- Haowen Bai