From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF96F2E2DF2 for ; Thu, 23 Jul 2026 23:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784847668; cv=none; b=kVTDr507p1uAgS8hT6A9e4cjkU3muYOFAKU3R/GMOFpA/joYmSFoCVIMTAhriGBBBF+r4sBirT8PXC7UBsFuUA9RcCW8ZyMLbnNJaBcM8ev1I6BhxfApyoks6m5vK5/l5uSRYfnvnej9JJ9IFGH03WAyHUHYsK72dkuVCYkHl8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784847668; c=relaxed/simple; bh=tlBke9Zy/uEyVeFWT0u7I8al9pXAl3RJEyIr2Crpk00=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VlJXeKMYzaVsa29aZcMboMPlIXWc+QZwRpdAzr9tmc8FIuCOX0FEJ9/JL5Tf/TcC+E+PBzFmaEX6fx2qc4pcnHcLe50eAeCcLMBc5GakUrrXCSHhKPyltLs2ikYu46/cEEPRgRdGxQNcrGgPshrvaC056rZs1SZEiF9vIBVOEZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WdmT37Hf; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WdmT37Hf" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c99eaa1f020so1047860a12.2 for ; Thu, 23 Jul 2026 16:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784847666; x=1785452466; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=BT0tASgzzLFfHsQzTBG0WttYe9VxvxNAcJeWo1DWkME=; b=WdmT37HfVTDqw2hbcjawBt+Cq8m+FzZltIxWOeRed7i+LhX7qxTKS8+QdeHKxvnmaF fmoNFMCR6ca7z701GfLOX4RNaGaOA6TZX3u3WQCA8xXu4YO2T1S9lW/hxmzfiqxahGsF Qs8LtE0FVrqo+2i1f5+bogvBWjEhzRK8T2VtqeH/HjcMJrf9DZj6Rn3gxScOfD1gk5NA XJgOFiM/V7g8ltlKiEmK3m59QJNc/hwnbELYWvi7/9NwECErPfBU7hwIqa2FX4X4LIpJ ixqe+R6oVA87EI/kU6kclt25YfaSFrNL7DYX5fFBWfhRabEFlVF+K/23IBw4VfzHs+9D gi6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784847666; x=1785452466; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BT0tASgzzLFfHsQzTBG0WttYe9VxvxNAcJeWo1DWkME=; b=Slx7AdBBr4jxET5krYybTrHpjKbkTZuy26AwshTrVbqZJYqQXVzpJUG0Cs/EYykI0P gSa96B9R+T/1hGLrCUIIsXntdTAgxgS33OezkVrmQjZpvbfF75fTcBWF1j1MoBPBvTA1 EcNe00ZzhEZbsYLX3zHx9IYWXvNB/L1KawtqOZ2zLid5bAz479wF6pIxcG0d+rbhyDkM 33K63UMmVN0Dumt8hVuCYti+QvA/goPi8mHJpEARqTTyMQw8ATJcMR23MqJGUscM52Lj A0j/U+6SIuzQ3Le/xO33cQOGhx5sB7qcLSBTal9j3s8yXU6si1SrYJQJiWCRPvqeaY7f rYvg== X-Forwarded-Encrypted: i=1; AHgh+RrZijVzfyDIqZdeSZx3xS4Pbe3B88Oi/Kl9ImxWDLMLSlzK1fqlo373Ut8naU/LOjsHqCnMfZ0OuyJwLK0=@vger.kernel.org X-Gm-Message-State: AOJu0YxKXWxvU+HZ9JtpAKmFafKMOtUFJd8RiFK9RkOhFYB3b5SFTgUA sJfBah5OPHKZzLBET3GlSNT/TZfOBrPDSI/6w1oh7XYH3tCv2g3gbhO3 X-Gm-Gg: AR+sD12eewL0EQEnY+Nh95ZP4uKbj1Jx72EmFs8Mje1EJqBFQSHA4sJ0rA1fQHMUb84 WFHnMJdN4mNvADFff9jEAadC1/e7HKfrcladsfEUtVD2OqnfjQcJ/lt4QYcl6HhqBOku37QeBi0 Xq1XUdpna0cMwWTJRr6Dak5Fr+9+j+C8EXTFy7EmyX2Mmr7uj+SAutkbFWN81vasBg1Rm7/c2Xw QJelwdOWcJagWfaraK11S/oP3CwqWcExGXIqR9h+yIbcug16yl8ZqaLyHKZGAIk3r0ScXhUXvMZ BUKHrGzUjxMGOSe28L0NbZWJ2JQA5B39QI4Uaj5eCR6x9i5EwQSdlh5fyxEH7FtVOiqwUus+adq PBoNH+qt91ri1jMe9M/9PPMqTaq5ibWbJCrXzATlFf/rbmUJCw0CqsoFClaz2G+QxzFKXK5VbjC C3Ox4Bh2Z1oNrFi2g= X-Received: by 2002:a05:6a21:6197:b0:3bf:6c08:2844 with SMTP id adf61e73a8af0-3c44b1ea25dmr5324085637.51.1784847665999; Thu, 23 Jul 2026 16:01:05 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d1302659fsm20045490c88.8.2026.07.23.16.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 16:01:04 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 23 Jul 2026 16:01:03 -0700 From: Guenter Roeck To: kr494167@gmail.com Cc: wim@linux-watchdog.org, cl634@andestech.com, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] watchdog: atcwdt200: fix return value when watchdog is enabled Message-ID: References: <20260723022634.8642-1-kr494167@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723022634.8642-1-kr494167@gmail.com> On Thu, Jul 23, 2026 at 07:56:34AM +0530, kr494167@gmail.com wrote: > From: Surendra Singh Chouhan > > atcwdt_get_int_timer_type() returned TMR_UNKNOWN (enum value 3) when > CTRL_WDT_EN was set in the control register. > > Because atcwdt_probe() checks "ret = atcwdt_get_int_timer_type(drv_data); > if (ret) return ret;", returning TMR_UNKNOWN caused probe() to return 3 > instead of a valid negative error code. > > Fix this by returning -EBUSY via dev_err_probe() when the watchdog is > already enabled and update the kernel-doc description accordingly. > > Fixes: e4e0848ad046 ("watchdog: atcwdt200: Add driver for Andes ATCWDT200") > Signed-off-by: Surendra Singh Chouhan Applied. Next time please provide a change log. Guenter