From: Laura Abbott <labbott@redhat.com>
To: Chen Feng <puck.chen@hisilicon.com>,
sumit.semwal@linaro.org, gregkh@linuxfoundation.org,
arve@android.com, riandrews@android.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: suzhuangluan@hisilicon.com, dan.zhao@hisilicon.com,
oliver.fu@hisilicon.com, qijiwen@hisilicon.com,
saberlily.xia@hisilicon.com, xuyiping@hisilicon.com,
puck.chen@foxmail.com
Subject: Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags
Date: Mon, 8 Aug 2016 11:44:09 -0700 [thread overview]
Message-ID: <ef638f17-4a5d-ceab-a6b6-d8317aa595af@redhat.com> (raw)
In-Reply-To: <1469844551-68688-1-git-send-email-puck.chen@hisilicon.com>
On 07/29/2016 07:09 PM, Chen Feng wrote:
> It's useful to show the current memory in detail when alloc failed.
>
> And, there may be a lot of high order alloc failed, just show memory
> when an order 0 alloc failed.
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
> drivers/staging/android/ion/ion_system_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index b69dfc7..c3b7975 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -28,7 +28,7 @@
>
> static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN |
> __GFP_NORETRY) & ~__GFP_RECLAIM;
> -static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN);
> +static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO);
> static const unsigned int orders[] = {8, 4, 0};
> static const int num_orders = ARRAY_SIZE(orders);
> static int order_to_index(unsigned int order)
>
Acked-by: Laura Abbott <labbott@redhat.com>
prev parent reply other threads:[~2016-08-08 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 2:09 Chen Feng
2016-08-08 18:44 ` Laura Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef638f17-4a5d-ceab-a6b6-d8317aa595af@redhat.com \
--to=labbott@redhat.com \
--cc=arve@android.com \
--cc=dan.zhao@hisilicon.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.fu@hisilicon.com \
--cc=puck.chen@foxmail.com \
--cc=puck.chen@hisilicon.com \
--cc=qijiwen@hisilicon.com \
--cc=riandrews@android.com \
--cc=saberlily.xia@hisilicon.com \
--cc=sumit.semwal@linaro.org \
--cc=suzhuangluan@hisilicon.com \
--cc=xuyiping@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®