From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbdAYNsW (ORCPT ); Wed, 25 Jan 2017 08:48:22 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56883 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbdAYNsT (ORCPT ); Wed, 25 Jan 2017 08:48:19 -0500 X-AuditID: cbfec7ef-f79d26d00000420c-15-5888aca12ca2 Subject: Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports To: Krzysztof Kozlowski , Anand Moon , Richard Genoud , =?UTF-8?Q?Bart=c5=82omiej_=c5=bbo=c5=82nierkiewicz?= Cc: Felipe Balbi , Huang Rui , Javier Martinez Canillas , Heikki Krogerus , Kukjin Kim , devicetree , Linux USB Mailing List , "linux-samsung-soc@vger.kernel.org" , Linux Kernel From: Marek Szyprowski Message-id: Date: Wed, 25 Jan 2017 14:48:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOKsWRmVeSWpSXmKPExsWy7djPc7oL13REGHRuV7TYOGM9q8Wxtifs FvOPnGO16Fq9k8Xizds1TBb9j18zW5w/v4Hd4vKuOWwWM87vY7JYtKyV2WLdxlvsFr1P+pgs Zu9cw+TA69F66S+bx85Zd9k9Nq3qZPOYdzLQY0s/kNe3ZRWjx+dNcgHsUVw2Kak5mWWpRfp2 CVwZfcc72AveyFY8+nicvYHxvXgXIyeHhICJxP8Zq5kgbDGJC/fWs3UxcnEICSxjlHhy9zg7 hPOZUeLf7Q1MMB0fDmxhgqvafvo2C0hCSOA5o8SxbwIgtrCAtcSL7u9gRSIC5xklLrw9CTaK WWAZs8TBJ22MIFVsAoYSXW+7gBZycPAK2ElMWxUNEmYRUJVYsPUu2DZRgRiJhlM/2UFsXgFB iR+T77GAlHMKBEt0nLQGCTMLWEk8+9fKCmHLS2xe85YZZJWEwEt2ib7pi8DGSwjISmw6wAzx gIvEolXXWCBsYYlXx7ewQ9gyEp0dB6Ge7GeUaGrVhrBnMEqce8sLYVtLHD5+EWoXn8SkbdOZ IcbzSnS0CUGUeEjMvA4LK0eJY8/bWCBhNZ9J4t6f7+wTGOVnIflmFpIXZiF5YQEj8ypGkdTS 4tz01GJDveLE3OLSvHS95PzcTYzA5HT63/H3OxifNoccYhTgYFTi4X2R0h4hxJpYVlyZe4hR goNZSYRXfGVHhBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHevQuuhAsJpCeWpGanphakFsFkmTg4 pRoYzfVz75rXB3WoRc3OXfpsypw8buk5xVphkQc7sx+vdiqMsn1h+5WhRbm5+Zng+Q0aV5mf 3S3Zd9nXfJmYdrUvU59c3momoVbND8nf+5+6xhZN6hHefvLxGf8JDG8UylqNt3bN9XTZ6bZh wZrvn4o9TnSsnLuul+najDuL82tWnioq53fPMs5VYinOSDTUYi4qTgQAM6GdmUoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFIsWRmVeSWpSXmKPExsVy+t/xK7p313REGKyZo2uxccZ6VotjbU/Y LeYfOcdq0bV6J4vFm7drmCz6H79mtjh/fgO7xeVdc9gsZpzfx2SxaFkrs8W6jbfYLXqf9DFZ zN65hsmB16P10l82j52z7rJ7bFrVyeYx72Sgx5Z+IK9vyypGj8+b5ALYo9xsMlITU1KLFFLz kvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CW0Xe8g73g jWzFo4/H2RsY34t3MXJySAiYSHw4sIUJwhaTuHBvPVsXIxeHkMASRonNP28zQjjPGSV2373L BlIlLGAt8aL7OxNIQkTgLKPE+bPn2CGq5jNJXO6ZywriMAssY5b4ffM3M0gLm4ChRNfbLqB2 Dg5eATuJaauiQcIsAqoSC7beBdstKhAj8Xb9cnYQm1dAUOLH5HssIDanQLDE2Y3LGEFsZgEz iS8vD7NC2PISm9e8ZZ7AKDALScssJGWzkJQtYGRexSiSWlqcm55bbKhXnJhbXJqXrpecn7uJ ERiv24793LyD8dLG4EOMAhyMSjy8E5LaI4RYE8uKK3MPMUpwMCuJ8Iqv7IgQ4k1JrKxKLcqP LyrNSS0+xGgK9MREZinR5HxgKskriTc0MTS3NDQytrAwNzJSEuct+XAlXEggPbEkNTs1tSC1 CKaPiYNTqoFx0r1m59/tUqrxKeJF3op60XFb598MVD/6Sfquov5Gthd/nsd/F88JKji9fvqM xXt3bugNlHXYm86q9Fg3weK649Z3a91XH9fc/Ndtet9vfV2ru1O8WFqWnFRc8Gd766eWqcl7 bqVZPAk+t2u7klhLafH9A/bOsasN01PFX3MoZDPd7bqZwTpFiaU4I9FQi7moOBEAszyF6u0C AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170125134814eucas1p2e09e70fde3373cf41a95b3a3b9ac4cad X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170125075556epcas1p4b916a6d6acda28f8fc1959a1227520fa X-RootMTR: 20170125075556epcas1p4b916a6d6acda28f8fc1959a1227520fa References: <20170124134809.23315-1-richard.genoud@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2017-01-25 08:55, Krzysztof Kozlowski wrote: > On Wed, Jan 25, 2017 at 7:51 AM, Anand Moon wrote: >> On 24 January 2017 at 19:18, Richard Genoud wrote: >>> Since commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores"), >>> the USB ports on odroid-XU4 don't work anymore. >>> >>> Inserting an usb key (USB2.0) on the USB3.0 port result in: >>> [ 64.488264] xhci-hcd xhci-hcd.2.auto: Port resume took longer than 20000 msec, port status = 0xc400fe3 >>> [ 74.568156] xhci-hcd xhci-hcd.2.auto: xHCI host not responding to stop endpoint command. >>> [ 74.574806] xhci-hcd xhci-hcd.2.auto: Assuming host is dying, halting host. >>> [ 74.601970] xhci-hcd xhci-hcd.2.auto: HC died; cleaning up >>> [ 74.606276] usb 3-1: USB disconnect, device number 2 >>> [ 74.613565] usb 4-1: USB disconnect, device number 2 >>> [ 74.621208] usb usb3-port1: couldn't allocate usb_device >>> NB: it's not related to USB2.0 devices, I get the same result with an USB3.0 device (SATA to USB3 for instance). >>> NB2: it doesn't happen on an odriod-XU3 board, that doesn't have the realtek RTL8153 chip. >>> >>> If the lines: >>> if (dwc->revision > DWC3_REVISION_194A) >>> reg |= DWC3_GUSB3PIPECTL_SUSPHY; >>> are commented out, the USB3.0 start working. >>> >>> For a full analyse: https://lkml.org/lkml/2017/1/18/678 >>> >>> Felipe suggested that suspend should be disabled temporarily while >>> what's wrong with DCW3 is figured out. >>> >>> Tested on Odroid XU4 >>> >>> Suggested-by: Felipe Balbi >>> Tested-by: Richard Genoud >>> Signed-off-by: Richard Genoud >>> Cc: stable@vger.kernel.org # 4.4+ >>> Fixes: 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores") >>> --- >>> arch/arm/boot/dts/exynos5422-odroidxu4.dts | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts >>> index 2faf88627a48..f62dbd9b5ad3 100644 >>> --- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts >>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts >>> @@ -43,6 +43,15 @@ >>> status = "okay"; >>> }; >>> >>> +&usbdrd_dwc3_0 { >>> + /* >>> + * without that, usb devices are not recognized when >>> + * they are plugged. >>> + * cf: https://lkml.org/lkml/2017/1/18/678 >>> + */ >>> + snps,dis_u3_susphy_quirk; >>> +}; >>> + >>> &usbdrd_dwc3_1 { >>> dr_mode = "host"; >>> }; >>> -- >> Thanks for this patch. >> But could you consider moving this changes as below. >> >> https://lkml.org/lkml/2015/3/18/400 > The patch above (and other DTS patches from the set) was not even sent > to linux-samsung-soc nor to me... It is sad how easily one's work can > disappear. Also, it is really worthless to solve the same problem > twice. Well, they were sent about 2 years ago... and you were also working on this topic. ;) > Cc Marek and Bartlomiej, > Guys, do you want to continue with Robert's patch (linked above by > Anand)? If yes, please take the ownership (Robert's address is not > valid anymore). If not, I will take Richard's patch after > resubmission. Take Richard's patch because it has a bit more details describing why such quirk is needed. Richard: in Roberts patch there is also a quirk for USB 2.0 mode (snps,dis_u2_susphy_quirk). Could you check if it really needed? Maybe it would make sense to set those quirks for both DWC3 controllers, as this issue with PHY suspend seems to be a Exynos specific thing. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland