From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4051B3AB273 for ; Tue, 17 Mar 2026 15:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773760126; cv=none; b=DcHh7OiSCbjyJvpthHuvbALm1gtdMf9wFiToHui0LoqKrw4CYKWSaDTZos2UDkXTVmzuO2DxZF3mSoBzm8iE8LuO/rSLXHzpG/z290oA03u3atG8QVsy1uc2UAS6LNg1LDXQ1SSs7NMDdjXDMtN/pxJvcvQ2RGpIrefrkDqR5wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773760126; c=relaxed/simple; bh=Mr8nFOMXA5ElV7SfPAaspq7Qh87bB2g0Z7bO4Atcjpg=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=XFrYf5H0E+VaQnBH+Oba9KNmFD34pt+dRMC/agaxpH9NRWz4s44tZ7unLNPEoJdqP/+YQRS0OINHDO6Mi/0ewEM1Ut6w5d1rJogJFzZTchM+SXbNudBjL/6GW/SZCX9SHNLzPEBtehHacFV5wqfDa2g/OFhD907EFiuvRWaGPos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XO4i6R2U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XO4i6R2U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C81D6C19424; Tue, 17 Mar 2026 15:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773760126; bh=Mr8nFOMXA5ElV7SfPAaspq7Qh87bB2g0Z7bO4Atcjpg=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=XO4i6R2UlygzDSxeSGU/XndQrZ9yTF1jwhcMd+O+UVdGInzgfui5F4itxIV+lSRR5 y/LK+JA4f97h5CULBsqEq//fzHkIwZFvzPGLm4RrXXejElLpp0xvsinlR1+Ku2utXb Y5E4a9y+fW0ZVTLoq2lmy/YaGTXkQzm/TOfNVXfkg43GLncP20G1J4HkSqQ3cS0FMn 3LLA/suwIoItvNT1EiJ8zp14YlBpPRpq28AFi99O5nOUaNH5CMfvBDRaJJI1Hr+y63 kpFH7GCEWCU+c9x+10obm/xC85grVZPmI066Fi7Xp0ddOx4qDl85Y3pFw8K5lz0xj4 Pv3ywfPJSiFpg== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id D2968F40071; Tue, 17 Mar 2026 11:08:44 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-01.internal (MEProxy); Tue, 17 Mar 2026 11:08:44 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdduheejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrugcu uehivghshhgvuhhvvghlfdcuoegrrhgusgeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpedvueehiedtvedtleekuddutefgffdtleetfeetveejveejieehfefhjeei jeefudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhguodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieejtdehtddtjeel qdeffedvudeigeduhedqrghruggspeepkhgvrhhnvghlrdhorhhgseifohhrkhhofhgrrh gurdgtohhmpdhnsggprhgtphhtthhopeelpdhmohguvgepshhmthhpohhuthdprhgtphht thhopegtrghtrghlihhnrdhmrghrihhnrghssegrrhhmrdgtohhmpdhrtghpthhtohephh gvrhgsvghrthesghhonhguohhrrdgrphgrnhgrrdhorhhgrdgruhdprhgtphhtthhopehh tghhsehinhhfrhgruggvrggurdhorhhgpdhrtghpthhtohepvggsihhgghgvrhhssehkvg hrnhgvlhdrohhrghdprhgtphhtthhopeifihhllheskhgvrhhnvghlrdhorhhgpdhrtghp thhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrg gurdhorhhgpdhrtghpthhtoheplhhinhhugidqtghrhihpthhosehvghgvrhdrkhgvrhhn vghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrh hnvghlrdhorhhgpdhrtghpthhtohepjhgrshhonhesiiigvdgtgedrtghomh X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id AD9CD700065; Tue, 17 Mar 2026 11:08:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: A0MGIhlQvLYV Date: Tue, 17 Mar 2026 16:08:24 +0100 From: "Ard Biesheuvel" To: "Christoph Hellwig" Cc: "Eric Biggers" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, "Jason A . Donenfeld" , "Herbert Xu" , linux-arm-kernel@lists.infradead.org, "Catalin Marinas" , "Will Deacon" Message-Id: In-Reply-To: References: <20260314175049.26931-1-ebiggers@kernel.org> <38a37b02-602a-42a4-8974-b8a6cd750c3e@app.fastmail.com> Subject: Re: [PATCH] lib/crypto: arm64: Drop checks for CONFIG_KERNEL_MODE_NEON Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, 17 Mar 2026, at 15:45, Christoph Hellwig wrote: > On Tue, Mar 17, 2026 at 12:09:34PM +0100, Ard Biesheuvel wrote: >> Acked-by: Ard Biesheuvel >> >> Actually, we should just get rid of CONFIG_KERNEL_MODE_NEON entirely on arm64, although there is some code shared with ARM that would still need some checks. But anything that is arm64-only should never look at this at all. > > I'll also drop it from the XOR series. > Ack - mind cc'ing me on the next revision? > Talking about which (sorry for highjacking this thread), arm32 and arm64 > have completely different neon XOR implementations, where arm32 uses > #pragma GCC optimize "tree-vectorize" or clang auto-vectorization of > the generic C implementation, and arm64 uses intrinsics. Is there any > chance those could share a single implementation? If we're migrating the XOR arch code to live under lib (if that is what you are proposing), I think we could tweak the arm64 implementation to make it build for ARM too, with the caveat that the 3-input EOR3 instruction does not exist there.