From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from va-2-45.ptr.blmpb.com (va-2-45.ptr.blmpb.com [209.127.231.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0337B2FD7D3 for ; Fri, 9 Oct 2026 03:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.127.231.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791518365; cv=none; b=C2VlwbxatNPm60LDLcBECQVjnYBwrQFtejkAkk3m8C+Q8FWL91ffMsE+iiihH/eKQDpWe0783Dcy+WsQHZrT3NHfd+dmu3hKardwF6hDK+oRlOpVnmUmn+91xLSpGwMytos8l/wgmXTMm/FdEgJQe8NHBmHnTfzqHNoX3USn3yU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791518365; c=relaxed/simple; bh=S3YX/IofUpGzMaHVjbZ3i/7v3orPrOdkbg+atX82QFM=; h=To:From:Subject:Message-Id:Cc:Date:Mime-Version:In-Reply-To: References:Content-Type; b=jeKJHentVic8UWyRT2GKam+tRyJumsqTnVCZ3rkknH8iWCd+9ONRYbjbiNqPSz8uHzy3dSoZ9phFUipfpDEE8tPdTW16BJOH7wvpgWIJW5V7jm5BkmNMuH6PIIyBbfjT9QSB1rwbrEiXEqli8cAFnTDIuc7bjw4LGxzH2YOtuyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fygo.io; spf=pass smtp.mailfrom=fygo.io; dkim=pass (2048-bit key) header.d=fygo-io.20200929.dkim.larksuite.com header.i=@fygo-io.20200929.dkim.larksuite.com header.b=JiMSmTTs; arc=none smtp.client-ip=209.127.231.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fygo.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fygo.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fygo-io.20200929.dkim.larksuite.com header.i=@fygo-io.20200929.dkim.larksuite.com header.b="JiMSmTTs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fygo-io.20200929.dkim.larksuite.com; t=1791518337; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=9ioF2CxfmybnWpl7CBEF+vseKEEUSR0omAyejznNhFM=; b=JiMSmTTsiLz4bKcLryrud0k5yHd0SBd6BN5HdJLAVuu1J1YGfJt3UwtP9LuCc3T1rsUM6n RDWw/VutWjmTb84UJHGEcXLQthsC6deD68S0A/6S+0b6LKiMcS1xlqzShTf/4YCGVGnh1B g4D2rCQ/tYRFb5PnFceJBzFmFdeRmyoUgtQh0CO2TMKuPThoA0r+MvR9pshD8IpwqIRJmD EZGCq/gr8pdrfyet7wXZFEVjFn0FXDJNDHYOwIjwViUeyXMYd3hXhYCSyhEf5ergGncLDL a18+wMBEF1A2C7LBqNqgM6oAy0/DBsMIS0N5N2GlfEFF5XYQaPE0s+yAcM/SmQ== To: "Yogesh Gaur" , "Song Liu" , "yu kuai" From: "yu kuai" Subject: Re: [PATCH v2] md: don't hand out the array before md_alloc() has added mddev->kobj Message-Id: X-Lms-Return-Path: Cc: , , "Li Nan" , "Xiao Ni" , "Christoph Hellwig" , "Hannes Reinecke" , "Logan Gunthorpe" , , Date: Fri, 9 Oct 2026 11:58:52 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Original-From: yu kuai In-Reply-To: <20261006122904.1538-1-yogeshgaur.83@gmail.com> Received: from [192.168.1.104] ([39.182.0.35]) by smtp.larksuite.com with ESMTPS; Fri, 09 Oct 2026 03:58:56 +0000 Content-Transfer-Encoding: quoted-printable References: <20261004055712.1293-1-yogeshgaur.83@gmail.com/> <20261006122904.1538-1-yogeshgaur.83@gmail.com> Reply-To: yukuai@fygo.io User-Agent: Mozilla Thunderbird Content-Type: text/plain; charset=UTF-8 Hi, =E5=9C=A8 2026/10/6 20:29, Yogesh Gaur =E5=86=99=E9=81=93: > md_alloc() publishes the gendisk before it is done setting the mddev up: > > disk->private_data =3D mddev; > ... > error =3D add_disk(disk); > if (error) > goto out_put_disk; > > kobject_init(&mddev->kobj, &md_ktype); > error =3D kobject_add(&mddev->kobj, &disk_to_dev(disk)->kobj, "%s", "md"= ); > > add_disk() makes /dev/mdN openable. mddev comes from mddev_alloc() and > is zeroed, so anything that gets in between add_disk() and kobject_add() > sees an mddev->kobj that has never been through kobject_init() - no > ktype, no kref, state_initialized clear. > > syzbot opens the array in that window and issues ADD_NEW_DISK: > > kobject: '(null)' (ffff8880120640f0): is not initialized, yet kobject_= get() is being called. > WARNING: lib/kobject.c:642 at kobject_add_internal+0xea/0xcd0 lib/kobj= ect.c:225 > kobject_add_varg lib/kobject.c:374 [inline] > kobject_add+0x163/0x240 lib/kobject.c:426 > bind_rdev_to_array+0x80c/0xdd0 drivers/md/md.c:2621 > md_add_new_disk+0xe3b/0x1850 drivers/md/md.c:7684 > md_ioctl+0x200a/0x2610 drivers/md/md.c:8499 > > bind_rdev_to_array() is not the only way in. md_run() calls > sysfs_create_group(&mddev->kobj, &md_redundancy_group), and > internal_create_group() has its own WARN_ON(!kobj->sd), so RUN_ARRAY in > the same window warns too. > > Every ioctl that can reach mddev->kobj runs under reconfig_mutex, so > hold it across add_disk() and kobject_add(). An ioctl issued in the > window now waits for md_alloc() to finish instead of seeing a > half-built mddev, and opening the array still succeeds. The ioctls > md_ioctl() serves without the mutex only read array state and return > -ENODEV on an array with no disks. > > Hoisting kobject_init() above add_disk() is not an option: commit > ca39f7502425 ("md: fix mddev->kobj lifetime") moved it below add_disk() > so that md_alloc()'s error paths, which free the mddev directly, never > see an initialised kobject. > > Fixes: ca39f7502425 ("md: fix mddev->kobj lifetime") > Reported-by: syzbot+95eeb4ada2349a2170ea@syzkaller.appspotmail.com Reported-by should always follow with a link to the report, and the followi= ng tag and applied: Closes: https://lore.kernel.org/all/6aaf3284.514bccd6.255447.0003.GAE@googl= e.com/ > Suggested-by: Yu Kuai > Cc: stable@vger.kernel.org > Assisted-by: LLM > Signed-off-by: Yogesh Gaur > --- > v2: Hold reconfig_mutex across add_disk() and kobject_add() instead of > refusing the open in md_open(), per Yu Kuai's review: v1 made an > open that raced with md_alloc() fail. > v1: https://lore.kernel.org/all/20261004055712.1293-1-yogeshgaur.83@gmail= .com/ > > Built with W=3D1 only, fix has not been runtime-tested. > > drivers/md/md.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index 67108c397c5a..85439f27d943 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -5906,12 +5906,22 @@ struct mddev *md_alloc(dev_t dev, char *name) > =20 > disk->events |=3D DISK_EVENT_MEDIA_CHANGE; > mddev->gendisk =3D disk; > + > + /* > + * add_disk() makes the array openable before mddev->kobj exists. > + * Hold reconfig_mutex until kobject_add() is done so that ioctls > + * issued in between wait instead of using an uninitialised kobj. > + */ > + mddev_lock_nointr(mddev); > error =3D add_disk(disk); > - if (error) > + if (error) { > + mddev_unlock(mddev); > goto out_put_disk; > + } > =20 > kobject_init(&mddev->kobj, &md_ktype); > error =3D kobject_add(&mddev->kobj, &disk_to_dev(disk)->kobj, "%s", "m= d"); > + mddev_unlock(mddev); > if (error) { > /* > * The disk is already live at this point. Clear the hold flag --=20 Thanks, Kuai