From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C712E1A5BB0 for ; Tue, 1 Apr 2025 15:59:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743523194; cv=none; b=s8/fKBOpLICK8r9kpc8E24Caxh3mSmhv+B+jTLQCJjnMz7X+PIxiTwzp0U3N03G3woNmTOC969tMB5aIOZn7hk6HH4BGv0CXNX6l+l+GkX+koh+8qovYSQUovkRan6cVzoDAwvh1iUCFL0GU/HaeapINAytmAWwsCGRIeIxPnX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743523194; c=relaxed/simple; bh=s5G+D4Y4H48hG+JqN8iTc8KNENEqqJ+iDJISsHqOWj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JDL0fsYmSwFhoGj6uuHsH9VkTDF3TwTsOqVHW0qi6lLRCZTN2K+qX4sa8hUCGnGNocDKT6ytlgkueLX3j6W+/vJUMqgMtECINPon8iI4X9i/UE929bybTdQQqusKUHOXnEWiHQUs1WEMdE5tYRyV6bqeGXU5ZchjzA/3yq7i508= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y2BzDNkD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y2BzDNkD" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 531CoEfd024775 for ; Tue, 1 Apr 2025 15:59:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iVsiqH8BYsZ0fSUtLECQBLTo683Jv0XmjiQt/jiR8+c=; b=Y2BzDNkDrnHvj5Sr 5ZWeCx9WABWv4Pdu5vqPYZLVVEhtJauoKguZa5ZJU7XOInjoKTXavRe7TxhcoBJS /wePpE3vtGLO1UeY+iIiTMyO2OVFcGbULvwCm+J18qwvYD++S/Nd/Q0EoLeAIOGK CsCvTNo27wxOna5HIw2ouVsFoiymWSo4PZPBErZYULJqGZuzNC6t8FactF4CoI6G a2garVXJhEVdelujTVZurNj7etbHTgDzA5dmnClJd0zlLiiL5tOPKeY6fZPlQFlW xuXsqP4UnZbnAQ558EVMhp0dsWWhuXNNzun9UIT0Ggg3yr++fsfqP7/fbOpy3q/a 3Mi/Iw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45p86krmmx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Apr 2025 15:59:50 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6e19bfc2025so11800126d6.1 for ; Tue, 01 Apr 2025 08:59:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743523190; x=1744127990; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iVsiqH8BYsZ0fSUtLECQBLTo683Jv0XmjiQt/jiR8+c=; b=F+6T7eOQJHsEewJgmlTNGCDehs5ExAVrBsYo4scwUbggDXvn+BVd3Oo6g7Q17OHlV9 COXDRo/Tw9f+iguIcHd98u9iAPmxl+AevEgq6Uqaj4W/opeonmYoIZti3VpkIOUm+r5E 99dbjtqMoXrSBPMLaHkuwq9bRBrfaVMDjRB2i7ABmSaf3eemSv12srKiAA3RUir0NeWg UIEaDmZs9PU5f5kVpGzDtcL06Cr6WaQbdnf6uikA+9r78T7MTmXzlNNf+kQuC54L6OoT bcy7nbarWf0MbM2ch2BaF/Pi8AFOePZcYrmWlB+hP6ygpoZv7tWQU6wXBttzAhpY05ui uF6g== X-Forwarded-Encrypted: i=1; AJvYcCVA0P3LexIP6hNAL+Ik3yzFgNsb6sOr4YEGMVuCZzCosLsFfCqxWxfW8uh8IRhFStrEgYDsK27VM9GmOCg=@vger.kernel.org X-Gm-Message-State: AOJu0YyRHo2DWUUEz5pZ7HkyjFHnCjMGnn80IP+cR0PZfAAbhseY2BSh kaBseVOJB2MnnCKEg/34NCuDeQLFjcoGCm8yqXSAwXdzPzksfzRXcSehBdUQ0UCigCypr0UkxJZ w72UiJ9kHqsmWX0Gz6bPEpam/RLxS8v/cmyitsruiR7a1dW+upu1WGKi6a0612S4= X-Gm-Gg: ASbGnct0eXjzHoDDqw4wJB0POC6mrYf7WiopJFovbPfpHoNGC6PekiNd12bVU3z2So1 NgijFSuWW/HKpRur8RmGBIY5ZzkgpG1hOUtI85sO2xF8qJL7oJVSJi1FhUPreV3bT78UMg1m2EW 3qi4xTjP5OfjFDr3Z2F6kWFbmVDGxRCNaVf350E8/HuG2vtH4EtU87BTaZ7jFYFllMDCv7nLNLV LdZU1hhtzVmYUUVJ7DPwq8OX39xDd6gVR1JBPbCuS1Ky1xvao9EUr6iIsle8m9TOyP7jjJMptFG 2Aij4y+IZUD1FRKJWmNPD74u4z4HnVVkeNHAg4fVLmyu3w9LYzrvbXmUDbgH8VtQwGriQQ== X-Received: by 2002:a05:6214:27ca:b0:6e8:f589:ee3c with SMTP id 6a1803df08f44-6eed5fdc4f8mr68482426d6.4.1743523189634; Tue, 01 Apr 2025 08:59:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcj6DyVh3s44alBnkASPCCH0lLtilsnzjnLJjgoTmTdUdo3LYZcKFQUcOnrnyfNVz01bfZug== X-Received: by 2002:a05:6214:27ca:b0:6e8:f589:ee3c with SMTP id 6a1803df08f44-6eed5fdc4f8mr68482156d6.4.1743523189250; Tue, 01 Apr 2025 08:59:49 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5edc16ed61esm7201988a12.34.2025.04.01.08.59.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 08:59:48 -0700 (PDT) Message-ID: Date: Tue, 1 Apr 2025 17:59:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 6/6] arm64: dts: qcom: Add support for X1-based Asus Zenbook A14 To: Aleksandrs Vinarskis , Bjorn Andersson , Krzysztof Kozlowski , Dmitry Baryshkov , Konrad Dybcio , Greg Kroah-Hartman , Abel Vesa , Johan Hovold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus References: <20250331215720.19692-1-alex.vinarskis@gmail.com> <20250331215720.19692-7-alex.vinarskis@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250331215720.19692-7-alex.vinarskis@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=W8g4VQWk c=1 sm=1 tr=0 ts=67ec0d76 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=pGLkceISAAAA:8 a=E544tAf0YMCSjjrfBEcA:9 a=QEXdDO2ut3YA:10 a=RVmHIydaz68A:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: cKVRtDB2xIEgQz7DKo_PpbfzPjA6MK7i X-Proofpoint-ORIG-GUID: cKVRtDB2xIEgQz7DKo_PpbfzPjA6MK7i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_06,2025-04-01_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 clxscore=1015 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504010098 On 3/31/25 11:53 PM, Aleksandrs Vinarskis wrote: > Initial support for Asus Zenbook A14. Particular moddel exists > in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA). > > Mostly similar to other X1-based laptops. Notable differences are: > * Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA > and Qualcomm FastConnect 7800 on UX3407RA > * USB Type-C retimers are Parade PS8833, appear to behave identical > to Parade PS8830 > * gpio90 is TZ protected [...] > + leds { > + compatible = "gpio-leds"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&cam_indicator_en>; property-n property-names please, we're trying to unify such small things even though we know it's "wrong" in a lot of places > + > +&i2c0 { > + clock-frequency = <400000>; > + status = "okay"; > + > + /* ELAN, 04F3:3315 */ > + touchpad@15 { > + compatible = "hid-over-i2c"; > + reg = <0x15>; > + > + hid-descr-addr = <0x1>; > + interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>; > + > + pinctrl-0 = <&tpad_default>; > + pinctrl-names = "default"; > + > + wakeup-source; > + }; > +}; > + > +&i2c3 { > + clock-frequency = <400000>; > + status = "okay"; It's also customary to leave a newline before 'status' > +&pm8550_gpios { > + rtmr0_default: rtmr0-reset-n-active-state { > + pins = "gpio10"; > + function = "normal"; > + power-source = <1>; /* 1.8V */ Drop the 1.8v comments please [...] > +&spi10 { > + status = "disabled"; > + > + /* Unknown device */ > +}; Does the device crash if you enable this bus? Keeping it 'okay' would make it easier for folks to poke at it > + > +&tlmm { > + gpio-reserved-ranges = <44 4>, /* SPI11, TZ Protected */ > + <90 1>; /* Unknown, TZ Protected */ > + > + bt_en_default: bt-en-sleep { > + pins = "gpio116"; > + function = "gpio"; > + output-low; > + bias-disable; > + qcom,drive-strength = <16>; drop "qcom," and please keep the order of: pins function drive-strength bias output/input as you did below > + > +/ { > + model = "ASUS Zenbook A14 UX3407RA"; There's no strict policy, but variants usually go in braces > + compatible = "asus,x1e80100-zenbook-a14", "qcom,x1e80100"; > +}; > + > +&gpu_zap_shader { > + firmware-name = "qcom/x1e80100/ASUSTeK/zenbook-a14/qcdxkmsuc8380.mbn"; > +}; > + > +&remoteproc_adsp { > + firmware-name = "qcom/x1e80100/ASUSTeK/zenbook-a14/qcadsp8380.mbn", > + "qcom/x1e80100/ASUSTeK/zenbook-a14/adsp_dtbs.elf"; > + > + status = "okay"; > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/x1e80100/ASUSTeK/zenbook-a14/qccdsp8380.mbn", > + "qcom/x1e80100/ASUSTeK/zenbook-a14/cdsp_dtbs.elf"; > + > + status = "okay"; > +}; > + > +&uart14 { > + status = "okay"; > + > + bluetooth { > + compatible = "qcom,wcn7850-bt"; > + pinctrl-names = "default"; > + pinctrl-0 = <&bt_en_default>; > + enable-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>; > + max-speed = <3000000>; > + }; > +}; > diff --git a/arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts b/arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts > new file mode 100644 > index 000000000000..b6c9a707090f > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts > @@ -0,0 +1,48 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2025 Aleksandrs Vinarskis > + */ > + > +/dts-v1/; > + > +#include "x1p42100.dtsi" > +#include "x1-zenbook-a14.dtsi" > + > +/delete-node/ &pmc8380_6; > +/delete-node/ &pmc8380_6_thermal; > + > +/ { > + model = "ASUS Zenbook A14 UX3407QA"; > + compatible = "asus,x1p42100-zenbook-a14", "qcom,x1p42100"; > +}; > + > +&gpu_zap_shader { > + firmware-name = "qcom/x1p42100/ASUSTeK/zenbook-a14/qcdxkmsuc8380.mbn"; > +}; This file is not going to work on this SoC, you can drop it > + > +&remoteproc_adsp { > + firmware-name = "qcom/x1p42100/ASUSTeK/zenbook-a14/qcadsp8380.mbn", > + "qcom/x1p42100/ASUSTeK/zenbook-a14/adsp_dtbs.elf"; > + > + status = "okay"; > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/x1p42100/ASUSTeK/zenbook-a14/qccdsp8380.mbn", > + "qcom/x1p42100/ASUSTeK/zenbook-a14/cdsp_dtbs.elf"; > + > + status = "okay"; Are the DSP firmware files actually different between the two? Konrad