From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28E1F40DFC2; Sat, 18 Apr 2026 08:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=130.133.4.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776501245; cv=none; b=d9ziotNB++51ZW+YzDWxZ1zDdQdvDQL75MxTk3vLPN8u0md46I8AS03LfDyx9hlleG6JkM4CxLJO0wUKocb2pF5pgxW69tw5QPpv105rNMDHv1+vi77oNi0BInrhV/8ag6cVPP1Jr3T0A7ggvED9MHLZCNyh71MdklF8TRMldhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776501245; c=relaxed/simple; bh=1Nmw5c4GNu1ryk7au6qvqN6WH2nV1Vi1Lzvr7TswnIQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=YdoyPAQ06v6Qluh9nvbNa8HWBiB9ruXA2AuKmKV5sp4E0tiWfvJy8KKrv6O5CoqgFvqMwOZdaaark3ehrVlvt6KYWqXOMBJ9mamBoSzC5Akcki7Yz1TY2u7Qoa0nYdfhL76DbF0hf2h65vk/Gxm+3PqyCizpJ89Tz00QEk1QMLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de; spf=pass smtp.mailfrom=zedat.fu-berlin.de; dkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de header.b=NXErdslv; arc=none smtp.client-ip=130.133.4.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zedat.fu-berlin.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de header.b="NXErdslv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:From: Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:In-Reply-To: References; bh=J27VbeVHIJ/gt0ysqOueAw6rEC/nLhjNKdvK07zPsp8=; t=1776501241; x=1777106041; b=NXErdslv8fyVsAJslKqHpRYNgXOdUGB0n9yG6pOYAm/xCbe2ulNNitIgy7Va9 WVSotfn13ldSnV+qzu88YLpN9TQevIcGJZgyHQv64kC1vP+Xb/zGN6cxJCT22TBUx1lfGDmXyNqQX 9y8AlXxm/TJFA2kSs/zAKQ/CkJbFT1DizxGhPXXP9t4VFQlN6nFSlboqVU/cPCsKy4HofLpSWnfyF EE8DIp2uHRsABQglN16r7z5dkeO2bFn3M1zp0TmTNxbv4/agfop4yf+N5u3Ea9aXP8JNpZU8JlW24 VxzAaHPmZWSdJm2uejR6bNiX7PstBOiu5DEFN3GbG9opzyEE7g==; Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.99) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1wE17l-00000002FzZ-0sFU; Sat, 18 Apr 2026 10:33:57 +0200 Received: from dynamic-002-245-042-176.2.245.pool.telefonica.de ([2.245.42.176] helo=[192.168.178.50]) by inpost2.zedat.fu-berlin.de (Exim 4.99) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1wE17k-000000011AZ-4AG3; Sat, 18 Apr 2026 10:33:57 +0200 Message-ID: Subject: Re: [PATCH] sh: fix fallout from ZERO_PAGE consolidation From: John Paul Adrian Glaubitz To: Mike Rapoport , Andrew Morton Cc: Rich Felker , Thomas Wei?schuh , Yoshinori Sato , linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Date: Sat, 18 Apr 2026 10:33:56 +0200 In-Reply-To: <30ff5e1e6c0c3d4e0fb3b6f36a5372ed6bf45d19.camel@physik.fu-berlin.de> References: <20260417103208.1217010-1-rppt@kernel.org> <30ff5e1e6c0c3d4e0fb3b6f36a5372ed6bf45d19.camel@physik.fu-berlin.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-ZEDAT-Hint: PO Hi Mike, On Fri, 2026-04-17 at 12:56 +0200, John Paul Adrian Glaubitz wrote: > On Fri, 2026-04-17 at 13:32 +0300, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > >=20 > > Consolidation of empty_zero_page declarations broke boot on sh. > >=20 > > sh stores its initial boot parameters in a page reserved in > > arch/sh/kernel/head_32.S. Before commit 6215d9f4470f ("arch, mm: > > consolidate empty_zero_page") this page was referenced in C code as an > > array and after that commit it is referenced as a pointer. > >=20 > > This causes wrong code generation and boot hang. > >=20 > > Declare boot_params_page as an array to fix the issue. > >=20 > > Reported-by: Thomas Wei=C3=9Fschuh > > Tested-by: Thomas Wei=C3=9Fschuh > > Fixes: 6215d9f4470f ("arch, mm: consolidate empty_zero_page") > > Signed-off-by: Mike Rapoport (Microsoft) > > --- > > arch/sh/include/asm/setup.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/arch/sh/include/asm/setup.h b/arch/sh/include/asm/setup.h > > index 63c9efc06348..8488f76b48b4 100644 > > --- a/arch/sh/include/asm/setup.h > > +++ b/arch/sh/include/asm/setup.h > > @@ -7,7 +7,7 @@ > > /* > > * This is set up by the setup-routine at boot-time > > */ > > -extern unsigned char *boot_params_page; > > +extern unsigned char boot_params_page[]; > > #define PARAM boot_params_page > > =20 > > #define MOUNT_ROOT_RDONLY (*(unsigned long *) (PARAM+0x000)) > >=20 > > base-commit: 43cfbdda5af60ffc6272a7b8c5c37d1d0a181ca9 >=20 > Thanks, I'll try to test this patch this weekend and will pick it up for = v7.1. > I have already collected a number of patches for v7.1 with my Reviewed-by= . I just realized that this patch actually depends on 6215d9f4470f ("arch, mm= : consolidate empty_zero_page"), so I cannot take it directly into my tree no= w. Shall we wait for v7.0-rc1 then, so I can pick it up as a regression fix? Thanks, Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913