From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB6E5522F for ; Mon, 16 Jun 2025 09:27:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750066056; cv=none; b=ihnTkdnwtEitsPi2ta3jalQECOxJjCbgaYxO1dLtv16EenenyXT2Vz5l7tvRMHl7Is/xV9/Tx0eLJLIwweZ9eQWkciOWS7eApCYDqQAXDujDoLAC8Jct1bMbKDM2G97pcUyGxuFTlBwMw3YfIwruFoVOMUJbfe892UcNK7MzpjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750066056; c=relaxed/simple; bh=T2WFjnmOZ07v3v7UHQjXnCVxJbkNC7tdJ7mcbWqQNgw=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=RPr9wpyvgX+PuKUonIttW6z7SJZBCdXCrGzIm0d1uqW8VhbTShajZJqxmfIJV5UQOuXttwGWN/5GIzmlhgyqy7pa+DCd2/3PZqINoqugApyKdwulXBaB6GGHwvfz3+yXgzvD/c8H3aUZh3pI9Mpft8KiWsU5Y3/fIg1AVjw7SSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4bLPjb4dq6z1V43x; Mon, 16 Jun 2025 17:25:07 +0800 (CST) Received: from kwepemk200017.china.huawei.com (unknown [7.202.194.83]) by mail.maildlp.com (Postfix) with ESMTPS id 76F2F1400D2; Mon, 16 Jun 2025 17:27:31 +0800 (CST) Received: from [10.174.178.219] (10.174.178.219) by kwepemk200017.china.huawei.com (7.202.194.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 16 Jun 2025 17:27:30 +0800 Subject: Re: [PATCH drm-dp 03/10] drm/hisilicon/hibmc: fix irq_request()'s irq name variable is local To: Dmitry Baryshkov , Yongbang Shi CC: , , , , , , , , , , , , , , , , References: <20250530095432.1206966-1-shiyongbang@huawei.com> <20250530095432.1206966-4-shiyongbang@huawei.com> From: Zenghui Yu Message-ID: Date: Mon, 16 Jun 2025 17:27:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemk200017.china.huawei.com (7.202.194.83) On 2025/6/9 22:53, Dmitry Baryshkov wrote: > On 09/06/2025 17:50, Yongbang Shi wrote: > > > > > On Fri, May 30, 2025 at 05:54:25PM +0800, Yongbang Shi wrote: > > > > From: Baihan Li > > > > > > > > The local variable of irq name is passed to > > > > devm_request_threaded_irq(), > > > > which will make request_irq failed. Using the global irq name instead > > > > of it to fix. > > > This doesn't explain, why does it fail and which IRQ name is actually > > > expected. > > > > The local variable is passed in request_irq (), and there will be use > > after free problem. > > This needs to be explained (in details) in the commit message. +1. And I hope this can be fixed as soon as possible. I've run into several OOPS with that. Thanks, Zenghui