From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Ricardo Ribalda Delgado <ribalda@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: core: Fix warning message when init_data
Date: Wed, 1 Apr 2020 21:49:00 +0200 [thread overview]
Message-ID: <ef851b8f-0232-ab09-482e-ae575fb8dbde@gmail.com> (raw)
In-Reply-To: <20200401095147.444353-1-ribalda@kernel.org>
Hi Ricardo,
Thank you for the patch.
On 4/1/20 11:51 AM, Ricardo Ribalda Delgado wrote:
> The warning message when a led is renamed due to name collition can fail
> to show proper original name if init_data is used. Eg:
>
> [ 9.073996] leds-gpio a0040000.leds_0: Led (null) renamed to red_led_1 due to name collision
>
> Fixes: bb4e9af0348d ("leds: core: Add support for composing LED class device names")
> Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
> ---
> drivers/leds/led-class.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 1fc40e8af75e..3363a6551a70 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -376,7 +376,7 @@ int led_classdev_register_ext(struct device *parent,
>
> if (ret)
> dev_warn(parent, "Led %s renamed to %s due to name collision",
> - led_cdev->name, dev_name(led_cdev->dev));
> + proposed_name, dev_name(led_cdev->dev));
>
> if (led_cdev->flags & LED_BRIGHT_HW_CHANGED) {
> ret = led_add_brightness_hw_changed(led_cdev);
>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-04-01 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 9:51 Ricardo Ribalda Delgado
2020-04-01 19:49 ` Jacek Anaszewski [this message]
2020-04-06 21:13 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef851b8f-0232-ab09-482e-ae575fb8dbde@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=ribalda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome