From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbeDSNZg (ORCPT ); Thu, 19 Apr 2018 09:25:36 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:31398 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750735AbeDSNZe (ORCPT ); Thu, 19 Apr 2018 09:25:34 -0400 Subject: Re: [PATCH v2 1/2] irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain To: Marc Zyngier , =?UTF-8?Q?Rados=c5=82aw_Pietrzyk?= CC: Thomas Gleixner , Jason Cooper , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Benjamin Gaignard , Philipp Zabel , open list , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:GPIO SUBSYSTEM" References: <6491f248c6748f21a2acf310e186d2be4f9b4e4c.1519374248.git.radoslaw.pietrzyk@gmail.com> <118e66b4-3137-7af5-b93d-b1949fad575c@arm.com> From: Ludovic BARRE Message-ID: Date: Thu, 19 Apr 2018 15:24:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <118e66b4-3137-7af5-b93d-b1949fad575c@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.119] X-ClientProxiedBy: GPXDAG8NODE5.st.com (10.75.127.87) To GPXDAG6NODE4.st.com (10.75.127.80) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-19_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Radoslaw I preparing a patch serie which add support of stm32mp1. Would you like, I add your patch (with commit message updated) in my serie? patch: -irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain BR Ludo On 03/14/2018 01:04 PM, Marc Zyngier wrote: > On 14/03/18 11:46, Radosław Pietrzyk wrote: >> Hi Marc, >> We had a quite fruitful discussion in this mail thread regarding this >> topic and Ludovic acked it so recently I have asked Thomas if he still >> needs this v3 patch with detailed explanation especially as v2 version >> of stm32-gpio patch has been already taken by Linus. However if you >> require I can resend v3 of this patch only with this detailed explanation. > > That'd be useful. The changelog is the only thing that will be left from > this discussion, so it'd better be complete and accurate. If you quickly > send a v3 for this single patch, I'll queue it right away. > > Thanks, > > M. > >> >> 2018-03-14 12:09 GMT+01:00 Marc Zyngier > >: >> >> Radoslaw, >> >> On 23/02/18 08:42, Thomas Gleixner wrote: >> > Radoslaw, >> > >> > On Fri, 23 Feb 2018, Radoslaw Pietrzyk wrote: >> > >> >> - discards setting handle_simple_irq handler for hierarchy interrupts >> >> - removes acking in chained irq handler as this is done by >> >> irq_chip itself inside handle_edge_irq >> >> - removes unneeded irq_domain_ops.xlate callback >> > >> > if that's all functionally correct, then this is a nice cleanup. Though >> > from the above changelog its hard to tell because it merily tells WHAT the >> > patch does, but not WHY. The WHY is the important information for a >> > reviewer who is not familiar with the particular piece of code/hardware. >> > >> > Can you please amend the changelog with proper explanations why a >> > particular piece of code is not needed or has to be changed to something >> > else? >> >> Any update on this? I'd like to queue this for 4.17, but Thomas' >> comments should be addressed before that happens. Ca you please respin a >> version with a better change log and the various review tags? >> >> Thanks, >> >>         M. >> -- >> Jazz is not dead. It just smells funny... >> >> > >