From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C38C6C433F5 for ; Tue, 17 May 2022 09:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243993AbiEQJDz (ORCPT ); Tue, 17 May 2022 05:03:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235185AbiEQJDp (ORCPT ); Tue, 17 May 2022 05:03:45 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEF2F1D0FC for ; Tue, 17 May 2022 02:03:44 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id E6B331F4439C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652778223; bh=UYubMcn9ZLqkxXynnDr3S5Ixi/XQwp/zcG8Jzl6yAGY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nsd51A3QHf00rG6Hi57mYXcMCohcrFDwfxP2vm41heblBqYqP8pdbTedoIPenjYQg mbQs94iUCp2qwefb47xG401nrdU2yt+Rl+winnnME+eFXM/JThc01Nnazdb30flLt5 XBQJtCZRigSTDLWb0i8lZAU8dxwVCkcGHPpnnJWxpRXXH/CvT0e65pnL1AOhyyxbaV UGu92yeY7/xGcFT9j0CZtSm1lM9cXCpZebKiLCHAs+utdb0q4mWslt+1OPZaqRzDli qOPYmdS5+29ArJIlZ9xwgkIkD0IJdXpkSA2njVHjVL41vHJRs1tE2FhBs46O8X/XRL LHWsl9p/kuutA== Message-ID: Date: Tue, 17 May 2022 12:03:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context Content-Language: en-US To: Erico Nunes , Steven Price Cc: David Airlie , Daniel Vetter , Tomeu Vizoso , Rob Herring , Alyssa Rosenzweig , Rob Clark , Andrey Grodzovsky , Dmitry Osipenko , linux-kernel , dri-devel References: <20220411221536.283312-1-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/17/22 10:40, Erico Nunes wrote: > On Wed, Apr 13, 2022 at 12:05 PM Steven Price wrote: >> >> On 11/04/2022 23:15, Dmitry Osipenko wrote: >>> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking >>> mutex when job is released, and thus, that code can sleep. This results >>> into "BUG: scheduling while atomic" if locks are contented while job is >>> freed. There is no good reason for releasing scheduler's jobs in IRQ >>> context, hence use normal context to fix the trouble. >>> >>> Cc: stable@vger.kernel.org >>> Fixes: 542cff7893a3 ("drm/sched: Avoid lockdep spalt on killing a processes") >>> Signed-off-by: Dmitry Osipenko >> >> Reviewed-by: Steven Price > > Is there something blocking this patch? > Mesa CI is still hitting the issue and I have been waiting for it to > be applied/backported to update CI with it. > Thanks If this patch won't be picked up anytime soon, then I'll include it into my "memory shrinker" patchset together with the rest of the fixes, so it won't get lost. -- Best regards, Dmitry