From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbdBZBdn (ORCPT ); Sat, 25 Feb 2017 20:33:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:46828 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784AbdBZBdm (ORCPT ); Sat, 25 Feb 2017 20:33:42 -0500 Subject: Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for hi3798cv200 SoC and Poplar board To: Jiancheng Xue References: <1487752716-14824-1-git-send-email-xuejiancheng@hisilicon.com> <1487752716-14824-2-git-send-email-xuejiancheng@hisilicon.com> Cc: robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, arnd@arndb.de, xuwei5@hisilicon.com, devicetree@vger.kernel.org, mark.gregotski@linaro.org, linux-kernel@vger.kernel.org, yanhaifeng@hisilicon.com, peter.griffin@linaro.org, elder@linaro.org, hermit.wangheming@hisilicon.com, linux-arm-kernel@lists.infradead.org From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: Date: Sun, 26 Feb 2017 02:32:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1487752716-14824-2-git-send-email-xuejiancheng@hisilicon.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 22.02.2017 um 09:38 schrieb Jiancheng Xue: > Add bindings for HiSilicon hi3798cv200 SoC and Poplar Board. > > Signed-off-by: Jiancheng Xue > --- > Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt > index f1c1e21..1fd3dd7 100644 > --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt > +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt > @@ -4,6 +4,10 @@ Hi3660 SoC > Required root node properties: > - compatible = "hisilicon,hi3660"; > > +Hi3798cv200 Poplar Board > +Required root node properties: > + - compatible = "hisilicon,hi3798cv200-poplar", "hisilicon,hi3798cv200"; Please remember to CC previous reviewers. This still looks wrong: Why is this not "hisilicon,poplar" if you choose against "tocoding,poplar"? Is there a second Poplar board with a different SoC? Even then it would be redundant with the second compatible string. Regards, Andreas > + > Hi4511 Board > Required root node properties: > - compatible = "hisilicon,hi3620-hi4511"; -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)