From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792617375; b=AOy4FMg9INdMc9iZtXrZEf03MczBKOyWnf+MMzgrX8C5FpWBY//DW/x6J5WOW70Hb0EN TUN/0yVt4K3wpkWkdwBAy9qqBtpf9MnKLXjz71TJNQa2ReNfCkLE/2dtfHqRhgCLOOcij XUjVoYc20Pu4yJ7Ka3yXdL5docoG7JOLyIRR7qbEKZMPOFOWnDkRjJ/7cBJ7/PJtDl21H MhapgCY3un4VOmhlMFXezxvqJQj/RAZMv6eFh/zhr+uQQmZ02lF0K/OJpL+uNmNr1diYL F7EhOVYElGRRzRST8456spM7ye9xIEQf/KvEGI8+0yaLQOO9c8q9gHLv9mGYhIRyWuA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792617375; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Authority-Analysis:X-Proofpoint-GUID: X-Proofpoint-Spam-Info:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=In7UWKZFYC3zSnJsQr1KWQoGjjGRCbWkVCXiuO48ynQ=; b=DChYx0dprVaa7nvoSsWOhSSHavW4bM88qDvNqrdtNj9s8fa02h4Qhx7NtZBANN1uJFaH eAOkTOsgPILK1yMs/XeZqZzOH4m6PtQGAo36nfQKM+cwX/eEJa8i7ulUFb1Sspao5TXPb twnZei+etkMHKZVLROcDG3jQ21rIgusn8p6wnbRw6YM/+3anKzp0sob5TqFPqC4kzbsZy 6UnIOupMkJTuoqVSKjA+irSp57xI7Xa/sB920lPIaUsGoQsBYAcCIFB6j0PEzEc8jAApF SPq5b23XOjmcJxZX/hmNjpqsBiYeRr1DT1nFNdJMHJYRi5wtWuFslE3xC5KJaU2n5XQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=e8p3urDB; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=ii5dHDNF; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B169B606A31A for ; Wed, 21 Oct 2026 21:16:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B169B606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=e8p3urDB; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=ii5dHDNF Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69LKe2BI1669528 for ; Wed, 21 Oct 2026 21:16:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= In7UWKZFYC3zSnJsQr1KWQoGjjGRCbWkVCXiuO48ynQ=; b=e8p3urDBkNn0Qwxu QgKsj7vg5qiGp0woOOXU26cWe3QNGql/aNqfrqHIOYv4AoFUS2cFMeU6a6PxqbsU eEfhqd47h2mv+C+1zrsxOhkeL+FpAfEJBJPTPoq3XAuIul13mp2JlR2EkrAZvxyq jsz2l4Cxav82YO1G3bRILzFlGijsWe66daleEr3yPviFTOGTGkOrmXao03HfbwAD pmS3YQeGcytTBSAWfO1PIT1w6PQadUVV71mmZT9yel9zEqNgTxU1z0UHnrS1TnHB Z1/1Or3rwbCKS/dyP2ljOhY1i+FBPnaazXxlGkGubngc8LKr0QKtBYZYSjDAeDqs QvJdRg== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hf2cq0mqn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 21 Oct 2026 21:16:13 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-35c3c370b17so1864094eec.0 for ; Wed, 21 Oct 2026 14:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792617373; x=1793222173; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=In7UWKZFYC3zSnJsQr1KWQoGjjGRCbWkVCXiuO48ynQ=; b=ii5dHDNFCcx6wDZI3O8lD0I3rJEIBZ7bjDN9BhEAzRYmfBesqxGzObeBeEIMCiAD4J HC7aE9fgtIvDs8RahcHAnFg4Z4/XylMYbTa91Lz3PsyJXBshxARKQeQMQLsed0lg29Hy tTc3AJghQDk9yLWqE3lcRdRau3x8LlqgxdgKAW1jiEzvEcDxOh2tswDX6mBuU2wAIgze 5YFnQCKnWhxqfJpQg2B29YKEPAGE08Bxb1CXzouFlRZgNsomzSXrNjc+o4a2+AxrbKiw Y335+I1d6PGfKyQfNvyhqB+sTdtiRtA2Z/WoArqjZrxMlTy/KxoIdh2YvY27CvDwiqcU Cc0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792617373; x=1793222173; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=In7UWKZFYC3zSnJsQr1KWQoGjjGRCbWkVCXiuO48ynQ=; b=Agi97pE7mMOK6nQnAVhaSpwULQrENcF3PvK5J80pDMhonXgUHkPRAR0IDczxkmjxZX 47zbmTmwk+fTg8S9JkwbXzXGF9vDZ1XC8xIEeuJVp92nCW3kRjeauTgkabdVE7POBKNC jrZnZims8nnSGLERpjl/TiuOo6vvHmfJ7wN9t4asbBgH9ccrv3ZDsU89hFa1gv+uav63 B6NPwBNSWIu8LvLQ6Q+K0S7EgBHSB/3Vdebwo5miBOFXA9w0WN0uFOFvTqVpVym1aPab Wo29FNrstbo6+yXi1JMFJorGojKcYXKXf9SlaPxvskjHxFbGimP9sSzqGVHsesjVCu7z 6PeQ== X-Forwarded-Encrypted: i=1; AKwUvBzIPbfP7hocqo0MtXyAzS7eBk+xdnV3LZO5EQleiuqs8vinJa5/TCWKiMfbtZHSoC8Q/PJ9bEpT4Bx3v4M=@vger.kernel.org X-Gm-Message-State: AFq9FYIIvgmu0akPgFsHQIteSljBfLkgrUNkekoKQUt9Mf1ZAcKr+n6x JQlSp06eD4sxpAvudo8hfLYeJ1vc7oC6n4YtcraZjyByATt8yvEGGO8f+vY23tev8SV4iDdhh9w KrX+D4rpQX7kvSnR8TWPvRs7dWFuo7+i4I2A+RnCyvIzPfqfX1gABLqmi9lLLJq+NvpyJBE78jQ == X-Gm-Gg: AYBFou1t3M8ycikcu1i4e0a0+RqJqA5PbisYBWgx0s2SNigVzTKprVmod5m/CQDVVJL Ycjso/jH1BvrVVX1gwqI5AvN+FL1H11BAyTB+okqKsnp4Djnt9EFtF5/gzCb4H+M6zbTiO5aFLI nFJLUS5kmMDgvEU1bd7LoMcgk4nM9X9td2yVtUlwwcvoos0rXwpq4UVcGQYhqmppQIKgsp4SYKh 3CBBkuzbhC2lLXsb3btu+kkZgdWukN4ssQhyjU0kQrmQH5mvrvGvBeiJioufQ+Wxv0Z7GdR2yxl lbWmVQqW4tq2O6a1CVqmcNlbNwsd14eySy3v+AFl2/OyL765G5tK81bXzpOxELUHZj2Ygn05fHW 262swSg9q01+tgtcfO7EKY5rtDq3/O7s= X-Received: by 2002:a05:7300:828a:b0:367:185e:867a with SMTP id 5a478bee46e88-3674f21c1f2mr4409484eec.38.1792617372489; Wed, 21 Oct 2026 14:16:12 -0700 (PDT) X-Received: by 2002:a05:7300:828a:b0:367:185e:867a with SMTP id 5a478bee46e88-3674f21c1f2mr4409446eec.38.1792617371755; Wed, 21 Oct 2026 14:16:11 -0700 (PDT) Received: from [192.168.1.86] ([65.181.13.88]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36741f753f7sm9947297eec.27.2026.10.21.14.16.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2026 14:16:11 -0700 (PDT) Message-ID: Date: Thu, 22 Oct 2026 08:16:05 +1100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] tee: qcomtee: Register qcom.tz.tpm service for discovery To: Kuldeep Singh , Jens Wiklander , Sumit Garg , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe Cc: linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org References: <20261019-tpm_qcom_driver-v4-0-6889b9804ba7@oss.qualcomm.com> <20261019-tpm_qcom_driver-v4-1-6889b9804ba7@oss.qualcomm.com> Content-Language: en-US From: Amirreza Zarrabi In-Reply-To: <20261019-tpm_qcom_driver-v4-1-6889b9804ba7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=HLhWhYtv c=1 sm=1 tr=0 ts=6ad92b9d cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=DFNpOA17G2bluAzxCnbuxw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=TZTEVhZfE5fPnIgvEYgA:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-GUID: Fk021oUtDDWNhSOnQiSPXhOEF7SXe3p_ X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIxMDA4NCBTYWx0ZWRfX+yNwMYYEXxII UAZK7/7PNWrSDJ3n/GOxG8oQNq+7rv/fPAILxyZ624VYx6J+v4Gi8UVi+SucDprnmGstlykDH8I 9c06KLY/JtjNqY1pRrY669uM1rxagzQ= X-Proofpoint-ORIG-GUID: Fk021oUtDDWNhSOnQiSPXhOEF7SXe3p_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIxMDA4NCBTYWx0ZWRfX5zuBEJi0iOLQ 2Y5wJ7F87B/dk6S2yI5MN0DVgsz9KMlFZuh56YzCBcb5N8XEAGyIoyEWVxGBAI5BKKLi52x8dfO KUvg/I5/x9kBgHBhJXnxgn8oUc4ArNF80SsFTZD2K4fbq9kDCoH5+meaZyBeTVcOnPNKHooRV87 m6pt7wyMqQrraxqcn2+3SQO+8bpt6WNtMsXWON78ciRxZTL1A4NzDNkS88qaraQHj7MyM/k3KL+ 7CeZQobZ+0B9nqO7fhpIiQHcOKyn9ZV9obxpP3cb0ouGnwBX+GaWoykdKbnN70WhiggWZibUjT7 TzkJM5wYXsbP9h2DCq9Ebh57/lnbi4aWj2EZh7jknv0/yLBcfFthgHBPYwn3lYBvLvfTUsjd+fQ /3Ru+soWusKS6lyAs1PLwAW2SL2gVisksre89NSX+lbydELFmdhrjtiVVJJGhf2zyjzsPkuv+cN tDPVvFsB6/SIBl0yd4g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-21_06,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610210084 On 10/19/2026 8:21 PM, Kuldeep Singh wrote: > Add "qcom.tz.tpm" (QCOMTEE_TPM_UID) to qtee_services[] so the TPM TA > is enumerated as a TEE-bus device, allowing a client driver to bind to > it via its generated UUID. > > Reviewed-by: Jarkko Sakkinen > Signed-off-by: Kuldeep Singh > --- Looks fine to me. Reviewed-by: Amirreza Zarrabi - Amir > drivers/tee/qcomtee/call.c | 4 +++- > drivers/tee/qcomtee/qcomtee_msg.h | 2 ++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/tee/qcomtee/call.c b/drivers/tee/qcomtee/call.c > index 47d8a4f9a159..1b887da83341 100644 > --- a/drivers/tee/qcomtee/call.c > +++ b/drivers/tee/qcomtee/call.c > @@ -747,7 +747,9 @@ static const uuid_t qtee_service_uuid_ns = UUID_INIT(0xe1b48857, 0x6154, 0x49f9, > > static const struct qtee_service qtee_services[] = { > { "qcom.tz.uefisecapp", > - QCOMTEE_UEFI_SEC_UID } > + QCOMTEE_UEFI_SEC_UID }, > + { "qcom.tz.tpm", > + QCOMTEE_TPM_UID } > }; > > static void qtee_release_service(struct device *dev) > diff --git a/drivers/tee/qcomtee/qcomtee_msg.h b/drivers/tee/qcomtee/qcomtee_msg.h > index 9278a361dc70..9fff9dc5fffb 100644 > --- a/drivers/tee/qcomtee/qcomtee_msg.h > +++ b/drivers/tee/qcomtee/qcomtee_msg.h > @@ -106,6 +106,8 @@ union qcomtee_msg_arg { > #define QTEE_VERSION_GET_PATCH(x) ((x) >> 0 & 0xfffU) > > #define QCOMTEE_UEFI_SEC_UID 413 > +#define QCOMTEE_TPM_UID 81 > + > /* Response types as returned from qcomtee_object_invoke_ctx_invoke(). */ > > /* The message contains a callback request. */ >