From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0638E435AAA for ; Mon, 6 Jul 2026 22:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783377233; cv=none; b=gYHg8Hv9Thiom/yrSehKxInOcZlOSRR8u7Pft4ppu+D0wBRD7tQHLQUFRsY+lxWJbQQaNAq8qwxh1dNgg4ctRx0H1noroYClr9R2JM9Snycm4SJk1u+r9IajcaVDAo6Rw5aCMU0pQCEnIEXTObMEx40xrRI17PkBtHy2hGdMVf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783377233; c=relaxed/simple; bh=XVcl6BRwP7RrU/ox9Ml72dHb0MOHCEwPiu3RHFD6tmw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R5dDYqQA+NxZ/qwZMD9C9ZfBG18/6B9bRjba3YzniaZn943/eVQPCyXjf8qVBdHAmid2MamfIqqejDZlc4aAM5qKbDv6h0D+ixnNDhxs1s5WhCzPQlEQWpw8UvmnBWCTz4Qhr0VMvFwcnvvQzTUL77UAAdYeBlJYxQFQ0kwt3EU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HHe7z5Qc; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HHe7z5Qc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783377232; x=1814913232; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=XVcl6BRwP7RrU/ox9Ml72dHb0MOHCEwPiu3RHFD6tmw=; b=HHe7z5QcwOw4vVkA3gp3HaM2N5GdbMElfRyZcAjOinI0DsW5/0nygt67 4XHrm0hGY8/tAZw48dGyV4R6edT/mR5FBnkHjAJnsn8GFs6a/Kua2Abex vTPaki82bEzwapDtZOV9fQhtl0hZo1l3qwPlOPstCLzcz2XxMTU+Lm52N +dpJ5Pp7qYt3t4qqqiUzopD0jXCPJ28GbT0YQiEmoFVsUdBwBO+UxRw+y zpRUsGOlRPloYQ7FWSfp6fSh2/367gprhCdjrnvA7qh+0XiN/lfNRC5Gs uRbgsdd41Dt/UFcrNnVQUjT81v9PRbgZ2YU+FCn/Y8k7WOUvRg+lEZJvq w==; X-CSE-ConnectionGUID: spgxhPJZT0uRZY1A7GLDew== X-CSE-MsgGUID: 9CXn355TSMKwV9Jo4Z085w== X-IronPort-AV: E=McAfee;i="6800,10657,11839"; a="87700870" X-IronPort-AV: E=Sophos;i="6.25,151,1779174000"; d="scan'208";a="87700870" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2026 15:33:52 -0700 X-CSE-ConnectionGUID: bJDXbE9CSfOMTYa9ViaHJg== X-CSE-MsgGUID: yeNGLJTkRw62Ph0Y1jUSBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,151,1779174000"; d="scan'208";a="278179608" Received: from sghuge-mobl2.amr.corp.intel.com (HELO [10.125.110.202]) ([10.125.110.202]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2026 15:33:50 -0700 Message-ID: Date: Mon, 6 Jul 2026 15:33:49 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvdimm: ndtest: remove redundant NULL check before vfree() To: mdshahid03@gmail.com, Dan Williams , Vishal Verma , Alison Schofield , Ira Weiny Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260703135513.75840-1-mdshahid03@gmail.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20260703135513.75840-1-mdshahid03@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/3/26 6:55 AM, mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > vfree() safely handles NULL pointers, so the explicit NULL check > before calling vfree() is unnecessary. > > This issue was reported by ifnullfree.cocci. > > Signed-off-by: Mohammad Shahid Reviewed-by: Dave Jiang > --- > tools/testing/nvdimm/test/ndtest.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c > index 8e3b6be53839..2051ad5d4882 100644 > --- a/tools/testing/nvdimm/test/ndtest.c > +++ b/tools/testing/nvdimm/test/ndtest.c > @@ -376,8 +376,7 @@ static void *ndtest_alloc_resource(struct ndtest_priv *p, size_t size, > buf_err: > if (__dma && size >= DIMM_SIZE) > gen_pool_free(ndtest_pool, __dma, size); > - if (buf) > - vfree(buf); > + vfree(buf); > kfree(res); > > return NULL;