From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 976A031DD97 for ; Fri, 13 Mar 2026 08:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773392181; cv=none; b=bj6+0soOoGGc0/HDJE3Sg/DJ1TlGD4OklJeZZGNVFAeg+iIHivIL9CnGNqjoKCaW3vO0SvcErmQgkA/jt72lAgXWyYMxfcE2X8ywP/T7XPhO0jwGH++uW/XmRDGYTiS6XCcqU5vs7BelF8/J61Cih78PmABuQ/ltPudHGHVmrIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773392181; c=relaxed/simple; bh=x6+eV/R96m8je37vMamUbxvckpVf8Jd53USvzCJFYeY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s8G4nNDcWGuvkWv+bE/iauN+tPi1GWT8Av4Nwv/ibm4SCUqpXocM8dOBexVJ1S3u2ygmj8d2om/jfAwDl7lqux6FawhU2ETR8cwdw4TnZC7ugnHx49i1AgZhDiIGbV6zluzhKifl2O7F4A6DEg4US8pIZwLa5Olh34mA3fdbdP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OsawEOP2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YIDTb5Qt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OsawEOP2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YIDTb5Qt" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5tiRY1176661 for ; Fri, 13 Mar 2026 08:56:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hHJ+OTXo+29v/laS7IzAJmVSdR/9siZcimaLF71wORA=; b=OsawEOP2mO5/7uE0 JLJ+tIMOGTKsnCzX+tNE33rJ9jHuD+cheT0EY9MNEJIQpUBSCnZn0hVb0lcArYRH sFlfI8XtCOJ0qSpYrB2gPSc1Xf3n3lIuYMQazf94DZX1WGcE7gUvawhlzsIiMyIf LCmZA8n2fCGkok2ncrCw5iZqrqHrpHN9WCRHYtwXZWP3zWgQL+05D+rlzNPsUQfl hlQ2VZ5ViuHFCXTWppA08zqdD4sqsd8xOMAd9ZTrqHGZbRiA1JtvhRZ9tEtYy7V9 UznpbxPjUp0Nlo8vOIILjzAxpvAq++s3WrDg8ZGMN4JUdnFlTP2v8okdT/34fwVh Gny5XA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cumvqcrrj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 08:56:18 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae3f446ccfso20530885ad.2 for ; Fri, 13 Mar 2026 01:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773392178; x=1773996978; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hHJ+OTXo+29v/laS7IzAJmVSdR/9siZcimaLF71wORA=; b=YIDTb5QtBnIXM6YJ7GZwcA/9UYR966T5LLDHIffKEjW+pdQbwHeTuv3hKFSnlXWu6O VhFLTylBD1bODOH+QFMqNwS9R0TYWUJdPUaNtNfqOjiC96TfCvNVMG4rrdGp01b2YgnH i9kIv9Z504POGv7SqnkcoGuE/twWSa96rqeRQdJNkpRdFwZZWr5A7ZNGc7i24Pu7sPve xgXnFwcmSSisqItRleZuszAOCv2nnXdH4hdmpYtsHbbeS/hWMBi22K1J+tK+ELTG11j+ d8jIK8euNehOT2vxaGxrkcnhwr94Ahl3K8vLosmzhOOv/6QxtTBzOX3RTBL+r55eSuXj SIfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773392178; x=1773996978; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hHJ+OTXo+29v/laS7IzAJmVSdR/9siZcimaLF71wORA=; b=o6BDOTh9IOIKwKRoFIkYlG9yOOkhSdxccpZzfHqUSltpOfZ9uMBbucgzGV569p5oO0 mqzhTKZuYV/lbhaa+bNjAZ6LBihMMhSpNmAfZZY4gCmL4lScdLOAmVDi0HeCPDKLTIRt d1gjgvI5zBasjO6ffXFhtCvj/cR8R4ZX29m0NclxohNAIQcqDNs09dCc9ddnQN3+z9ul RWy3XT4oxmgebB2uuIwn4LLQ2ekVkx+O3Ih2MBJZ6CCDc1GP1GSn2a8Z7yh1QIuLR57M gSPzbVF8SIHLmjhHo9ZvsVib1/xE0dlUNSAECHGUr7eLc04+NlOnEwqKkiFXWIjdjsnb I/+w== X-Forwarded-Encrypted: i=1; AJvYcCUOpKTdEwE/xZIjUWOv+nPy2WhFhJSdZPMnmWTtQ4oTC1VkZUiPLlh45q8n8ympucvki3uhYtjoKD/jDEY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9jZ+/hMwLhCr3S9bEjaug1D6Zm0E0W9IAi4RilXefmnmkPGey Tf0Ddq8Fsx36aV3DiSUXFJ9pB8/iAIkfKLd+CI6Lv2f/DjRLrCNe5yWHEm/074e2PU/DQaALZrJ PbUz4wuFt/mXCs/01wJ9rnH5zzIHWEiVvXDbZySz2sNhDdV5is0vfkmoV0enOrVs1vt4= X-Gm-Gg: ATEYQzyl7uZeGxFdXpcrnCAqFVh4YRyjxglHR5oAfw1Qq1KXqwvFAkBNONYp16qiiCU GaRK6k2CFgwbiOCzN9UKPwawtyi7ZP1Ku/LjEQCEwmtzAQ8UO5utJ+TgUpaEkDntCZguTUast3w hGAHp8L7QDXh3uWbSB6/KKz3UHE2IDmvJcH0HgyHE5s9ORFaEAzKUcnfVQ11uOazT6sF65KsVZf 7SGUoDwFXaT9wdjttE2Ka4r0HXSkoXTCbHINB2rUaySemAbjWpWJT86cOTd5OjxnoJKLfOFFC27 +GWesDNakLQXBm0ukuz0Ep5tIg3KqeDwGDZm8Ixj30f8RCGQ0R7iBzyNRloyZnW07Gr+xTQQ+vq uFA3E83aaHlC6iJxwpGqVLveA9dj2v8vd/Q7f/GQ3txA5NDXZSNkJ X-Received: by 2002:a17:903:390d:b0:2ae:3cf0:3aa1 with SMTP id d9443c01a7336-2aecaa3bfe2mr28452535ad.37.1773392178089; Fri, 13 Mar 2026 01:56:18 -0700 (PDT) X-Received: by 2002:a17:903:390d:b0:2ae:3cf0:3aa1 with SMTP id d9443c01a7336-2aecaa3bfe2mr28452215ad.37.1773392177599; Fri, 13 Mar 2026 01:56:17 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece858d18sm15261675ad.86.2026.03.13.01.56.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 01:56:17 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 14:26:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 7/8] media: qcom: iris: split firmware_data from raw platform data Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313-iris-platform-data-v4-0-14927df4906d@oss.qualcomm.com> <20260313-iris-platform-data-v4-7-14927df4906d@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260313-iris-platform-data-v4-7-14927df4906d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: g0ut0244y_7BxbYDneuGDz_NnaIGfS1N X-Proofpoint-GUID: g0ut0244y_7BxbYDneuGDz_NnaIGfS1N X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA2OCBTYWx0ZWRfX0/cbpcwHAubs CkJv1nz1w5F7JBsrhP1nEgkAs5cloSYipfzvD6CNs3rIXJu9/sIxVVmgepAkOb2QRc5yoQDoDKM lnG/Y/y7wJvdDVK9wxUiaNZQTX7WITWrGFbSOpd93M1UMi8VnRIFxMPglrhQ3QvrJM/BhNG2hme hrqXNMnHxxlLqYsmwUA9MfWyTvqXPqaoIfXfn5e9w/NbSLLvsgTO6tFXkv6C4eS1aGR3y4P82wf sQxgZW9b51hECgY8LhBzUVdZFezss+0dCCtEpgRxnQPaUTibbCqibYJT165YEInwH2OISJc61oP HD2KoKEXgQkwjZg5tjSm3h8ta6l2fALL6RIs9Yq2haGbtD5z1tpYBH7RzAP6avnYAljnc4lKq2m /RRR1C9tc5AhnwavVMpfEzOwVKrKFI2CUdZLGvHW3mZLC6fd7LGE2UYXhqLqylXasEoGy+kPotK 54hNstU5jDNCsxnZZQA== X-Authority-Analysis: v=2.4 cv=ccHfb3DM c=1 sm=1 tr=0 ts=69b3d132 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ndT/fs+coltRyMHftQWjTw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=fdpG-Y04AcStmw4gtO4A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130068 > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index d1daef2d874b..1a870fec4f31 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -201,45 +201,16 @@ enum platform_pm_domain_type { > IRIS_APV_HW_POWER_DOMAIN, > }; > > -struct iris_platform_data { > +struct iris_firmware_data { > void (*init_hfi_ops)(struct iris_core *core); > + > u32 (*get_vpu_buffer_size)(struct iris_inst *inst, enum iris_buffer_type buffer_type); > - const struct vpu_ops *vpu_ops; > - const struct icc_info *icc_tbl; > - unsigned int icc_tbl_size; > - const struct bw_info *bw_tbl_dec; > - unsigned int bw_tbl_dec_size; > - const char * const *pmdomain_tbl; > - unsigned int pmdomain_tbl_size; > - const char * const *opp_pd_tbl; > - unsigned int opp_pd_tbl_size; > - const struct platform_clk_data *clk_tbl; > - const char * const *opp_clk_tbl; > - unsigned int clk_tbl_size; > - const char * const *clk_rst_tbl; > - unsigned int clk_rst_tbl_size; > - const char * const *controller_rst_tbl; > - unsigned int controller_rst_tbl_size; > - u64 dma_mask; > - const char *fwname; > - struct iris_fmt *inst_iris_fmts; > - u32 inst_iris_fmts_size; > - struct platform_inst_caps *inst_caps; > + > const struct platform_inst_fw_cap *inst_fw_caps_dec; > u32 inst_fw_caps_dec_size; > const struct platform_inst_fw_cap *inst_fw_caps_enc; Thinking further about this split, I see another potential issue here. Some of the inst_fw_caps are not purely HFI dependent, but also vary with the VPU architecture. For example, on AR50LT (Agatti), certain capabilities such as rotation/flip are not supported, even though these platforms still use HFI Gen2. With the current approach, handling this would likely require having the structure in lets say iris_plaform_agatti.h which would be included in both iris_hfi_gen2.c and iris_platform_ar50lt.c which would lead to duplicate inclusion, the same concern you raised in kodiak gen2 patches. How do we tackle this problem? Thanks, Dikshita