mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	"Ewan D. Milne" <emilne@redhat.com>
Cc: jejb@linux.ibm.com, dgilbert@interlog.com, bvanassche@acm.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi_logging: print cdb into new line after opcode
Date: Mon, 25 Jan 2021 08:29:21 +0100	[thread overview]
Message-ID: <efab85a2-d22c-b9cb-d001-cbe09063ba5e@puri.sm> (raw)
In-Reply-To: <yq1mtx09wpa.fsf@ca-mkp.ca.oracle.com>

On 23.01.21 04:09, Martin K. Petersen wrote:
> 
> Ewan,
> 
>>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01
>>> 00
>>>
>>> Print the cdb into a new line in any case, not only when cmd_len is
>>> greater than 16. The above example error will then read:
>>>
>>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28
>>> 28 00 01 c0 09 00 00 00 08 00
>>
>> I'd rather we not change this.
> 
> I agree. While the current format is suboptimal, there are lots of
> things out there parsing these error messages.
> 

hi Ewan, hi Martin,

That's totally fine. I had this on my list since Douglas suggested to 
change this during a discussion back in july and I basically wanted to 
get opinions:
https://lore.kernel.org/linux-scsi/31f1ec62-7047-a34b-fdcb-5ea2a2104292@interlog.com/

thanks,
                                  martin

      reply	other threads:[~2021-01-25  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22  8:39 Martin Kepplinger
2021-01-22 19:52 ` Ewan D. Milne
2021-01-23  3:09   ` Martin K. Petersen
2021-01-25  7:29     ` Martin Kepplinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efab85a2-d22c-b9cb-d001-cbe09063ba5e@puri.sm \
    --to=martin.kepplinger@puri.sm \
    --cc=bvanassche@acm.org \
    --cc=dgilbert@interlog.com \
    --cc=emilne@redhat.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®