From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD1D33C28 for ; Mon, 1 Apr 2024 09:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711964698; cv=none; b=d6UVHSDMyFe9bXxIqbk5AF1T1JZeRpdvP3EN6QWHSmec2gwNlrh6pX9rLqruOkTVhkJ3/AauG+KNe0pGdm4pXacr+7jlHPCavXpM7IcxFqpFWcDw71cAUTzV+YKNcQp968FU21g02t+/fKkAt/sU/DLrdeRXpnXR+voMwJQFDng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711964698; c=relaxed/simple; bh=qyBtU57NPao8HVv6aPFX8AvzCNq74vDsTKJluz1U3sM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FufhHi7zH0gMogl0TAuZ5+OezaIhlMBYVbhZRKWZaCY9ryNxAAlSpO0ORKkBExxvFdXVlGBQLlXrYEAP59lympXzEgz0y7B53cPF2Ao2TcCx6rmU8Rwt9ZN4JA7AGFHeb0EGxuP7yEJ5EE9P3iTzgjNcszN3LlP0BwhpdP5w3Ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JWz/On4L; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JWz/On4L" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-56c0bd07e7bso3871090a12.1 for ; Mon, 01 Apr 2024 02:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711964695; x=1712569495; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=d+diNP0/3LUwNWUT5gbc+2tWQaGcrSkj9S8RpDkHp50=; b=JWz/On4LOKR8y7cckAIXwjFAc0lV/QlqRAn2ZnmNsn9tLHu1iKq8dJF1KFqhKhaIv1 ZrqI97MNyLWqqkFLabymPyEIIoi66df3OysyghSK8w5SLs64zwhG20NgYVZ7IjjTfKb1 PsVuJ/kztpPzrWOttIFboaVwIy3x4jhts9xvzSPCd60tTZsN9zukELEBQxpbU2gWNsFk U8P3HWsItIy1yzMukbo9KVBwKtu+PJxDWatSC5UtBu/wBhW9jaDS4LmCqf//Q/a3djoJ wbGZQYdP+ONYeWX1jLTCbjqjuRzI3Kr3r3Tu4T4c4SRdiIGGSXm+e2ADMcieb3CiDtk0 XeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711964695; x=1712569495; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d+diNP0/3LUwNWUT5gbc+2tWQaGcrSkj9S8RpDkHp50=; b=AoR+EXM56KWXAr163lMVg61lKWpC4afgdpAMr7GQPYmIZ8P+njxlS3/c0KWO54XsKC B4Q4QLb5YwlD1Pbwvc4IBrVXQ90ffyO1d5qA02AkIaLy/Dy1zidpJRS1wPfsei2aajTp f0t+4qDrQfSk01scUqz/DgCxmbhubCk/ZQc9Howi6nJb1YN6t26rXck4tlJsNe8sgcF6 DRGyW8rgYIcphb0NZM9FDW2DYGdfh+FokiyDoCQDIF0TfDxMltQmnmjgS9lo0L1FWhe9 veIcLzotyoVLy6S0z574eBvyncu4mnqJgiV35pVbZOQl+5Ul4vVQ0NBsEAn7reVWpmx2 yVGQ== X-Forwarded-Encrypted: i=1; AJvYcCXhl0uc5SlOql3e5Z1w0vcn0YcROBfmWE1/Gz7RtfIB4uoRtg8TX2whVcWaUeR16Z/7j5YguDHdL+ZzGEzPR9tEcSwe/jRiUUgEowno X-Gm-Message-State: AOJu0Yyykl9KVkgt3iAfD3zv/7J5p8shAjOsijdIn4c2vha52SnyVAxa GKhAbQssF9Q9Mcx6qxGsIucz/x/mGPdFvtDvE27l5TUTg3SJUZLXTRq2PJlPOJs= X-Google-Smtp-Source: AGHT+IHyAxC2Nha5nCXqGrQwGsjBWpEQ/9fhdptsCohMGEbhWFkiXJ6u69AXTVBFM4Ztj6ZVAZZT/A== X-Received: by 2002:a17:907:7248:b0:a4e:4350:3b3a with SMTP id ds8-20020a170907724800b00a4e43503b3amr5048203ejc.60.1711964695236; Mon, 01 Apr 2024 02:44:55 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id ef14-20020a17090697ce00b00a4e44f724e8sm3060972ejb.186.2024.04.01.02.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Apr 2024 02:44:54 -0700 (PDT) Message-ID: Date: Mon, 1 Apr 2024 11:44:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] mmc: sdio: store owner from modules with sdio_register_driver() To: Francesco Dolcini Cc: Ulf Hansson , Marcel Holtmann , Luiz Augusto von Dentz , Matthias Brugger , AngeloGioacchino Del Regno , Kalle Valo , Jeff Johnson , Arend van Spriel , Brian Norris , =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com References: <20240329-module-owner-sdio-v1-0-e4010b11ccaa@linaro.org> <20240329-module-owner-sdio-v1-1-e4010b11ccaa@linaro.org> <20240331203729.GC4116@francesco-nb> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240331203729.GC4116@francesco-nb> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/03/2024 22:37, Francesco Dolcini wrote: > Hello Krzysztof, > > On Fri, Mar 29, 2024 at 06:24:31PM +0100, Krzysztof Kozlowski wrote: >> Modules registering driver with sdio_register_driver() might >> forget to set .owner field. The field is used by some of other kernel > ^^ double space here > >> parts for reference counting (try_module_get()), so it is expected that >> drivers will set it. >> >> Solve the problem by moving this task away from the drivers to the core >> code, just like we did for platform_driver in >> commit 9447057eaff8 ("platform_device: use a macro instead of >> platform_driver_register"). >> >> Since many drivers forget to set the .owner, this effectively will fix >> them. Examples of fixed drivers are: ath6kl, b43, btsdio.c, ks7010, > ^^ and here Which is correct :). Double space is on purpose. > >> libertas, MediaTek WiFi drivers, Realtek WiFi drivers, rsi, siano, >> wilc1000, wl1251 and more. >> >> Signed-off-by: Krzysztof Kozlowski > > My nit comments are irrelevant, but given you did the same twice I felt > like letting you know. > > Reviewed-by: Francesco Dolcini > Best regards, Krzysztof