From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A67BC433E0 for ; Mon, 11 Jan 2021 08:14:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5508022A84 for ; Mon, 11 Jan 2021 08:14:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727815AbhAKIOC (ORCPT ); Mon, 11 Jan 2021 03:14:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727634AbhAKIOC (ORCPT ); Mon, 11 Jan 2021 03:14:02 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D18A2C061794 for ; Mon, 11 Jan 2021 00:13:21 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kysKG-0002Gq-99; Mon, 11 Jan 2021 09:13:20 +0100 Subject: Re: [PATCH 1/2] net: stmmac: retain PTP-clock at hwtstamp_set To: Jakub Kicinski Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Rayagond Kokatanur , kernel@pengutronix.de, Michael Olbrich , Ahmad Fatoum , Jose Abreu , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Richard Cochran References: <20201216113239.2980816-1-h.assmann@pengutronix.de> <20201216171334.1e36fbff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Holger Assmann Message-ID: Date: Mon, 11 Jan 2021 09:13:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201216171334.1e36fbff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: h.assmann@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17.12.20 um 02:13 Jakub Kicinski wrote: > > Thanks for the patch, minor nits below. Thanks for the Feedback! I will work it in for my v2. >> + >> + if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)) > > !a && !b reads better IMHO We've chosen this variant because it is already used this way in stmmac_main (e.g. in stmmac_hwtstamp_set(), stmmac_hwtstamp_get(), or stmmac_validate()). >> @@ -5290,8 +5330,7 @@ int stmmac_resume(struct device *dev) >> /* enable the clk previously disabled */ >> clk_prepare_enable(priv->plat->stmmac_clk); >> clk_prepare_enable(priv->plat->pclk); >> - if (priv->plat->clk_ptp_ref) >> - clk_prepare_enable(priv->plat->clk_ptp_ref); >> + stmmac_init_hwtstamp(priv); > > This was optional, now you always init? This was not intended. Will be fixed in v2 to be optional again. Regards, Holger