mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86_64: test xmm/ymm register state after execve(2)
Date: Mon, 11 Dec 2023 10:58:22 -0800	[thread overview]
Message-ID: <efb1b6da-0bbc-402c-8034-d15e4cd96500@intel.com> (raw)
In-Reply-To: <7bbef366-c897-4cd2-ae69-d3e8019c5b3a@p183>

On 12/5/23 22:15, Alexey Dobriyan wrote:
>>> +".Ltest_xmm:"
>>> +	"movdqu %xmm0, xmm + 16 * 0;"
>>> +	"movdqu %xmm1, xmm + 16 * 1;"
>> Does this work on systems without XMMs?  I know it's not common these
>> days but it's possible, especially in VMs.
> No. But I think all x86_64 systems have SSE2. So it is up to whoever will
> port this test to i386.
I somehow got it in my head that we can't do XMM's unless XSAVE is in
the picture.  But that's wrong.  FXSAVE works on XMM's just fine and
it's a requirement for FPU support, and 64-bit requires the FPU.

It would be nice to spell that out explicitly in the changelog if you
get a chance to resend this.

Also, on the license... You as the copyright holder are, of course, free
to distribute it under any license you want yourself.  But for the copy
in the kernel, it would be nice if you chose something you could stick
an SPDX label on.  That way, a maintainer knows immediately if the
license is OK or not.

      reply	other threads:[~2023-12-11 18:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 14:21 Alexey Dobriyan
2023-12-05 20:39 ` Dave Hansen
2023-12-06  6:15   ` Alexey Dobriyan
2023-12-11 18:58     ` Dave Hansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efb1b6da-0bbc-402c-8034-d15e4cd96500@intel.com \
    --to=dave.hansen@intel.com \
    --cc=adobriyan@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®