From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761072AbcLBOad (ORCPT ); Fri, 2 Dec 2016 09:30:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57110 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758563AbcLBOab (ORCPT ); Fri, 2 Dec 2016 09:30:31 -0500 Subject: Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero board To: Icenowy Zheng , Maxime Ripard , =?UTF-8?Q?Andr=c3=a9_Przywara?= References: <20161121162421.800-1-icenowy@aosc.xyz> <20161121162421.800-2-icenowy@aosc.xyz> <5373671480239408@web31m.yandex.ru> <20161201093619.gs6lmoxtlptp2jr6@lukather> <11498641480688550@web2g.yandex.ru> Cc: Jonathan Corbet , Chen-Yu Tsai , Mark Rutland , Russell King , Vishnu Patekar , Arnd Bergmann , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" From: Hans de Goede Message-ID: Date: Fri, 2 Dec 2016 15:30:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <11498641480688550@web2g.yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 02 Dec 2016 14:30:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02-12-16 15:22, Icenowy Zheng wrote: > > > 01.12.2016, 17:36, "Maxime Ripard" : >> On Mon, Nov 28, 2016 at 12:29:07AM +0000, André Przywara wrote: >>> > Something more interesting happened. >>> > >>> > Xunlong made a add-on board for Orange Pi Zero, which exposes the >>> > two USB Controllers exported at expansion bus as USB Type-A >>> > connectors. >>> > >>> > Also it exposes a analog A/V jack and a microphone. >>> > >>> > Should I enable {e,o}hci{2.3} in the device tree? >>> >>> Actually we should do this regardless of this extension board. The USB >>> pins are not multiplexed and are exposed on user accessible pins (just >>> not soldered, but that's a detail), so I think they qualify for DT >>> enablement. And even if a user can't use them, it doesn't hurt to have >>> them (since they are not multiplexed). >> >> My main concern about this is that we'll leave regulators enabled by >> default, for a minority of users. And that minority will prevent to do >> a proper power management when the times come since we'll have to keep >> that behaviour forever. > > I think these users can add a 'fdt set /xxx/xxx status "disabled" ' . I don't think that will be necessary I'm pretty sure these extra usb ports do not have a regulator for the Vbus, they just hook directly to the 5V rail, can someone with a schematic check ? Regards, Hans