From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105483203AA for ; Wed, 5 Nov 2025 15:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762358263; cv=none; b=dQTnxbTBmohPhmb1wQeEo2ppgkQiZicwKCySKZX3+3xqIV08xzYQaY4YfZORWq1NehHUjVNuwXZzMJBCX0XnSCl1koGzGOafCTdlV5R+Ou5xvb4cVSbyLBKDOkqjcAFTNxZjmfAWtX+rLeAbZM7/XBc8r+rRFy2500xl2TdbLpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762358263; c=relaxed/simple; bh=YnSUOZY4yv1wHEA4ZNPWvccnW6Q2kz+n8Nso5t/pTU4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V+Ahtf/vOSxeaH/UZUURxLR5MFPbBXbUxy2tI1XQwebQGSYxVsXzTpYz5mSZBeIoram5/1/qfhtPQk1qygcBxxixdE5os0+iy8HL0Vdfb6KiiomQU406ZZQZwvPacwlk0NScjJ4GFQAD5Vj9TLj1oeQWa6ZD7VY5sC2Zplq6YFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=w3uwCUtr; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w3uwCUtr" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-640b4a52950so4637363a12.1 for ; Wed, 05 Nov 2025 07:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762358260; x=1762963060; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gi3ulz3Ij3cW2aD1iWY/9uEnz3868+Ej+OFb25qIT1E=; b=w3uwCUtr9zwYTYS+HIaCxRKDfjashVrjv0iXFeCl5/laHmeYSO1QE9ZzW9PDSiN3EP RRBV4B0KOUJaleYZHqcEpuzAYeDOFXnOGYLBCmmkjZlIQIrnLpCaBouegnd+lE1bSyXy 4FqC770PpKLpnVD+st56EFPblasKyx885SxTRMXhgD739PiPVIyJKzBsE1V06N4SUlis j98LegfTyOJijStI7duulhHFaXh4RnoKL724cV+7jzkfo3NFq/wce06fvSNfD63KvYJn i+UpEHACDeeCWQ4+e2SdHMRcqOOGRMV8ZSWs0fPiWZqJea1caeBRbZXL17f1OaFfay30 QF+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762358260; x=1762963060; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gi3ulz3Ij3cW2aD1iWY/9uEnz3868+Ej+OFb25qIT1E=; b=SEo3HCZJiRaFRLBHUw028IvqfCBBy5D+0LgOi3RkOLWV6N393Hcv7EDJujKFmm25Ke fRTuiJRSuOvJ3wjf/4OGNiEjrJSQzR+a5KymbcS4oG1qhKNG1cFMw/35vo9N4/Mpbp4T VIdnh8ugl5+BgDsdOhibvZGNcUdV7EI4eLEr/vhZfoB4yNhR5MS4ICP22SC6bM0BHmQE LxS1pOFBhIaaOz5Z5H86gYg4RTICy9D5jF7oZBFQRN9NKAMQtUaApz17SXnbF4aF2xKW x8G0hVoEtpRQBFQ+qMfumuFi3A4eW5T8fxmDBXpBKx1relXJ/doluw7rruj5uV2/43Qk Lwmw== X-Forwarded-Encrypted: i=1; AJvYcCUosZdAXzZc5odYvRZelmigxXqK2n/yhmYHIOAH2fFjrWoL36/q9jCl6QNOInlKy6VHlonlkH5Nv8VXLfk=@vger.kernel.org X-Gm-Message-State: AOJu0YyXVurnnDhGgkyMvx8Sp/Czr4J7t7P3KXsw+IK6hnllLsjmBzes LUg6SJrhX0JZbr9Aj79LyOMqMcyftSJqOUuSCDnd2XkfyX9pMt/q8oRGGBd/ErqNqtRpWDXpRNS a1xznbeScdw== X-Gm-Gg: ASbGncsHrCKrK1Uye27tyXauvZJbfUUeBo/GSjhIvE21MzlTD2yHTT2vWQKDQTtBOj3 m8NrtC8DCbxl4pEIYktTnGZ3WcacrFUt0U1Kb1kSeKAdz8nThsDNxKEs3cSoSSkmOF5PtB8wy5Y kvSGcKtUOvizOvgGsSPVD5EXA1e6L5OZKAEqC9T8D70WmYJqgJftwHfWp9I9UecACskAMCIZ1GV oZZocB3iHJ5rdSD6JaF3LcGF0wOE72YkDVhAe/y76h+6shooZd1toPgYHuiEH1cf4mDlAvKCYJm 9tyMzts6GLI0fsRSWmEdTSNuaPgwWRLyJl29rROLKp3c6q5ECk31HbVKFjF8WnXGJqYJ+T5jqI3 D4qof5QyyGk7t805JIHgGKqRuiLtlHmusiL2PrY0SamV1Y/8chptVGUjjmGxTCCbCsalWbaIXmZ CMkHKNd8uViy406LKeXxv15mM= X-Google-Smtp-Source: AGHT+IG8Ib7bTOk4rfnBCJBGTAFfgk2ImcjjuBmXvp18vfVvKZ16nOJ2X4KjkA2fJsMo226KrUYJSw== X-Received: by 2002:a17:907:6d0a:b0:b72:5983:db20 with SMTP id a640c23a62f3a-b72654f55c1mr405051366b.32.1762358260191; Wed, 05 Nov 2025 07:57:40 -0800 (PST) Received: from [172.20.148.132] ([87.213.113.147]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b723f6e26adsm522473466b.43.2025.11.05.07.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Nov 2025 07:57:39 -0800 (PST) Message-ID: Date: Wed, 5 Nov 2025 16:57:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/28] mtd: spinand: Fix kernel doc To: Miquel Raynal , Mark Brown , Richard Weinberger , Vignesh Raghavendra Cc: Pratyush Yadav , Thomas Petazzoni , Steam Lin , Santhosh Kumar K , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org References: <20251031-winbond-v6-17-rc1-oddr-v1-0-be42de23ebf1@bootlin.com> <20251031-winbond-v6-17-rc1-oddr-v1-4-be42de23ebf1@bootlin.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <20251031-winbond-v6-17-rc1-oddr-v1-4-be42de23ebf1@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/31/25 6:26 PM, Miquel Raynal wrote: > The @data buffer is 5 bytes, not 4, it has been extended for the need of > devices with an extra ID bytes. > > Fixes: 34a956739d29 ("mtd: spinand: Add support for 5-byte IDs") no fixes tag for documentation. with that: Reviewed-by: Tudor Ambarus (commit msg can be updated to smth like "update kernel doc comment" too) > Signed-off-by: Miquel Raynal > --- > include/linux/mtd/spinand.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index 927c10d7876958276a841a9f1278a74deeb89944..1c741145e49717169152854718f784e0e519ea92 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -287,7 +287,7 @@ struct spinand_device; > > /** > * struct spinand_id - SPI NAND id structure > - * @data: buffer containing the id bytes. Currently 4 bytes large, but can > + * @data: buffer containing the id bytes. Currently 5 bytes large, but can > * be extended if required > * @len: ID length > */ >