From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF2BC432C3 for ; Tue, 2 Feb 2021 20:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15B9C64F3F for ; Tue, 2 Feb 2021 20:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234184AbhBBU5J (ORCPT ); Tue, 2 Feb 2021 15:57:09 -0500 Received: from www381.your-server.de ([78.46.137.84]:42700 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232785AbhBBU4p (ORCPT ); Tue, 2 Feb 2021 15:56:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=PqrDYmSRZ2jD1Y+JGfHbNOAlNj1MP00eiAyBOLDtoQU=; b=fmMatPxJz5ZgY20zUyd/ODST3z nC7pWu0OK0vfR7PngMA6phQvDPOky4PyV+YvHsSV6JAzDoP5fo4zM8JyQueOw3b668/HlB0kTTAHc j+hQIoTGkymnbT3rFeOZ4pQ5weC31SPMe1Hh6RW4zIDDCHsSuNxkJyBgjW3Pm3dyyUVFG+xIvS0zC gNDxcLGMreVXYLFDu0TUTGn4wWu/CnLmB6hb0rYrHrbr4P5KClJRrcwC4WpHAp2FOpA5mQ9UrL7ID Lpz5J4mAV3Q0u6dvYlbJ6BAJq3GELpoOSE1L7Y4C05vMY5Qxh9c0Z3fviDQ1127oqLhXSvXidtbrC rmPjp1RQ==; Received: from sslproxy03.your-server.de ([88.198.220.132]) by www381.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1l72iL-0008rA-50; Tue, 02 Feb 2021 21:55:57 +0100 Received: from [62.216.202.92] (helo=[192.168.178.20]) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l72iK-000SPT-Vd; Tue, 02 Feb 2021 21:55:56 +0100 Subject: Re: [PATCH] dt-bindings: iio: dac: Add missing ad5686 compatible strings To: Rob Herring , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michael Hennerich , Jonathan Cameron , Peter Meerwald-Stadler , Michael Auchter , linux-iio@vger.kernel.org References: <20210202181427.3934218-1-robh@kernel.org> From: Lars-Peter Clausen Message-ID: Date: Tue, 2 Feb 2021 21:55:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210202181427.3934218-1-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.102.4/26068/Tue Feb 2 13:21:02 2021) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/2/21 7:14 PM, Rob Herring wrote: > The example uses 'adi,ad5686', but the schema fails to document it. Given > the filename and there is a similar part AD5686, let's just add the > compatible strings including the 'r' variant. There are two variants of this chip. One with a SPI interface and one with a I2C interface. This binding document only describes the I2C variants. But the ad5686 is a SPI variant. I think this is a typo and we should replace ad5686 with ad5696, including the document name. > > Cc: Lars-Peter Clausen > Cc: Michael Hennerich > Cc: Jonathan Cameron > Cc: Peter Meerwald-Stadler > Cc: Michael Auchter > Cc: linux-iio@vger.kernel.org > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > index 8065228e5df8..190919291828 100644 > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > @@ -19,6 +19,8 @@ properties: > - adi,ad5338r > - adi,ad5671r > - adi,ad5675r > + - adi,ad5686 > + - adi,ad5686r > - adi,ad5691r > - adi,ad5692r > - adi,ad5693