From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA83C0755A for ; Mon, 27 Nov 2023 13:38:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233105AbjK0Nhx (ORCPT ); Mon, 27 Nov 2023 08:37:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233121AbjK0Nhu (ORCPT ); Mon, 27 Nov 2023 08:37:50 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62744182; Mon, 27 Nov 2023 05:37:56 -0800 (PST) Received: from [100.107.97.3] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0144D660716E; Mon, 27 Nov 2023 13:37:53 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701092275; bh=HWTWeZczkKPebiHhuo5BZO805K/Z7hkRFhrXyPuPjTA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O4vVdIowbsdyovhSATp87/gj9HKXh6j9UJSHTbH31aSq12FPYr/dn7P0zBiDFOyjv V3iwiYBZjbpOt26uzfHwybMZkW6ursKUy4tVVUVa8fBhcHMnNAenrMuqbOqjK1Iq9W A+EOJVsocw7IPAvQ/Ofs+htd4g20OknlOv0kj1WMTRXH/GL39DM2hHCMjwF7IXj2IZ zJ9XOr0Q2w99UPgbon9Rk5R74FA9Bhowpr0vOmEgjZr1o1sN9bjxrM7HQqpUtP30pi f9eNbiezuDiF/RxrT3MhUwYXKoBLDU7RJfOdlgJlMfqdtsnS5VUgvVjnSPMhr5GyQ5 V2UQTO83VeVug== Message-ID: Date: Mon, 27 Nov 2023 14:37:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch Content-Language: en-US To: Macpaul Lin , Chunfeng Yun Cc: Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Bear.Wang" , Pablo Sun , Krzysztof Kozlowski , Vinod Koul , Rob Herring References: <20231125012303.760-1-chunfeng.yun@mediatek.com> <239def9b-437b-9211-7844-af4332651df0@mediatek.com> <0dc24d82-e09d-45bc-98ae-1dfb6318cb96@linaro.org> From: AngeloGioacchino Del Regno In-Reply-To: <0dc24d82-e09d-45bc-98ae-1dfb6318cb96@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 27/11/23 08:21, Krzysztof Kozlowski ha scritto: > On 27/11/2023 08:09, Macpaul Lin wrote: >> On 11/25/23 18:37, Krzysztof Kozlowski and Chunfeng Yun wrote: >>> >>> >>> External email : Please do not click links or open attachments until you >>> have verified the sender or the content. >>> >>> On 25/11/2023 02:23, Chunfeng Yun wrote: >>>> Due to some old SoCs with shared t-phy only support force-mode switch, and >>>> can't use compatible to distinguish between shared and non-shared t-phy, >>>> add a property to supported it. >>>> But now prefer to use "mediatek,syscon-type" on new SoC as far as possible. Two questions: 1. Why is it *not* possible to use the compatible string to distinguish between shared and non-shared T-PHYs? 2. If we really can't use compatibles, what's the reason why we can't use the "mediatek,syscon-type" property? Regards, Angelo >>>> >>>> Signed-off-by: Chunfeng Yun >>>> --- >>>> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> index 2bb91542e984..eedba5b7025e 100644 >>>> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> @@ -235,6 +235,12 @@ patternProperties: >>>> Specify the flag to enable BC1.2 if support it >>>> type: boolean >>>> >>>> + mediatek,force-mode: >>>> + description: >>>> + Use force mode to switch shared phy mode, perfer to use the bellow >>>