From: Pavel Hofman <pavel.hofman@ivitera.com>
To: Joe Perches <joe@perches.com>,
Colin Ian King <colin.i.king@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] usb: gadget: f_uac2: Fix spelling mistake "maxpctksize" -> "maxpcktsize"
Date: Wed, 2 Feb 2022 11:31:18 +0100 [thread overview]
Message-ID: <efcb90c2-cfbb-3264-bd6d-bca33b03fa48@ivitera.com> (raw)
In-Reply-To: <358563808e6cad1b003e4c5488cf65ff1267f1d8.camel@perches.com>
Dne 02. 02. 22 v 10:57 Joe Perches napsal(a):
> On Wed, 2022-02-02 at 09:19 +0000, Colin Ian King wrote:
>> There is a spelling mistake in a deb_dbg message. Fix it.
> []
>> diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
> []
>> @@ -755,7 +755,7 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o
>>
>> if (max_size_bw <= max_size_ep)
>> dev_dbg(dev,
>> - "%s %s: Would use maxpctksize %d and bInterval %d\n",
>> + "%s %s: Would use maxpcktsize %d and bInterval %d\n",
>
> why not just spell it out? or use wMaxPacketSize from the uapi include?
My reason for the ugly abbreviation (prone to misspelling for which I
apologize) was to keep the line length limit. I would be happy to see
wMaxPacketSize instead :-)
Pavel.
> ---
> drivers/usb/gadget/function/f_uac2.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
> index f2237bcdba7c0..13b59128121a2 100644
> --- a/drivers/usb/gadget/function/f_uac2.c
> +++ b/drivers/usb/gadget/function/f_uac2.c
> @@ -755,12 +755,12 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o
>
> if (max_size_bw <= max_size_ep)
> dev_dbg(dev,
> - "%s %s: Would use maxpctksize %d and bInterval %d\n",
> + "%s %s: Would use wMaxPacketSize %d and bInterval %d\n",
> speed_names[speed], dir, max_size_bw, bint);
> else {
> dev_warn(dev,
> - "%s %s: Req. maxpcktsize %d at bInterval %d > max ISOC %d, may drop data!\n",
> - speed_names[speed], dir, max_size_bw, bint, max_size_ep);
> + "%s %s: Req. wMaxPacketSize %d at bInterval %d > max ISOC %d, may drop data!\n",
> + speed_names[speed], dir, max_size_bw, bint, max_size_ep);
> max_size_bw = max_size_ep;
> }
>
>
>
prev parent reply other threads:[~2022-02-02 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 9:19 Colin Ian King
2022-02-02 9:57 ` Joe Perches
2022-02-02 10:31 ` Pavel Hofman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efcb90c2-cfbb-3264-bd6d-bca33b03fa48@ivitera.com \
--to=pavel.hofman@ivitera.com \
--cc=balbi@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®