From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751706AbdK0GW2 (ORCPT ); Mon, 27 Nov 2017 01:22:28 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45540 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbdK0GW0 (ORCPT ); Mon, 27 Nov 2017 01:22:26 -0500 Subject: Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages To: JianKang Chen , akpm@linux-foundation.org, mhocko@suse.com, mgorman@techsingularity.net, hillf.zj@alibaba-inc.com References: <1511594447-3836-1-git-send-email-chenjiankang1@huawei.com> Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xieyisheng1@huawei.com, guohanjun@huawei.com, wangkefeng.wang@huawei.com From: Anshuman Khandual Date: Mon, 27 Nov 2017 11:52:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1511594447-3836-1-git-send-email-chenjiankang1@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17112706-0012-0000-0000-00000591D2F6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17112706-0013-0000-0000-0000190CB382 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-27_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711270088 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2017 12:50 PM, JianKang Chen wrote: > From: Jiankang Chen > > __get_free_pages will return an 64bit address in 64bit System > like arm64 or x86_64. And this comment really confuse new bigenner of > mm. Normally its not 64 bit virtual address though CPU architecture supports 64 bits. But yes, specifying it as general virtual address without number of bits is better.