From: Jacob Keller <jacob.e.keller@intel.com>
To: Pavel Zhigulin <Pavel.Zhigulin@kaspersky.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: Zhu Yanjun <yanjun.zhu@linux.dev>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
Cosmin Ratiu <cratiu@nvidia.com>,
Ayush Sawal <ayush.sawal@chelsio.com>,
Harsh Jain <harsh@chelsio.com>,
"Atul Gupta" <atul.gupta@chelsio.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ganesh Goudar <ganeshgr@chelsio.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>
Subject: Re: [PATCH net v3] net: cxgb4/ch_ipsec: fix potential use-after-free in ch_ipsec_xfrm_add_state() callback
Date: Wed, 15 Oct 2025 11:07:32 -0700 [thread overview]
Message-ID: <efd3bfa7-d336-4a55-a185-055174e9b4e0@intel.com> (raw)
In-Reply-To: <20251013095809.2414748-1-Pavel.Zhigulin@kaspersky.com>
[-- Attachment #1.1: Type: text/plain, Size: 959 bytes --]
On 10/13/2025 2:58 AM, Pavel Zhigulin wrote:
> In ch_ipsec_xfrm_add_state() there is not check of try_module_get
> return value. It is very unlikely, but try_module_get() could return
> false value, which could cause use-after-free error.
> Conditions: The module count must be zero, and a module unload in
> progress. The thread doing the unload is blocked somewhere.
> Another thread makes a callback into the module for some request
> that (for instance) would need to create a kernel thread.
> It tries to get a reference for the thread.
> So try_module_get(THIS_MODULE) is the right call - and will fail here.
>
> This fix adds checking the result of try_module_get call
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 6dad4e8ab3ec ("chcr: Add support for Inline IPSec")
> Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@kaspersky.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2025-10-15 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 9:58 Pavel Zhigulin
2025-10-15 18:07 ` Jacob Keller [this message]
2025-10-16 0:26 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd3bfa7-d336-4a55-a185-055174e9b4e0@intel.com \
--to=jacob.e.keller@intel.com \
--cc=Pavel.Zhigulin@kaspersky.com \
--cc=andrew+netdev@lunn.ch \
--cc=atul.gupta@chelsio.com \
--cc=ayush.sawal@chelsio.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ganeshgr@chelsio.com \
--cc=harsh@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®