From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E1B63B8D59 for ; Mon, 8 Dec 2025 15:47:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765208855; cv=none; b=Z8wBL9ighiMWsbbD6hB0juk75Xxdy2NgcAypFoGlTVsolQDqwCWyVhq2Drvsb+Rz7Yu1G7fFiiaAUCbgclpfUqz0K7SxRMxXi4U3ahgYWutwiNTxCF3FY2abKnCB//BqvJMvenX7jfDCuIcIJ5yJuLSueuSwVWgJDHHCIwlpfro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765208855; c=relaxed/simple; bh=4fnOMgjetkJF3HKmZRMVlyn3xnBGJbVQAXJ3bmTzB3M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lldyXMC/ziAWsrTffBN0OpDWsgzPUR8VfU4sEnsh7y3YVXjO9Prpp6fD9SFVBndm3mhdR36zJm2tYVAlCBmqRMpOLDEtXuUGkmCJftRoFLnoWpH5nh3M7V+grCRr7s4f6F7QPxNvMbxCytsxBacSpkiCuUJpcGwfMQUZBzUdYzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KmFfo1Xp; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KmFfo1Xp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765208852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kgJIxL0CX5OTd128INGYaD4p8fQ/cO5lOBgWZ/PrYF8=; b=KmFfo1XpVL2ctW8uCKBp+3sWvGsN+Vmf6yNYmvXbYTgr1jU/WYdTAWC2NcAR7jCWESQW9O x0R8W74FIlWbkhu5mYAmHiCmspBXMlwtuxE8zzH3qhMJvQ1WzzDYAL0hQg+TCbQ7ZGgq85 j7XouidnSeuAlZu6XISsTmo0T8pQ0ow= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-3YLmCYOiP9uwn75S0ZrZyw-1; Mon, 08 Dec 2025 10:47:26 -0500 X-MC-Unique: 3YLmCYOiP9uwn75S0ZrZyw-1 X-Mimecast-MFC-AGG-ID: 3YLmCYOiP9uwn75S0ZrZyw_1765208845 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-343e262230eso5221471a91.2 for ; Mon, 08 Dec 2025 07:47:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765208845; x=1765813645; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kgJIxL0CX5OTd128INGYaD4p8fQ/cO5lOBgWZ/PrYF8=; b=ZsYMaiwqSZ5co901f3TWd87fCB6yPB06GJEVdtCsVhViQlhRBR3mAzHD8f0qPxZW3i JQjLK2hlgcJqebtBFJhIaujW64d5o6c8u3DLtDzG6RBU+kySE8SbPJLvAEaHANoOoXs9 NFT+Qm5r/zcLU3ZPxGdMAwPpZWr186H4Op7pIvqsXSvJeK0NwmqVv6PHCIOGPZQa1vKu L4zx1e4RKLj84uLLJF/Du23jycMGyyHWqhbxIhpXLeJYIlgVrek9IHc9aS2+X+9wCFj+ cvaS29m9gck6Covsz0n5B0ncURknVaQCiqvhWtsIi23GingGEDBTR+GHEe67iDVUysxy Hmwg== X-Forwarded-Encrypted: i=1; AJvYcCVUc6gDByejTgpWGcB/WVwYpvT/HIkd9DPg/UcQzmx7RL0efQkfNCrlEMJ7VtOtuNk7Y0LedxV6fL/sTuU=@vger.kernel.org X-Gm-Message-State: AOJu0YyquBFmLVeodT3tr1wbeDxyvqH1vL2Y84pC7yJGbi7mEw+llRZr YknSMhVMKLtbYNjMpsL+9bg/4r6DXQjJ4OcSEuhKuO6C7jwtPMrqQ3+3Qhp5a07qvzwRTYlRVHl 44K9ALjgYiHnhvYH2riemy/lBLBQTRgjMk7MaSVMmSQHIlJD74VO5zLOx5xqIRdpseQ== X-Gm-Gg: ASbGnctBiVDdB0MkWYRXRv6KaGLWGa89TKocZhhzEUyWrZmOHhuTozmS1bbI9FAxavL AFvcl9jS2ajJk7IDuVj6okREQFrxBJL3KNAGZEf54J/Ch7hB7FHqYGBVo7YCNtlDMP3lW+wcYV+ Mm40+KHgStljoY75vuksXAZqR3DXKA7FZPw/8wNflEqlkkOGJ7KW8gQTAlhV+b4kSKh0XlmGBPA ax5RJq1TqsMphFUtfgvxoRDY8a84QbbUliUg/W34s7l8S5cIQTqxmzqZNEyFd3NcGu1W2/YVKQV cgpEmDRO6hJZ7CTXo2ZvUYGiPjP2pOTLU+i2xO2FFOpYZJRO39yqBrkjweluhYOS0pBcxr1aokP x8ilE9slYHFK5c1PXbJz6bdVkJNC7Ro0Bu/z9DYraW69KPfePBDASJDJRxHaGgJXSlRn+PME/PA == X-Received: by 2002:a05:7022:e0d:b0:11b:ca88:c50f with SMTP id a92af1059eb24-11e032ae38cmr5385600c88.40.1765208845337; Mon, 08 Dec 2025 07:47:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGcI88OCdHn0429dQauXa74FPpbQ0zI+AbQVlLrbOvpfEmA7o1JoeSaFNGOnyv86keP6Q29fw== X-Received: by 2002:a05:7022:e0d:b0:11b:ca88:c50f with SMTP id a92af1059eb24-11e032ae38cmr5385574c88.40.1765208844810; Mon, 08 Dec 2025 07:47:24 -0800 (PST) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-48-76-65-77-217.dsl.bell.ca. [76.65.77.217]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df7552defsm56899085c88.2.2025.12.08.07.47.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 07:47:24 -0800 (PST) Message-ID: Date: Mon, 8 Dec 2025 10:47:19 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] selftests/mm: allocate 6 hugepages in va_high_addr_switch.sh To: Chunyu Hu , akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org, linux-mm@kvack.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com References: <20251207122239.3228920-1-chuhu@redhat.com> <20251207122239.3228920-2-chuhu@redhat.com> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20251207122239.3228920-2-chuhu@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-12-07 07:22, Chunyu Hu wrote: > The va_high_addr_switch test requires 6 hugepages, not 5. If running the > test directly by: ./va_high_addr_switch.sh, the test will hit a mmap 'FAIL' > caused by not enough hugepages: > ``` > mmap(addr_switch_hint - hugepagesize, 2*hugepagesize, MAP_HUGETLB): 0x7f330f800000 - OK > mmap(addr_switch_hint , 2*hugepagesize, MAP_FIXED | MAP_HUGETLB): 0xffffffffffffffff - FAILED > ``` > The failure can't be hit if run the tests by running 'run_vmtests.sh -t > hugevm' because the nr_hugepages is set to 128 at the beginning of > run_vmtests.sh and va_high_addr_switch.sh skip the setup of nr_hugepages > because already enough. > > CC: Luiz Capitulino > Fixes: d9d957bd7b61 ("selftests/mm: alloc hugepages in va_high_addr_switch test") > Signed-off-by: Chunyu Hu > --- > tools/testing/selftests/mm/va_high_addr_switch.sh | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh > index f89fe078a8e6..98f3dfab62c5 100755 > --- a/tools/testing/selftests/mm/va_high_addr_switch.sh > +++ b/tools/testing/selftests/mm/va_high_addr_switch.sh > @@ -111,8 +111,10 @@ setup_nr_hugepages() > > check_test_requirements > save_nr_hugepages > -# 4 keep_mapped pages, and one for tmp usage > -setup_nr_hugepages 5 > +# 5 keep_mapped hugepages are reserved in the first testings, and the last test > +# requires two hugepages, with one verlaped with the last second test, so one > +# extra, totally 6 hugepages IMHO, I'd just say "The HugeTLB tests require 6 pages", otherwise the fix look good to me. > +setup_nr_hugepages 6 > ./va_high_addr_switch --run-hugetlb > retcode=$? > restore_nr_hugepages