From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757917AbdEOM1N (ORCPT ); Mon, 15 May 2017 08:27:13 -0400 Received: from mout.web.de ([212.227.15.3]:54594 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbdEOM1M (ORCPT ); Mon, 15 May 2017 08:27:12 -0400 Subject: [PATCH 1/4] pcmcia: pd6729: Use kcalloc() in pd6729_pci_probe() From: SF Markus Elfring To: linux-pcmcia@lists.infradead.org Cc: LKML , kernel-janitors@vger.kernel.org References: <07cd817c-3045-72d8-34e2-e81b73efc291@users.sourceforge.net> Message-ID: Date: Mon, 15 May 2017 14:26:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <07cd817c-3045-72d8-34e2-e81b73efc291@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YLy3FjXYIX/H35c7Rkf0uVEAcKU05rixvtlELE4PPV54rNahkXv gMGTKC2FdSNhJa9TiMgaE68L3NtrFhm1nHjMGOsngMAGa6/EaRJeH9f88FbenpL0cxmIGNR vruVx+q5VSuBWGcZ6fihegBbwNB5M0JEhfQZPztuVKwdPov/vrQPpuXyWCMylHpV083YNbO vukNUbwcJt96nAfbSi+eQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:EdxpSVYzNIA=:eaqdieGmEKL4qEzVlcpD32 xbb9xR2vjPJdh3gvF+ozTUJHdlh/ib6VvkmR8a3wRtpf30gzYqDcHNcrq6K0QGksTSy0WoIdo 8DMnNb2MJu7DOsTIRW3oSwXbn+mw5qvf+9Es/w5mfAhALUxMLcYQCiPSdn7Y9TNRJTfjzCacZ Pgk7/2PTUuk8xIOMRw/Xgb2nY+2UT9rFwBKpkwDjASEyDaYNkZS0OIAvNCTT1dvhxOJ9dM2M3 BJDaLFGlF8qo++WJlRumcDSaIJTXBTceLYHEcKC1xaBUilcjisSUy1qS4tNHZc51X5JDTmgCI LYv1sUrhhGWAatjssufCOeUdMo2OK6XHqF78L9tmbkRtwNEFPm8Pp6tOQp4y5E+7AKYWZPuQQ 84e/EeplGeQK44Qmtxo23arjbuhkBc7JxebuurogbcqN3WiBlkb9P7/Iy0I5XmVzPjqVL2B1p Xlz0TW/5fWpkrkaJ/WcQ7/KoczyTHcqribS+sH/ep2ExIUF1quCteDyTl0zNF58FCE18ooFxz Z+V5Azvt+Sn8HE/n7j3ZVkZ/LFpGQHOqba4ImodbWkhlFUd+lPWyUmDIdGXrWJnC/xgLIjQTM XOaUOKbdBcZMg2VCSWHK6eXVmLjEEDVMBu+r7W+vLcyiIYOvUJ5TyuDgvfpfzs5rgQHFSETa+ LGLmWUZGxvYCgkJr/MxLoADhfeQ9/Io3HyZpd/7ItMlxgMl+gujdsvgZnKKsoweAt/TOKw10j uTIO2MWc9fPFtkPvQgAtv/jIZyvo9IEB/JdxiVMsMIFUK0d06wjxvjNm8LKh6K0m3sQDdMXcf lizVs/r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 15 May 2017 11:41:00 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/pcmcia/pd6729.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c index 0f70b4d58f9e..289a5e74e852 100644 --- a/drivers/pcmcia/pd6729.c +++ b/drivers/pcmcia/pd6729.c @@ -628,6 +628,5 @@ static int pd6729_pci_probe(struct pci_dev *dev, char configbyte; struct pd6729_socket *socket; - socket = kzalloc(sizeof(struct pd6729_socket) * MAX_SOCKETS, - GFP_KERNEL); + socket = kcalloc(MAX_SOCKETS, sizeof(*socket), GFP_KERNEL); if (!socket) { -- 2.13.0