From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D4A4352C44 for ; Sun, 11 Jan 2026 19:58:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768161487; cv=none; b=o89wqzf8rSHHdVzdLziCtTLj9MNDglbXm03rFXL/TszDu116Ar6HV0GLB53fIlTUbs6dzWG+6g3SvFkuHLbTgG6qTR1gs5R6eb+UacF7OTy1Fu5/6J2bwzUH9ayVOWtMnEbU2AaO4XKNTo+7qOPC6Nf2sL16DK8/FSnldjTabIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768161487; c=relaxed/simple; bh=z/9aym3YtgfCN06pEMgzSWhuMz1pnW2LST7SY6XR2LY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hh0+30V3/vmc60gQDVt5+jkzsxCBLm9wPI/iq4RPertU9ATVk3eFS6EzsvGA6XXV9DwD2TH2Z+mlEO8zxuy3M3/03+51wMzhoDLeM8niMUu0BG/t6GRsKAoqKA2rgQUag4TwcPDqhOJq25sd9/BnvDulWo5Ri/SURBgTkL70VRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=Dwl50Ziz; arc=none smtp.client-ip=209.85.222.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="Dwl50Ziz" Received: by mail-qk1-f193.google.com with SMTP id af79cd13be357-8b2d32b9777so864039085a.2 for ; Sun, 11 Jan 2026 11:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1768161484; x=1768766284; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rp7nIV1t3K3PnuJ7T0RnV1mDaWDy2tcwUgBfEvmqexc=; b=Dwl50ZizRYphHifgJPOcqzTPN2f5o22/3Hg6GyaX2pP400yqYVD40JF8MWpSSsvnff TCrvFVyOBEjCqcn9uma3DYzXrhw0PxFsRUyX/XvycnP0Gm1itqF+XLjG8wtreUXK0ctD oAHiAFNM9l/Lgp9CTfyG8GU+GU90o3znJQKGr783w11l8LiKkfCkHkgmeA3rEp/oo/FD wexT7QP/ZuUbeQ9jK68gTNcULdfyKQGRgzQQ5iTOw7yxAVC14nmXRtjrcksykif+Mynb vaSnRyf1JpUx2XRBRKvzhxQ59NyetMa5pLBTHFCzi4pfxYN3mT3ebSDyW4BnmtOkGi54 9PeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768161484; x=1768766284; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rp7nIV1t3K3PnuJ7T0RnV1mDaWDy2tcwUgBfEvmqexc=; b=a/fVm6jwFDU/EsnihxBbBzKcsnnF6H/kTzo1uhAhmdfVGkFxU3GJpMsI8F4gf5jCXm EcPSuNUjmSrQdXRwL3yFIECIoBQ+Wyd4uarsUmnxTQ0kikNuvJqo1rhmxApDxO3FJ5TR vdgOAYWjinxoJUOEyHI8+tr+e19sWPhsbAiCmF8Xiz2EXXzhit5RcoFkWq30y+c7KKcX PNMWzWOPxklr4NLoVwOf+TYNdbKy1IHN9vEmJhj0YbR7D9yT8Owfz2+qhtmcA5lNL2MA gFyIrjTXTWdUJHV6N3zpmnSAoVw4QySL4dAvSKI4JaDuwKOndVttaPTQ8Hr2J0ceRfN0 vdtg== X-Forwarded-Encrypted: i=1; AJvYcCW3/q9nWu86ddoOdrsMEYZnWdAoj4B5dA5n6jt5d5+YzfjhsdBOovT1fQ8+I3FD7ZlIouvqmtsnGfy3zuU=@vger.kernel.org X-Gm-Message-State: AOJu0YwWi2wbdaTU1HvBniFWpvOzN1av64LQaLqios2z5Pro5Ih3cDt7 kHzOtupn49FsdTW22yfAJ3NAAWBEf6oQIK7uiWh/epBnP3Mr/XvjKaPmN9lSsoM1/mw= X-Gm-Gg: AY/fxX5hbp0hVGUDJ6GmNu3tFbwu2+jtED3w6mINbVSicJaXRkLyTJ+jFR7qG8kJBfm IDws8+487wZM+kwSv4F8Q/ajiyIHjv3nJv6ZQRLu8Vm12vZzFpNbCeeOL+jlsQztBU9dhPrH7+U Z7YlG6vVE+oNeJiKbli5e9Vs6w/8DNEzXnxcnxEL7qMO7ddpC9rQS6da11J8p7Q0JOrZkSYGPxO lQj14sL6er1lbpKAwBY/mMhusmKtXXi0/cvDn1EGtAZZirDMOQofqb1q/qrBFMzFyEODK9QWABS irqoHpkIR7Gz8hkMzFWIuI/7R/CcImL1ZwlVIws8p/s0LrNybaAcAyVhy4wwnBu1NtPTJ4itdPR Z24OF1GmEVX+hPFJSB9jtCpOsHQrOIUPMzic8Urd6F5qcW2lZf0+XrkmtnB1Dx+gg8UHdHsaZ3C J0Zzm3/hW+QHTOz84tciHNTdVYBA6Cm8QZIEHo7VreuIDp4lDYdK88uBEemR/XS2vE X-Google-Smtp-Source: AGHT+IGdzsnyz2r9XcWFhgYQrFdZnMY+NLVEokAuWRYPrckTaify+dIl447b52d76HmKL9FYD5Hb5g== X-Received: by 2002:a05:620a:4804:b0:8be:8e5a:7a6c with SMTP id af79cd13be357-8c389416effmr2293547585a.73.1768161484118; Sun, 11 Jan 2026 11:58:04 -0800 (PST) Received: from [10.211.55.5] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f5312d3sm1325432385a.43.2026.01.11.11.58.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Jan 2026 11:58:03 -0800 (PST) Message-ID: Date: Sun, 11 Jan 2026 13:58:01 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] rtc: spacemit: default module when MFD_SPACEMIT_P1 is enabled To: Alexandre Belloni , Troy Mitchell Cc: Lee Jones , Yixun Lan , Andi Shyti , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org References: <20260108-p1-kconfig-fix-v5-0-6fe19f460269@linux.spacemit.com> <20260108-p1-kconfig-fix-v5-3-6fe19f460269@linux.spacemit.com> <20260109223839b59ca7ce@mail.local> Content-Language: en-US From: Alex Elder In-Reply-To: <20260109223839b59ca7ce@mail.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/9/26 4:38 PM, Alexandre Belloni wrote: > On 08/01/2026 16:38:56+0800, Troy Mitchell wrote: >> The RTC driver defaulted to the same value as MFD_SPACEMIT_P1, which >> caused it to be built-in automatically whenever the PMIC support was >> set to y. >> >> This is not always desirable, as the RTC function is not required on >> all platforms using the SpacemiT P1 PMIC. >> >> Acked-by: Alex Elder >> Signed-off-by: Troy Mitchell >> --- >> Change log in v5: >> - add Alex's tag >> - Link to v4: https://lore.kernel.org/all/20251225-p1-kconfig-fix-v4-3-44b6728117c1@linux.spacemit.com/ > > See my reply on v4, this is still a NAK for me, I don't believe this > change is necessary as soon as the default for MFD_SPACEMIT_P1 is m. Yes I have reconsidered what Alexandre was saying and now I agree with him, I don't believe this patch is required. -Alex >> --- >> drivers/rtc/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig >> index 50dc779f7f983074df7882200c90f0df21d142f2..53866493e9bbaf35ff0de85cbfe43e8343eadc1e 100644 >> --- a/drivers/rtc/Kconfig >> +++ b/drivers/rtc/Kconfig >> @@ -410,7 +410,7 @@ config RTC_DRV_SPACEMIT_P1 >> tristate "SpacemiT P1 RTC" >> depends on ARCH_SPACEMIT || COMPILE_TEST >> depends on MFD_SPACEMIT_P1 >> - default MFD_SPACEMIT_P1 >> + default m if MFD_SPACEMIT_P1 >> help >> Enable support for the RTC function in the SpacemiT P1 PMIC. >> This driver can also be built as a module, which will be called >> >> -- >> 2.52.0 >>