From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E55E47A70 for ; Mon, 22 Jan 2024 20:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705956683; cv=none; b=u6ZV7iIatkHwcucv/etDMoTyOTcqFyQ6cAhWNISc75eDt4rs2dk+KRf3PrNixQMyGzGHC5bZzWYU+s+3LBHEIZBJC0SEiLNTkyj/+OsU4NQx1EinAnyP82cRXFoGM1Ux2jpEcbDHWcZUwpNdckdrtoFZxQwoINz2oj5+x/aT45M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705956683; c=relaxed/simple; bh=P7+Q0co7AmFpvNFHcy0Jwqq8do84FC57zbRO0tNEkh4=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=VdXcO16b6QIYGG4INS22SfPN5jvAg5bWue+0lEJflKtHeRLOSdJ+z8trFZqHYPwl2D3lhxRwuIuZWRJqJjcYfU9LAlWNXaHycG46tMHYxxIpG5tTXureWZWi2y1lqx/QbvYZuyDlNi4jfBG2NZaGdvJOfQgd+kGURbc7fUTsr3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jannau.net; spf=pass smtp.mailfrom=jannau.net; dkim=pass (2048-bit key) header.d=jannau.net header.i=@jannau.net header.b=wrP0NJ2V; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=ZiyhvjvE; arc=none smtp.client-ip=64.147.123.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jannau.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jannau.net header.i=@jannau.net header.b="wrP0NJ2V"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ZiyhvjvE" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C677A320046F; Mon, 22 Jan 2024 15:51:19 -0500 (EST) Received: from imap53 ([10.202.2.103]) by compute1.internal (MEProxy); Mon, 22 Jan 2024 15:51:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jannau.net; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1705956679; x=1706043079; bh=HAFVDSjmtG uSNBOsIjxRld4wZCro6SBlL7gz48ZG4+0=; b=wrP0NJ2VJPnD5L05SmaHeNndf6 PHoJKM6MXwzyNnpEYrPGMzaVuFypoY0el0nxfPx1kKZ/ZtbfwGWgiTnEaEyJ414x Sti2RPm7roMkV40gCwErXrFIHpAgXtNfixjXzZBprSy95hLVdtGuTpn64vDfdfBq n6/WdS/f/d/Rh/amCM+BZ9uBu0oZetLfPHINqDRbcShwo9mCvgV21SR130Wq3GlW Xa9RbAwGMxiwoIY82g9px26Z0FLXbXUM0CbTD40vMUnGnHXs0cFGDqpx1+LRvqkS Xq1ccu61I4WPurjcseAYpLL3FiX5Txh7yPjsNJyt0bwPZCatGITCoF3/Bi6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1705956679; x=1706043079; bh=HAFVDSjmtGuSNBOsIjxRld4wZCro 6SBlL7gz48ZG4+0=; b=ZiyhvjvE9MkiMJZcvPcZuBAEDkx0Sl8W18pam+aMKUDL nkYvPdMUSm01qfMGpBvR+rgMby/MldT9IlsE9rVftMe0cnn9BZBxKzDjGYG4baJy XUQ0ADDvEJiOnjzCifFPOcydH0nt/aRPzOZMgwkAtKIIrcL4roHXqOLA4CdraD0U NFe4yft0+YJXgrSPbDbvqcKhczLiQNhz+/b/dK0vRcX4iZXY8FtBCWa4ajuBse54 Mlw4+3Ubn4DBTjkVg06i08/Q9WKu6Q4QhByPl/E++t3ssCWxDWPX7xDZunzYqFLJ BlLh0yryk+2OjhETIVNEr4qnO78BoMA8nwcDuHLL/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekiedgudeflecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdfl rghnnhgvucfirhhunhgruhdfuceojhesjhgrnhhnrghurdhnvghtqeenucggtffrrghtth gvrhhnpeegteelvdfghedugefffeejgfehffdtffehgefhieelhfehffetteduteehieev feenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhesjhgrnhhnrghurdhnvght X-ME-Proxy: Feedback-ID: i47b949f6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0EA65364006B; Mon, 22 Jan 2024 15:51:18 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-119-ga8b98d1bd8-fm-20240108.001-ga8b98d1b Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: In-Reply-To: <20240117104448.6852-1-arnd@kernel.org> References: <20240117104448.6852-1-arnd@kernel.org> Date: Mon, 22 Jan 2024 21:50:56 +0100 From: "Janne Grunau" To: "Arnd Bergmann" , "Alyssa Rosenzweig" , =?UTF-8?Q?Martin_Povi=C5=A1er?= Cc: asahi@lists.linux.dev, "Hector Martin" , "Arnd Bergmann" , "Sven Peter" , "Asahi Lina" , dri-devel@lists.freedesktop.org, LKML Subject: Re: [PATCH] drm: apple: mark local functions static Content-Type: text/plain Hej, On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote: > From: Arnd Bergmann > > With linux-6.8, the kernel warns about functions that have no > extern declaration, so mark both of these static. > > Fixes: 2d782b0d007d ("gpu: drm: apple: Add sound mode parsing") > Signed-off-by: Arnd Bergmann > --- > This is for the bits/200-dcp branch in https://github.com/AsahiLinux/linux, > the code is not yet upstream. > --- > drivers/gpu/drm/apple/parser.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/apple/parser.c > b/drivers/gpu/drm/apple/parser.c > index 44aad9a64f9a..ea9f40bb7de2 100644 > --- a/drivers/gpu/drm/apple/parser.c > +++ b/drivers/gpu/drm/apple/parser.c > @@ -694,7 +694,7 @@ int parse_epic_service_init(struct dcp_parse_ctx > *handle, const char **name, > return ret; > } > > -int parse_sample_rate_bit(struct dcp_parse_ctx *handle, unsigned int > *ratebit) > +static int parse_sample_rate_bit(struct dcp_parse_ctx *handle, > unsigned int *ratebit) > { > s64 rate; > int ret = parse_int(handle, &rate); > @@ -715,7 +715,7 @@ int parse_sample_rate_bit(struct dcp_parse_ctx > *handle, unsigned int *ratebit) > return 0; > } > > -int parse_sample_fmtbit(struct dcp_parse_ctx *handle, u64 *fmtbit) > +static int parse_sample_fmtbit(struct dcp_parse_ctx *handle, u64 *fmtbit) > { > s64 sample_size; > int ret = parse_int(handle, &sample_size); thanks, patch included in my dev branch and will be in the next pull request I'll send to Hector. I suppose the recipients are generated by an automated get_maintainers.pl invocation. Is that desired for out of tree drivers? best regards, Janne