From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B33BD28F939 for ; Tue, 22 Apr 2025 16:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745339830; cv=none; b=OSM0uNiaj9UBL3aH5GPsgjPXKqWtjeQvd+OWPZ2Dtiq68AB4+zr76szSmd98G0Lhoo3jZyksS3OwVZgYdnWXdY9WLKpZx/OH5yYiEaJFFKIIAe+cVRrjel2S3AfuOfXu8ZcQkcF5mGqMq1Rhn36fnqMM7E6wbuiFWjipNh/6L6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745339830; c=relaxed/simple; bh=nZrPMxYNkgQAw1l+m5oRrg6n8nxqvbfX20bz/ewIQt8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mCTmidq2fnhjvPno/PEmYIBPvs9Lnhx1Vfamr8wa2FEloZGcaZvJxizPRWipL4ZftN4Bz0e28APBuHFJHKDbVmKoYNgpd6gRVnTnw9H9Ss/RFAebEMK6rBhyp+eZFCGWglrYOR9yJjLfIoSsD+J1cZwlB9o7TnbgtLSrrXwZeDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=t7JtO7ox; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="t7JtO7ox" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-400fa6eafa9so3479192b6e.1 for ; Tue, 22 Apr 2025 09:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745339828; x=1745944628; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Pep2KTX2D95/sTe/gu9n1JKfRNihxNZ6pUsc7YWRGr0=; b=t7JtO7oxnZAPViyPe1Pa4ZJ+SS4jWY0tN0KjPhhxNyG2PbTRd/3bNy6wLFyVLebTDP Zf28LRCZQDP2HO/pyFDP4vTj5+/NcuFRr1UyzWBMqd+aLsy3QCO4HDFiBw/59nnCy2gv 2nFswnoKWnShtMAUGVxDWEsEzFVBLs6yySQKOfdKKqua0m/WtTIhTwYlgTamn6K4Qp6b cNHJvKixgrNm0HrfSSG0q2KL+IWmtqK+1yyDBftLGIDBDrot+Sc3pGhDnojqkA/o1l96 /xZ8bvYPqFysVj2tm8l+cHOuI8zbXQsEEH+kEm5A+1MUK/nAiZgaSbyPig3FW2LzUd8d Wzig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745339828; x=1745944628; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pep2KTX2D95/sTe/gu9n1JKfRNihxNZ6pUsc7YWRGr0=; b=mKScAdHVSnzlmw+pzI5XCG8DZu9TLFK9ywAxIHmpYd9PvM1DIYS9tGk5JyeMJqtUt7 nMPKr94Ppgnwbm/4vyoHjsKjuq9PdyNuST9dJAaP8kExYokm1EchXYsBmAw03Io5jc3G YO/BZIZLkgB85oeopgkuBDs4t+ryYXFw/lIy19MPGW+9DZlzKd+BFb/E4Vk2NNmiLbLS Micl9xpiK5xcxkL49/V9x7NX+XduFmVUmsTx/tzkXcta1dko9D3h8EvmXHG8ZRDbPEAV 1Eoegud7h0ODXGzGRBnaOYA48feIV/MJL+qigSIo5wyPs/TLlJNhEbDmV6MvEd1PDG7Z 1u/Q== X-Forwarded-Encrypted: i=1; AJvYcCXrBm4x5rGTaZG/V4FcYNh42CVq4K3Kh3OV4TtpbSfHq0PwBuGjElwMLRo0sgy5t8TeMloeX6fevIkD9ds=@vger.kernel.org X-Gm-Message-State: AOJu0Yzsk5P0XgicORh9n2LB0ZkPnjegBkETRGBb/g46y6UrtR6WzCOt XFhKbfRk+gFBds1mpzVwGVSZzleO7CLQjJcsq84FqsAT6/besVp+dGckQpniBMc= X-Gm-Gg: ASbGnctgRMODa9nLxKklBhpgu4PLsX0gScER0S8QB/5auPHk5LwRnxM0f2mH86bPAHo pFriLIxxuWpcx2WndJSsAOgg4B3bTOCqh+Qt6UhmlcI7TOIYdOtI/B5IizfIk1Q+7CS4miStC2x l/S/Pis+ShPMdj3j1GX2bNMEVcvoZ5duhzfKyg2VT3NppE/Agc3SUXa+odnzygPRDTKVQkJeZPc T50a0wJmbd+ADvofghzvhm7tkYhGp8lB0mN9HbxS/fSFfqrzVo+lT6nEyienupKRYSlZNz0CpAg 9b0/lJhbn7GGff6Aief/KoE/9X6NFBzMfhEyEh5DU6QlyimYgyr/ZMwlOrDXqL4bleYfa0BjKU7 a5GvsreypbBaa+asdBA== X-Google-Smtp-Source: AGHT+IEsNtQ5cBYHOB91x37Mh5K6Ezpdmm9D8utb/XIypNd8fTQbJlQwrNsui/TKQd2P0uFIbfLWhQ== X-Received: by 2002:a05:6808:80cc:b0:3f6:aad5:eac8 with SMTP id 5614622812f47-401c0932754mr8613325b6e.6.1745339827721; Tue, 22 Apr 2025 09:37:07 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:c8d1:e0ed:ce8b:96a3? ([2600:8803:e7e4:1d00:c8d1:e0ed:ce8b:96a3]) by smtp.gmail.com with ESMTPSA id 5614622812f47-401beeea9c0sm2170837b6e.22.2025.04.22.09.37.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 09:37:07 -0700 (PDT) Message-ID: Date: Tue, 22 Apr 2025 11:37:06 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] iio: dac: ad3530r: Add driver for AD3530R and AD3531R To: Andy Shevchenko , Kim Seer Paller Cc: Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Nuno_S=C3=A1?= , =?UTF-8?Q?Nuno_S=C3=A1?= , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250421-togreg-v5-0-94341574240f@analog.com> <20250421-togreg-v5-3-94341574240f@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/22/25 10:11 AM, Andy Shevchenko wrote: > On Mon, Apr 21, 2025 at 12:24:54PM +0800, Kim Seer Paller wrote: ... > >> +#define AD3530R_INTERNAL_VREF_MV 2500 > > _mV (yes, with Volts and Amperes we use proper spelling). When did we start doing that? No one asked me to do this in any of the new drivers I did in the last year, so I didn't know this was a thing we should be doing. > >> +#define AD3530R_LDAC_PULSE_US 100 > > ... > >> + int (*input_ch_reg)(unsigned int c); > > c? channel? > > ... > >> + int vref_mv; > > _mV > > ... > >> +static int ad3530r_input_ch_reg(unsigned int c) >> +{ >> + return 2 * c + AD3530R_INPUT_CH; >> +} >> + >> +static int ad3531r_input_ch_reg(unsigned int c) >> +{ >> + return 2 * c + AD3531R_INPUT_CH; >> +} > > c --> channel > > ... > >> +static const char * const ad3530r_powerdown_modes[] = { >> + "1kohm_to_gnd", > > kOhm > >> + "7.7kohm_to_gnd", > > Ditto. > >> + "32kohm_to_gnd", > > Ditto. These are defined by sysfs ABI, so can't be changed otherwise it would break userspace. Comes from... What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_powerdown_mode > >> +}; >