From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9989E21501D for ; Tue, 8 Oct 2024 20:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728418145; cv=none; b=qUerKsM856m8hGH0bjAvfkiZoOjbSEDxTCmUp4AGmgtyiZv6cryX+RlB3ou/eKJZPdRUnX8NalOnR1oa1z0KqY6TctWnIBOdLdbyvV/O9z0g7hlhHG40yiTG8mqWnm4mJOdsxqA2IpkRzTtIuB5EMFqGJM+d2Rhx0J/q/4B/0XQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728418145; c=relaxed/simple; bh=96/WBjjCEcTbhseVkSHqRdoAVNyBPwQ7jQ4AqTUbNrk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qWJRdSOMH268s03DGHaggZpK48RHcsI8+lupPBFJmOugjSbZbWYgadvBL+vmL1yaH5xt3YKyXrrDUR/zsx2cRA6imAfOfgWUCDTcfjU+GX5n/eW+2znTFO9U4uRTLXtM3fZTQk7SQpFfgbuh3c49rA6+Q1fulgafjC+wUWDXMxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d71Dakmf; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d71Dakmf" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-8323dddfca2so297219639f.2 for ; Tue, 08 Oct 2024 13:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728418143; x=1729022943; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9huRF/wNisHHqCSWMJS/4iRoGweiDoPtDUbse6lb6K4=; b=d71DakmfBmwNVz5JYQ9E6ssL596Ngaqa9W4eF7arqc1x4UzEKI0BH2DqhG/L5kHYeP FYm7lr39ALILaIcoy5PK6774YB1++A6w9jnAR3KWrtuzYGKtmSiWchDb9NsYAiW05jYF XWTgg315leIGR76gbMdVicAbp0RXXrx6TE2i0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728418143; x=1729022943; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9huRF/wNisHHqCSWMJS/4iRoGweiDoPtDUbse6lb6K4=; b=N3FZygOMfZWEQ+rzD60rLrT8016+L7RJCkAnaexOouwMnnagMWAiG1LXzjx6csTyKc Y+WYP0FAV7WQBVmPStIXVBijvQ2bfWu6AI2XZoXX6FnD5ilUU5IZsUYIEBWLZKYZgPxu xLormflXKQJRHrm+de8IuEcT5YcI59alyy+XuLM4YW2Q+qu5RTuKwljOREu89Wwm0yAX BpeqatKl731tGEWdEtJTs9Elmg6dWrNTPdd/S8dlQZtkHylV7mNrKMAJIvTD5fACF0q9 9561kTakWZucA1W3rUXstk/sPC5Awub1WOTt199EyaMUiLIlDidn5VyB9in4zOU1+ZaK GuGA== X-Forwarded-Encrypted: i=1; AJvYcCXIuwC801d4lc9M3dgApTrL7WFx+okhZWNcB0uGg+QW6WmJ0rGceaNOmwHOsQrRUDj0AVulPvmzD/iHlk0=@vger.kernel.org X-Gm-Message-State: AOJu0YxUqVzn5DteWYdLUMeJYAV/HeoDNBYwXd3SdwAvWh1NZBee9XCP LjegHqBxjORugQr90M8dWR44eh1peWOJ6H3r9Oj9GlGzj0htlSsxK9ApAIkINWQ= X-Google-Smtp-Source: AGHT+IGHl7cgy6p1Go9Zcy53EN9p/6bAdeTKO57a6EqLNuq/Hk7nBTr1o35VUqdXGpWut7AJPDr5dw== X-Received: by 2002:a05:6602:2b87:b0:82a:2a0b:1c7d with SMTP id ca18e2360f4ac-8353d484d1emr23105639f.5.1728418142626; Tue, 08 Oct 2024 13:09:02 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4db83190a9asm1220476173.91.2024.10.08.13.09.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 13:09:02 -0700 (PDT) Message-ID: Date: Tue, 8 Oct 2024 14:09:01 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] selftests: sched_ext: Add sched_ext as proper selftest target To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Tejun Heo , David Vernet , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mark Brown Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , bpf@vger.kernel.org, linux-riscv@lists.infradead.org, Anders Roxell , Shuah Khan References: <20241008153519.1270862-1-bjorn@kernel.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241008153519.1270862-1-bjorn@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/8/24 09:35, Björn Töpel wrote: > From: Björn Töpel > > The sched_ext selftests is missing proper cross-compilation support, a > proper target entry, and out-of-tree build support. > > When building the kselftest suite, e.g.: > > make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \ > TARGETS=sched_ext SKIP_TARGETS="" O=/output/foo \ > -C tools/testing/selftests install > > or: > > make ARCH=arm64 LLVM=1 TARGETS=sched_ext SKIP_TARGETS="" \ > O=/output/foo -C tools/testing/selftests install > > The expectation is that the sched_ext is included, cross-built, the > correct toolchain is picked up, and placed into /output/foo. > > In contrast to the BPF selftests, the sched_ext suite does not use > bpftool at test run-time, so it is sufficient to build bpftool for the > build host only. > > Add ARCH, CROSS_COMPILE, OUTPUT, and TARGETS support to the sched_ext > selftest. Also, remove some variables that were unused by the > Makefile. Thank you for adding this to change log. Maybe we need to add this to kselftest.rst at some point. > > Signed-off-by: Björn Töpel > --- > v3: * Always build a build host version of bpftool (Mark) > * Make sure LLVM style "ARCH only" cross-build works (Mark) > > v2: * Removed the duplicated LLVM prefix parsing (David) > * Made sure make clean didn't do a complete mess (David) > * Added sched_ext to default skip (Shuah) Thank you. Reviewed-by: Shuah Khan thanks, -- Shuah